cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

Require the AlpakaService to be enabled before running on a Device [12.5.x]

Open fwyzard opened this issue 3 years ago • 10 comments

PR description:

Require the AlpakaService to be enabled before running on a Device.

Move the check that the corresponding AlpakaService is enabled from the beginStream() method of each EDProducer to the alpakatools::chooseDevice() central function.

This replicates the behaviour currently used by the CUDA "framework".

PR validation:

Unit tests pass.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #39498 to 12.5.x.

fwyzard avatar Sep 25 '22 16:09 fwyzard

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_5_X.

It involves the following packages:

  • HeterogeneousCore/AlpakaCore (heterogeneous)
  • HeterogeneousCore/AlpakaTest (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks. @makortel, @missirol, @rovere this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

  • Backported from #39498

cmsbuild avatar Sep 25 '22 16:09 cmsbuild

backport #39498

fwyzard avatar Sep 25 '22 16:09 fwyzard

please test

fwyzard avatar Sep 25 '22 16:09 fwyzard

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a4aa4/27762/summary.html COMMIT: 3b56704c81ebc243eeb41407cdf93b692b4ee594 CMSSW: CMSSW_12_5_X_2022-09-25-0000/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39497/27762/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3699454
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3699418
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Sep 25 '22 20:09 cmsbuild

Pull request #39497 was updated. @cmsbuild, @makortel, @fwyzard can you please check and sign again.

cmsbuild avatar Oct 03 '22 16:10 cmsbuild

enable gpu

fwyzard avatar Oct 03 '22 16:10 fwyzard

please test

fwyzard avatar Oct 03 '22 16:10 fwyzard

-1

Failed Tests: RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a4aa4/27946/summary.html COMMIT: 5e92241f5231411e8f4b0568ed2c5ea20a67086d CMSSW: CMSSW_12_5_X_2022-10-03-1100/el8_amd64_gcc10 Additional Tests: GPU User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39497/27946/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 50204.050204.0_QQH1352T_13+QQH1352T_13INPUT+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_QQH1352T_13+QQH1352T_13INPUT+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
  • 50205.0DAS Error
  • 50206.0DAS Error
Expand to see more relval errors ...
  • 50207.0
  • 50208.0
  • 1003.0
  • 1010.0
  • 1020.0
  • 1102.0
  • 4000.0
  • 4001.0
  • 4002.0
  • 4003.0
  • 10004.0
  • 10008.0
  • 10023.0
  • 10024.1
  • 10024.2
  • 10024.4
  • 10025.0
  • 10071.0
  • 10224.0
  • 10801.0
  • 10804.0
  • 10805.31
  • 10806.0
  • 10823.0
  • 10824.5
  • 10824.501
  • 10824.6
  • 10824.8
  • 10842.0
  • 10842.505
  • 11024.0
  • 11024.15
  • 11025.0
  • 11224.6

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3699454
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3699424
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • Reco comparison had 3 failed jobs
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19876
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19866
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 03 '22 22:10 cmsbuild

please test

fwyzard avatar Oct 03 '22 22:10 fwyzard

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a4aa4/27958/summary.html COMMIT: 5e92241f5231411e8f4b0568ed2c5ea20a67086d CMSSW: CMSSW_12_5_X_2022-10-03-1100/el8_amd64_gcc10 Additional Tests: GPU User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39497/27958/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3699454
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3699418
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19876
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19868
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 04 '22 03:10 cmsbuild

Pull request #39497 was updated. @cmsbuild, @makortel, @fwyzard can you please check and sign again.

cmsbuild avatar Oct 28 '22 12:10 cmsbuild

Rebased.

fwyzard avatar Oct 28 '22 12:10 fwyzard

enable gpu

fwyzard avatar Oct 28 '22 12:10 fwyzard

please test

fwyzard avatar Oct 28 '22 12:10 fwyzard

+heterogeneous

fwyzard avatar Oct 28 '22 12:10 fwyzard

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Oct 28 '22 12:10 cmsbuild

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a4aa4/28602/summary.html COMMIT: 1a3bb770bbec8fcae45045dd5b4c2963371fbd3d CMSSW: CMSSW_12_5_X_2022-10-28-1100/el8_amd64_gcc10 Additional Tests: GPU User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39497/28602/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3702776
  • DQMHistoTests: Total failures: 148
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3702606
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19876
  • DQMHistoTests: Total failures: 16
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19860
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 28 '22 19:10 cmsbuild

+1

perrotta avatar Oct 29 '22 06:10 perrotta