cms-sw
Adding photon and muon leg trigger filters of HLT_Mu17_Photon30_IsoCa…
Adding photon and muon leg trigger filters of HLT_Mu17_Photon30_IsoCaloId_v* as requested in https://github.com/cms-sw/cmssw/issues/39069. To be backported to 12_4_8.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39309/31994
-
This PR adds an extra 16KB to repository
-
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/triggerObjects_cff.py modified in PR(s): #39230
A new Pull Request was created by @mrcthiel for master.
It involves the following packages:
- PhysicsTools/NanoAOD (xpog)
@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks. @gpetruc, @swertz this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f8ab1/27366/summary.html
COMMIT: 108598f7cfc27c23f11927f024295514be8fc2e7
CMSSW: CMSSW_12_6_X_2022-09-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39309/27366/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 15 differences found in the comparisons
- DQMHistoTests: Total files compared: 51
- DQMHistoTests: Total histograms compared: 3618210
- DQMHistoTests: Total failures: 33
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3618155
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
- Checked 212 log files, 49 edm output root files, 51 DQM output files
- TriggerResults: no differences found
Integration test running: https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/-/issues/191
@mrcthiel apologies for the delay.
In #39069 the following filters are also listed for 2016:
hltMu17Photon30CaloIdLL1ISOHEFilter
hltMu17Photon30CaloIdLL1ISOORHEFilter
hltL3fL1sL1Mu5IsoEG18L1f5L2f7L3Filtered17
hltL3fL1sL1Mu5IsoEG18ORL1Mu5IsoEG20L1f5L2f7L3Filtered17
but I don't see them added here, and indeed 2016 samples don't see any changes in muon and photon trigger objects. Are those not needed?
About this:
To be backported to 12_4_8.
There will be no backports to 12_4_X as NanoV10 is now closed in 12_4_8.
I already included 2016 paths by hand in my private area, so I do not need them. I just asked for the other paths (used in 2017 and 2018) thinking in the Run III data.
If these filter bits are relevant, other people analyzing 2016 data might want to use them, so I think for completeness it would be good to include them as well, thanks.
@mrcthiel will you update the PR with the 2016 filters?
Also, we have now decided that we would backport changes to the trigger object filter names to 124X to allow prompt nano to pick up those changes, even if it breaks compatibility with Run2 or existing V10 samples. Can you please also make a backport to 124X ?
In principle the same changes should then also be applied to the frozen V10 config in master, in this PR: https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/V10/triggerObjects_cff.py
Sorry, I didn't update yet, I'm debugging another problem with 2016 filters. It seems there is a problem with the filter on 2016H and for 2016 MC, which uses the same path but is different from 2016B-G.
If you have urgency for the backport I would propose keeping the 2017-2018 filters and I'll keep debugging for 2016, let me know.
Ok we can run with what you have here - as I said more work is needed on those objects anyway. Can you just please apply the same changes to https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/V10/triggerObjects_cff.py before you make the backport to 124X?
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f8ab1/28663/summary.html
COMMIT: 108598f7cfc27c23f11927f024295514be8fc2e7
CMSSW: CMSSW_12_6_X_2022-10-30-2300/el8_amd64_gcc10
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39309/28663/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 4 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3416356
- DQMHistoTests: Total failures: 32
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3416302
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 206 log files, 48 edm output root files, 48 DQM output files
- TriggerResults: no differences found
NANO Comparison Summary
@slava77 comparisons for the following workflows were not done due to missing matrix map:
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.001_data80X+MuonEG2016HMINIAOD8.0+NANO_data8.0+HRV_NANO_data
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.0_mc80X+TTbarMINIAOD8.0+NANO_mc8.0+HRV_NANO_mc
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.101_mc94Xv2+TTbarMINIAOD9.4v2+NANO_mc9.4v2+HRV_NANO_mc
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.11_data94X2016+MuonEG2016MINIAOD9.4v2+NANO_2016data9.4v2+HRV_NANO_data
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.12_data94Xv2+MuonEG2017MINIAOD9.4v2+NANO_data9.4v2+HRV_NANO_data
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.1_mc94X2016+TTbar2016MINIAOD9.4v2+NANO_2016mc9.4v2+HRV_NANO_mc
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.21_data102X+MuonEG2018MINIAOD10.2+NANO_data10.2+HRV_NANO_data
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.2_mc102X+TTbarMINIAOD10.2+NANO_mc10.2+HRV_NANO_mc
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.301_mc106Xul17+TTbarMINIAOD10.6_UL17v1+NANO_mc10.6ul17v1+HRV_NANO_mc
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.302_mc106Xul18+TTbarMINIAOD10.6_UL18v1+NANO_mc10.6ul18v1+HRV_NANO_mc
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.311_mc106Xul17v2+TTbarMINIAOD10.6_UL17v2+NANO_mc10.6ul17v2+HRV_NANO_mc
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.312_mc106Xul17v2+TTbarMINIAOD10.6_UL18v2+NANO_mc10.6ul18v2+HRV_NANO_mc
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.31_mc106Xul17v2+TTbarMINIAOD10.6_UL16v2+NANO_mc10.6ul16v2+HRV_NANO_mc
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.321_data106Xul17+MuonEG2017MINIAOD10.6v1+NANO_data10.6ul17v1+HRV_NANO_data
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.322_data106Xul18+MuonEG2018MINIAOD10.6v1+NANO_data10.6ul18v1+HRV_NANO_data
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.32_data106Xul16+MuonEG2016MINIAOD10.6v1+NANO_data10.6ul16v1+HRV_NANO_data
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.331_data106Xul17v2+MuonEG2017MINIAOD10.6v2+NANO_data10.6ul17v2+HRV_NANO_data
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.332_data106Xul18v2+MuonEG2018MINIAOD10.6v2+NANO_data10.6ul18v2+HRV_NANO_data
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.33_data106Xul16v2+MuonEG2016MINIAOD10.6v2+NANO_data10.6ul16v2+HRV_NANO_data
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.3_mc106Xul16+TTbarMINIAOD10.6_UL16v1+NANO_mc10.6ul16v1+HRV_NANO_mc
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.401_mc122Xrun3+TTbarMINIAOD12.2+NANO_mc12.2+HRV_NANO_mc
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.4_mc122Xrun3_v10+TTbarMINIAOD12.2+NANO_mc12.2_v10+HRV_NANO_mc
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.501_mc124Xrun3+TTbarMINIAOD12.4+NANO_mc12.4+HRV_NANO_mc
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.511_data124Xrun3+MuonEG2022MINIAOD12.4+NANO_data12.4+HRV_NANO_data
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.51_data124Xrun3_v10+MuonEG2022MINIAOD12.4+NANO_data12.4_v10+HRV_NANO_data
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.5_mc124Xrun3_v10+TTbarMINIAOD12.4+NANO_mc12.4_v10+HRV_NANO_mc
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4f8ab1/2500.6_mc126X_v10+TTBarMINIAOD12.6+NANO_mc12.6_v10+HRV_NANO_mc
Summary:
- No significant changes to the logs found
- Reco comparison results: 0 differences found in the comparisons
- DQMHistoTests: Total files compared: 29
- DQMHistoTests: Total histograms compared: 28879
- DQMHistoTests: Total failures: 355
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 28524
- DQMHistoTests: Total skipped: 0
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
- Checked 66 log files, 0 edm output root files, 29 DQM output files
Nano size comparison Summary:
| Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
|---|---|---|---|---|---|---|---|---|
| 2500.0 | 2.168 | 2.168 | 0.000 ( +0.0% ) | 7.14 | 6.99 | +2.2% | 1.376 | 1.385 |
| 2500.001 | 1.127 | 1.127 | 0.000 ( +0.0% ) | 10.26 | 9.77 | +5.1% | 1.357 | 1.351 |
| 2500.1 | 2.295 | 2.295 | 0.000 ( +0.0% ) | 5.35 | 5.30 | +1.0% | 1.683 | 1.742 |
| 2500.101 | 2.349 | 2.349 | 0.000 ( +0.0% ) | 4.50 | 4.50 | +0.2% | 1.740 | 1.889 |
| 2500.11 | 1.219 | 1.219 | 0.000 ( +0.0% ) | 8.21 | 8.13 | +0.9% | 1.584 | 1.562 |
| 2500.12 | 1.320 | 1.318 | 0.001 ( +0.1% ) | 6.07 | 6.08 | -0.2% | 1.724 | 1.774 |
| 2500.2 | 2.192 | 2.192 | 0.000 ( +0.0% ) | 5.28 | 5.30 | -0.2% | 1.705 | 1.873 |
| 2500.21 | 1.210 | 1.208 | 0.002 ( +0.1% ) | 7.83 | 7.71 | +1.6% | 1.728 | 1.781 |
| 2500.3 | 2.350 | 2.350 | 0.000 ( +0.0% ) | 5.18 | 5.09 | +1.9% | 1.669 | 1.714 |
| 2500.301 | 2.458 | 2.458 | 0.000 ( +0.0% ) | 4.70 | 4.63 | +1.4% | 1.414 | 1.489 |
| 2500.302 | 2.408 | 2.408 | 0.000 ( +0.0% ) | 4.78 | 4.73 | +1.0% | 1.691 | 1.780 |
| 2500.31 | 2.235 | 2.235 | 0.000 ( +0.0% ) | 8.70 | 8.73 | -0.4% | 1.442 | 1.480 |
| 2500.311 | 2.325 | 2.325 | 0.000 ( +0.0% ) | 8.54 | 8.21 | +4.0% | 1.812 | 1.829 |
| 2500.312 | 2.275 | 2.275 | 0.000 ( +0.0% ) | 8.65 | 8.41 | +2.9% | 1.808 | 1.819 |
| 2500.32 | 1.086 | 1.086 | 0.000 ( +0.0% ) | 8.95 | 8.92 | +0.3% | 1.568 | 1.575 |
| 2500.321 | 1.456 | 1.454 | 0.001 ( +0.1% ) | 6.03 | 5.95 | +1.3% | 1.779 | 1.776 |
| 2500.322 | 1.227 | 1.226 | 0.001 ( +0.1% ) | 7.46 | 7.52 | -0.8% | 1.499 | 1.498 |
| 2500.33 | 1.100 | 1.100 | 0.000 ( +0.0% ) | 20.08 | 20.14 | -0.3% | 1.468 | 1.464 |
| 2500.331 | 1.392 | 1.390 | 0.002 ( +0.1% ) | 14.85 | 14.61 | +1.6% | 1.629 | 1.628 |
| 2500.332 | 1.318 | 1.316 | 0.001 ( +0.1% ) | 16.38 | 16.49 | -0.7% | 1.559 | 1.559 |
| 2500.4 | 2.112 | 2.112 | 0.000 ( +0.0% ) | 9.76 | 9.72 | +0.4% | 1.398 | 1.375 |
| 2500.401 | 2.112 | 2.112 | 0.000 ( +0.0% ) | 9.85 | 9.81 | +0.4% | 1.370 | 1.417 |
| 2500.5 | 0.302 | 0.302 | 0.000 ( +0.0% ) | 50.19 | 49.96 | +0.5% | 1.045 | 1.044 |
| 2500.501 | 0.302 | 0.302 | 0.000 ( +0.0% ) | 50.29 | 50.58 | -0.6% | 1.212 | 1.202 |
| 2500.51 | 1.080 | 1.080 | 0.000 ( +0.0% ) | 27.42 | 28.11 | -2.5% | 1.302 | 1.301 |
| 2500.511 | 1.082 | 1.080 | 0.002 ( +0.2% ) | 28.41 | 28.07 | +1.2% | 1.322 | 1.306 |
| 2500.6 | 1.371 | 1.371 | 0.000 ( +0.0% ) | 23.55 | 23.52 | +0.1% | 1.020 | 1.018 |
| 2500.601 | 1.371 | 1.371 | 0.000 ( +0.0% ) | 23.59 | 23.94 | -1.5% | 1.105 | 1.094 |
+1
Only differences seen in nanoAOD trigger objects for muons and photons.
@mrcthiel please prepare the 12_4_X backport ASAP.
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
