cmssw
cmssw copied to clipboard
cms-sw
[12.4.X] fix compilation errors in MomentumScaleCalibration macros
backport of https://github.com/cms-sw/cmssw/pull/39065
PR description:
This PR fixes a couple of compilation errors preventing the Zµµ alignment validation to run, due to failures in the merge step. The errors spotted are:
Info in <TUnixSystem::ACLiC>: creating shared library /pool/condor/dir_18690/TkAllInOneTool/./CompareBiasZValidation_cc.so
In file included from CompareBiasZValidation_cc_ACLiC_dict dictionary payload:8:
In file included from ././CompareBiasZValidation.cc:9:
In file included from /pool/condor/dir_18690/TkAllInOneTool/FitMassSlices.cc:4:
In file included from /pool/condor/dir_18690/TkAllInOneTool/FitSlices.cc:4:
/pool/condor/dir_18690/TkAllInOneTool/FitXslices.cc:108:48: error: use of overloaded operator '+' is ambiguous (with operand types 'TString' and 'std::__cxx11::basic_stringstream<char, std::char_traits<char>, std::allocator<char> >::__string_type' (aka 'basic_string<char, std::char_traits<char>, std::allocator<char> >'))
TH1* sliceHisto = histo->ProjectionY(name+ss.str(), x, x);
~~~~^~~~~~~~~
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TString.h:49:9: note: candidate function
TString operator+(const TString &s1, const TString &s2);
^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TEveUtil.h:116:15: note: candidate function
TEveException operator+(const TEveException &s1, const std::string &s2);
^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TString.h:51:9: note: candidate function
TString operator+(const char *cs, const TString &s);
^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TEveUtil.h:117:15: note: candidate function
TEveException operator+(const TEveException &s1, const TString &s2);
^
In file included from CompareBiasZValidation_cc_ACLiC_dict dictionary payload:8:
In file included from ././CompareBiasZValidation.cc:9:
In file included from /pool/condor/dir_18690/TkAllInOneTool/FitMassSlices.cc:4:
In file included from /pool/condor/dir_18690/TkAllInOneTool/FitSlices.cc:4:
/pool/condor/dir_18690/TkAllInOneTool/FitXslices.cc:262:50: error: use of overloaded operator '+' is ambiguous (with operand types 'TString' and 'std::__cxx11::basic_stringstream<char, std::char_traits<char>, std::allocator<char> >::__string_type' (aka 'basic_string<char, std::char_traits<char>, std::allocator<char> >'))
TH1* sliceHisto = histo->ProjectionZ(name+ss.str(), x, x, y, y);
~~~~^~~~~~~~~
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TString.h:49:9: note: candidate function
TString operator+(const TString &s1, const TString &s2);
^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TEveUtil.h:116:15: note: candidate function
TEveException operator+(const TEveException &s1, const std::string &s2);
^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TString.h:51:9: note: candidate function
TString operator+(const char *cs, const TString &s);
^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TEveUtil.h:117:15: note: candidate function
TEveException operator+(const TEveException &s1, const TString &s2);
^
In file included from CompareBiasZValidation_cc_ACLiC_dict dictionary payload:8:
In file included from ././CompareBiasZValidation.cc:9:
In file included from /pool/condor/dir_18690/TkAllInOneTool/FitMassSlices.cc:4:
/pool/condor/dir_18690/TkAllInOneTool/FitSlices.cc:115:55: error: use of overloaded operator '+' is ambiguous (with operand types 'TString' and 'std::__cxx11::basic_stringstream<char, std::char_traits<char>, std::allocator<char> >::__string_type' (aka 'basic_string<char, std::char_traits<char>, std::allocator<char> >'))
tempHisto->SetName(TString(tempHisto->GetName())+ss.str());
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TString.h:49:9: note: candidate function
TString operator+(const TString &s1, const TString &s2);
^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TEveUtil.h:116:15: note: candidate function
TEveException operator+(const TEveException &s1, const std::string &s2);
^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TString.h:51:9: note: candidate function
TString operator+(const char *cs, const TString &s);
^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TEveUtil.h:117:15: note: candidate function
TEveException operator+(const TEveException &s1, const TString &s2);
^
Warning in <TInterpreter::TCling::RegisterModule>: Problems declaring payload for module CompareBiasZValidation_cc_ACLiC_dict.
IncrementalExecutor::executeFunction: symbol '_ZStL19__constant_string_pIcEbPKT_' unresolved while linking [cling interface function]!
You are probably missing the definition of bool std::__constant_string_p<char>(char const*)
Maybe you need to load the corresponding shared library?
PR validation:
Run successfully with the fix.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Verbatim backport of https://github.com/cms-sw/cmssw/pull/39065, needed for tracker alignment purposes.
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.
It involves the following packages:
- MuonAnalysis/MomentumScaleCalibration (alca)
@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. @rchatter, @tocheng, @argiro, @bellan, @thomreis, @simonepigazzini, @mmusich this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.
cms-bot commands are listed here
- Backported from #39065
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e52ecf/26834/summary.html
COMMIT: 679d8051305a3bae1d5adc4108325931b2961d20
CMSSW: CMSSW_12_4_X_2022-08-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39068/26834/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 10 differences found in the comparisons
- DQMHistoTests: Total files compared: 50
- DQMHistoTests: Total histograms compared: 3677242
- DQMHistoTests: Total failures: 19
- DQMHistoTests: Total nulls: 1
- DQMHistoTests: Total successes: 3677200
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
- DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
- Checked 208 log files, 45 edm output root files, 50 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
