cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Published 20 hours ago • verified publisher icon cms-sw

Avoid creation of invalid RooFit proxies in RooFitFunction

Open guitargeek opened this issue 2 years ago • 3 comments

PR description:

The RooFitFunction class uses the move constructor of the RooRealProxy class. However, this results in invalid proxy object because the copy and move constructors were never correctly implemented in RooFit. This right alternative is to use a RooListProxy, which this commit suggests to implement.

This makes CMSSW compile again with ROOT master, where the RooRealProxy move constructor was deleted to avoid the creation of invalid RooFit objects.

Addresses https://github.com/root-project/root/issues/11188.

PR validation:

CMSSW compiles.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport intended.

guitargeek avatar Aug 15 '22 15:08 guitargeek

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39066/31571

  • This PR adds an extra 12KB to repository

cmsbuild avatar Aug 15 '22 15:08 cmsbuild

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

  • PhysicsTools/Utilities (analysis)

@cmsbuild can you please review it and eventually sign? Thanks. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Aug 15 '22 15:08 cmsbuild

please test

smuzaffar avatar Aug 15 '22 15:08 smuzaffar

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c883a0/26830/summary.html COMMIT: 3c333be11c4e5da726450dc304345100e4172a14 CMSSW: CMSSW_12_5_X_2022-08-15-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39066/26830/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692476
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3692452
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Aug 15 '22 19:08 cmsbuild

+1

qliphy avatar Aug 16 '22 01:08 qliphy

merge

qliphy avatar Aug 16 '22 01:08 qliphy