cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Published 20 hours ago • verified publisher icon cms-sw

fix compilation errors in `MomentumScaleCalibration` macros

Open mmusich opened this issue 2 years ago • 6 comments

PR description:

This PR fixes a couple of compilation errors preventing the Zµµ alignment validation to run, due to failures in the merge step. The errors spotted are:

Info in <TUnixSystem::ACLiC>: creating shared library /pool/condor/dir_18690/TkAllInOneTool/./CompareBiasZValidation_cc.so
In file included from CompareBiasZValidation_cc_ACLiC_dict dictionary payload:8:
In file included from ././CompareBiasZValidation.cc:9:
In file included from /pool/condor/dir_18690/TkAllInOneTool/FitMassSlices.cc:4:
In file included from /pool/condor/dir_18690/TkAllInOneTool/FitSlices.cc:4:
/pool/condor/dir_18690/TkAllInOneTool/FitXslices.cc:108:48: error: use of overloaded operator '+' is ambiguous (with operand types 'TString' and 'std::__cxx11::basic_stringstream<char, std::char_traits<char>, std::allocator<char> >::__string_type' (aka 'basic_string<char, std::char_traits<char>, std::allocator<char> >'))
      TH1* sliceHisto = histo->ProjectionY(name+ss.str(), x, x);
                                           ~~~~^~~~~~~~~
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TString.h:49:9: note: candidate function
TString operator+(const TString &s1, const TString &s2);
        ^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TEveUtil.h:116:15: note: candidate function
TEveException operator+(const TEveException &s1, const std::string  &s2);
              ^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TString.h:51:9: note: candidate function
TString operator+(const char *cs, const TString &s);
        ^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TEveUtil.h:117:15: note: candidate function
TEveException operator+(const TEveException &s1, const TString &s2);
              ^
In file included from CompareBiasZValidation_cc_ACLiC_dict dictionary payload:8:
In file included from ././CompareBiasZValidation.cc:9:
In file included from /pool/condor/dir_18690/TkAllInOneTool/FitMassSlices.cc:4:
In file included from /pool/condor/dir_18690/TkAllInOneTool/FitSlices.cc:4:
/pool/condor/dir_18690/TkAllInOneTool/FitXslices.cc:262:50: error: use of overloaded operator '+' is ambiguous (with operand types 'TString' and 'std::__cxx11::basic_stringstream<char, std::char_traits<char>, std::allocator<char> >::__string_type' (aka 'basic_string<char, std::char_traits<char>, std::allocator<char> >'))
        TH1* sliceHisto = histo->ProjectionZ(name+ss.str(), x, x, y, y);
                                             ~~~~^~~~~~~~~
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TString.h:49:9: note: candidate function
TString operator+(const TString &s1, const TString &s2);
        ^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TEveUtil.h:116:15: note: candidate function
TEveException operator+(const TEveException &s1, const std::string  &s2);
              ^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TString.h:51:9: note: candidate function
TString operator+(const char *cs, const TString &s);
        ^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TEveUtil.h:117:15: note: candidate function
TEveException operator+(const TEveException &s1, const TString &s2);
              ^
In file included from CompareBiasZValidation_cc_ACLiC_dict dictionary payload:8:
In file included from ././CompareBiasZValidation.cc:9:
In file included from /pool/condor/dir_18690/TkAllInOneTool/FitMassSlices.cc:4:
/pool/condor/dir_18690/TkAllInOneTool/FitSlices.cc:115:55: error: use of overloaded operator '+' is ambiguous (with operand types 'TString' and 'std::__cxx11::basic_stringstream<char, std::char_traits<char>, std::allocator<char> >::__string_type' (aka 'basic_string<char, std::char_traits<char>, std::allocator<char> >'))
      tempHisto->SetName(TString(tempHisto->GetName())+ss.str());
                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TString.h:49:9: note: candidate function
TString operator+(const TString &s1, const TString &s2);
        ^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TEveUtil.h:116:15: note: candidate function
TEveException operator+(const TEveException &s1, const std::string  &s2);
              ^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TString.h:51:9: note: candidate function
TString operator+(const char *cs, const TString &s);
        ^
/cvmfs/cms.cern.ch/slc7_amd64_gcc10/lcg/root/6.24.07-bf41b0420bc269850b74e23486e2953a/include/TEveUtil.h:117:15: note: candidate function
TEveException operator+(const TEveException &s1, const TString &s2);
              ^
Warning in <TInterpreter::TCling::RegisterModule>: Problems declaring payload for module CompareBiasZValidation_cc_ACLiC_dict.
IncrementalExecutor::executeFunction: symbol '_ZStL19__constant_string_pIcEbPKT_' unresolved while linking [cling interface function]!
You are probably missing the definition of bool std::__constant_string_p<char>(char const*)
Maybe you need to load the corresponding shared library?

PR validation:

Run successfully with the fix.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but a backport will be needed.

mmusich avatar Aug 15 '22 15:08 mmusich

type bug-fix, trk

mmusich avatar Aug 15 '22 15:08 mmusich

@consuegs FYI

mmusich avatar Aug 15 '22 15:08 mmusich

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39065/31568

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39065/31568/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39065/31568/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Aug 15 '22 15:08 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39065/31569

  • This PR adds an extra 20KB to repository

cmsbuild avatar Aug 15 '22 15:08 cmsbuild

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • MuonAnalysis/MomentumScaleCalibration (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. @rchatter, @tocheng, @argiro, @bellan, @thomreis, @simonepigazzini, @mmusich this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Aug 15 '22 15:08 cmsbuild

please test

  • though there is really nothing to test

mmusich avatar Aug 15 '22 15:08 mmusich

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a688da/26829/summary.html COMMIT: 67fb57f78ed150bd6ed1c50cac452e0017fa73fc CMSSW: CMSSW_12_5_X_2022-08-15-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39065/26829/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692476
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3692446
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Aug 15 '22 19:08 cmsbuild

+alca

tvami avatar Aug 15 '22 19:08 tvami

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Aug 15 '22 19:08 cmsbuild

+1

qliphy avatar Aug 16 '22 01:08 qliphy