cmssw
cmssw copied to clipboard
cms-sw
Run3-alca226 Update the macros to e used for Run3 analysis of hadron calorimeter calibration data with isolated muons
PR description:
Update the macros to e used for Run3 analysis of HCAL calibration data with isolated muons
PR validation:
Use the macros to analyze Run3 calibration data
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special
-code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39063/31565
- This PR adds an extra 44KB to repository
Code check has found code style and quality issues which could be resolved by applying following patch(s)
-
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39063/31565/code-format.patch
e.g.
curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39063/31565/code-format.patch | patch -p1You can also runscram build code-formatto apply code format directly
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39063/31566
- This PR adds an extra 44KB to repository
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.
It involves the following packages:
- Calibration/HcalCalibAlgos (alca)
@malbouis, @yuanchao, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. @mmusich, @tocheng this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76446b/26826/summary.html
COMMIT: 592b4a940ecd991a4c0ddd8c3965766aafb7b87a
CMSSW: CMSSW_12_5_X_2022-08-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39063/26826/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 4 differences found in the comparisons
- DQMHistoTests: Total files compared: 51
- DQMHistoTests: Total histograms compared: 3692476
- DQMHistoTests: Total failures: 8
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3692446
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
- Checked 212 log files, 49 edm output root files, 51 DQM output files
- TriggerResults: no differences found
@bsunanda I have a couple comments for possible future improvements of the code, they're applying to the whole HcalCalibAlgos.
There is a lot of code which abuses if statement, this can all go into one loop: https://github.com/cms-sw/cmssw/blob/7654b671ce6f103ca900252d8879e1a9858f3f18/Calibration/HcalCalibAlgos/plugins/HOCalibAnalyzer.cc#L682
There is no reason why those kind of variables shouldn't be an array: https://github.com/cms-sw/cmssw/blob/7654b671ce6f103ca900252d8879e1a9858f3f18/Calibration/HcalCalibAlgos/plugins/HOCalibAnalyzer.cc#L410
There's a lot of commented lines which doesn't make sense syntax-wise when uncommented: https://github.com/cms-sw/cmssw/blob/7654b671ce6f103ca900252d8879e1a9858f3f18/Calibration/HcalCalibAlgos/plugins/HOCalibAnalyzer.cc#L1001
Instead of using preprocessor directives you should consider using a flag exposed to the python configuration: https://github.com/cms-sw/cmssw/blob/7654b671ce6f103ca900252d8879e1a9858f3f18/Calibration/HcalCalibAlgos/plugins/HOCalibAnalyzer.cc#L395
There is a lot of memory management issues, for example in this file: https://github.com/cms-sw/cmssw/blob/592b4a940ecd991a4c0ddd8c3965766aafb7b87a/Calibration/HcalCalibAlgos/macros/AnalyzeLepTree.C
maybe it'd be better to use smart pointers instead of manually managing the memory?
Please consider using unordered sets and maps when ordering is not necessary: https://github.com/cms-sw/cmssw/blob/592b4a940ecd991a4c0ddd8c3965766aafb7b87a/Calibration/HcalCalibAlgos/macros/AnalyzeLepTree.C
Initializations could be inlined: https://github.com/cms-sw/cmssw/blob/592b4a940ecd991a4c0ddd8c3965766aafb7b87a/Calibration/HcalCalibAlgos/macros/HBHEMuonHighEta.C#L318
There are comments which are misleading or incorrect: https://github.com/cms-sw/cmssw/blob/592b4a940ecd991a4c0ddd8c3965766aafb7b87a/Calibration/HcalCalibAlgos/macros/HBHEMuonHighEta.C#L547
@ChrisMisan I am squashing this right now. I shall slowly update the other parts as pointed out by you
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39063/31598
- This PR adds an extra 8KB to repository
Pull request #39063 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76446b/26864/summary.html
COMMIT: fb3e72d8b55a378b97f1b5699241cb8b9152ca97
CMSSW: CMSSW_12_5_X_2022-08-16-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39063/26864/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 2 differences found in the comparisons
- DQMHistoTests: Total files compared: 51
- DQMHistoTests: Total histograms compared: 3692500
- DQMHistoTests: Total failures: 8
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3692470
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
- Checked 212 log files, 49 edm output root files, 51 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
