cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

Phase2-hgx320 Try a fix for V17 HGCal geometry to treat orientation index correctly

Open bsunanda opened this issue 3 years ago • 4 comments

PR description:

Try a fix for V17 HGCal geometry to treat orientation index correctly

PR validation:

Use test codes in Geometry/HGcalCommonData/test/python

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

bsunanda avatar Aug 15 '22 12:08 bsunanda

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39062/31563

  • This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39062/31563/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39062/31563/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Aug 15 '22 12:08 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39062/31564

  • This PR adds an extra 28KB to repository

cmsbuild avatar Aug 15 '22 13:08 cmsbuild

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. @trtomei, @beaucero, @fabiocos this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Aug 15 '22 13:08 cmsbuild

@cmsbuild Please test

bsunanda avatar Aug 15 '22 13:08 bsunanda

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0ba346/26825/summary.html COMMIT: 30cfa26b67f15667effed2274fe9104a2ea449d6 CMSSW: CMSSW_12_5_X_2022-08-15-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39062/26825/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692476
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3692452
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Aug 15 '22 17:08 cmsbuild

+1

civanch avatar Aug 15 '22 19:08 civanch

The issue for HGCal V17 geometry was reported in the HGCal DPG meeting. Please see. https://indico.cern.ch/event/1177257/contributions/4950980/attachments/2476127/4249471/Phase2-Talk129.pdf

This PR has cured the issue for V17. Please see the attached picture:

over_l1_v17_2_n

bsunanda avatar Aug 19 '22 11:08 bsunanda

@srimanob Please sign this

bsunanda avatar Aug 21 '22 06:08 bsunanda

+Upgrade

srimanob avatar Aug 21 '22 10:08 srimanob

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Aug 21 '22 10:08 cmsbuild

+1

perrotta avatar Aug 21 '22 14:08 perrotta