cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

A safe guard on GEM DQM harvester

Open quark2 opened this issue 3 years ago • 4 comments

PR description:

There is an issue with too large memory consumption in the GEM DQM harvester procedure (#38976). To fix this issue, additional lines are added to suppress the too high number of chambers. This fix is temporary because the origin of the too large number is still missing. This is why I called it a 'safe guard.'

PR validation:

The code of the run issued in #38976 is run again, and I've checked that the memory usage (RSS) is reduced.

quark2 avatar Aug 15 '22 10:08 quark2

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39060/31562

  • This PR adds an extra 20KB to repository

cmsbuild avatar Aug 15 '22 10:08 cmsbuild

A new Pull Request was created by @quark2 for master.

It involves the following packages:

  • DQM/GEM (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. @watson-ij this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Aug 15 '22 10:08 cmsbuild

@cmsbuild, please test

mmusich avatar Aug 15 '22 10:08 mmusich

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c667a9/26822/summary.html COMMIT: ae083734dbd5c70ed6c372784a8c9b80a607da7e CMSSW: CMSSW_12_5_X_2022-08-15-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39060/26822/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692476
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3692446
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Aug 15 '22 15:08 cmsbuild

urgent

  • backport needed for data-taking

mmusich avatar Aug 15 '22 16:08 mmusich

+1

emanueleusai avatar Aug 16 '22 06:08 emanueleusai

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Aug 16 '22 06:08 cmsbuild

+1

  • Issue https://github.com/cms-sw/cmssw/issues/38976 needs to stay open, to look for the actual bug which is patched here, and fix it

perrotta avatar Aug 16 '22 07:08 perrotta