cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Deleting deprecated scripts access geometry with prior-run2 GT in CondTools/SiPixel

Open yuanchao opened this issue 3 years ago • 7 comments

PR description:

Following up the migration of Geometry_cff to GeometryDB_cff (https://github.com/cms-sw/cmssw/pull/35278), proper GlobalTag needs to be set in advance. We take the chance to clean up AlCa/DB related scripts that accessing with prior-run2 GT in CpmdTools/SiPixel.

PR validation:

Delete deprecated script that can't be tested with modern geometry.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a back port and no back port expected.

yuanchao avatar Aug 09 '22 14:08 yuanchao

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39012/31474

  • This PR adds an extra 16KB to repository

cmsbuild avatar Aug 09 '22 14:08 cmsbuild

A new Pull Request was created by @yuanchao (Yuan CHAO) for master.

It involves the following packages:

  • CondTools/SiPixel (db)

@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. @VinInn, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Aug 09 '22 14:08 cmsbuild

type trk

tvami avatar Aug 09 '22 14:08 tvami

FYI @sanjanasekhar I think these codes are not used, and actually the c++ plugins could be removed too. If you disagree, please provide a working config and make it a unit test

tvami avatar Aug 09 '22 14:08 tvami

hold

mmusich avatar Aug 09 '22 14:08 mmusich

Pull request has been put on hold by @mmusich They need to issue an unhold command to remove the hold state or L1 can unhold it for all

cmsbuild avatar Aug 09 '22 14:08 cmsbuild

to justify the hold, I think the gain reader ones can be salvaged.

mmusich avatar Aug 10 '22 12:08 mmusich

I think the gain reader ones can be salvaged.

@sanjanasekhar will you deal with that?

tvami avatar Aug 24 '22 13:08 tvami

assign trk-dpg

mmusich avatar Aug 25 '22 13:08 mmusich

-1

  • superseded by https://github.com/cms-sw/cmssw/pull/39192

mmusich avatar Aug 25 '22 13:08 mmusich

New categories assigned: trk-dpg

@connorpa,@mmusich,@tsusa you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild avatar Aug 25 '22 13:08 cmsbuild

-db

  • see https://github.com/cms-sw/cmssw/pull/39012#issuecomment-1227239123
  • @yuanchao please close the PR, thanks

tvami avatar Aug 26 '22 00:08 tvami

Closed for #39192

yuanchao avatar Aug 29 '22 10:08 yuanchao