cms-sw
Delete old scripts accessing geometry with prior-run2 GT in CalibMuon/CSCCalibration
PR description:
Following the up the migration of Geometry_cff to GeometryDB_cff (https://github.com/cms-sw/cmssw/pull/35278), proper GlobalTag needs to be set in advance. We take the chance to clean up deprecated AlCa/DB script in CSCCalibration.
PR validation:
Remove deprecated scripts: testNewCalibConstants_global_cfg.py and testNewCalibConstants_global_cfg.py
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a back port and no back port expected.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39011/31473
- This PR adds an extra 16KB to repository
A new Pull Request was created by @yuanchao (Yuan CHAO) for master.
It involves the following packages:
- CalibMuon/CSCCalibration (alca)
@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. @ptcox, @mmusich, @tocheng this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.
cms-bot commands are listed here
FYI @ptcox if you disagree with the cleaning, please provide a working config (and make it a unit test), thanks!
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b0dcd/26726/summary.html
COMMIT: 7f03d4a645d5f842021ec27e2af272a9fa952816
CMSSW: CMSSW_12_5_X_2022-08-09-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39011/26726/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 2 differences found in the comparisons
- DQMHistoTests: Total files compared: 51
- DQMHistoTests: Total histograms compared: 3692476
- DQMHistoTests: Total failures: 7
- DQMHistoTests: Total nulls: 1
- DQMHistoTests: Total successes: 3692446
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
- DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
- Checked 212 log files, 49 edm output root files, 51 DQM output files
- TriggerResults: no differences found
New categories assigned: csc-dpg
@ptcox you have been requested to review this Pull request/Issue and eventually sign? Thanks
I already did comment on this: "I object very strongly to deletion of old scripts for no reason. In what way is it useful to anybody to remove scripts with superseded content? Even a broken config file is useful to somebody in the future arriving with no knowledge of what was done in the past. Isn't that one point of a software repository? It is not as if one can arrive years later, when one need to accomplish whatever the old script used to do, and somehow magically retrieve it from deletion: how would one even know it had ever existed?"
They were used for producing CSCValidation output in simulation and in real data. They do not make sense as a 'unit test'.
However, if you really think it is necessary to delete them I am not going to fight about it. I just don't think it's a good idea. It will likely be somebody else's problem to recreate equivalent configs at some point in the future.
Hi Tim, I didnt (and still dont) see your comment on this earlier. Many subsystems have scripts that really should be deleted. I understand yours is not that case. So let's fix these configs.
They were used for producing CSCValidation output in simulation and in real data.
Is there a version of the script that's still used?
They do not make sense as a 'unit test'.
I dont understand why not? CSCValidation.cc is part of this package, and this config file runs it, i.e. it's testing if CSCValidation.cc still works.
Further questions: can we simply run this on Run-3 data? If yes, do you need a special skim? For MC, what input would make sense? Thanks
unassign csc-dpg
- we spoke to Tim privetly, he said he will just move these files to a twiki as documentation
- i.e. we can move on with the cleaning
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
+1
- No need to relaunch the tests: just two outdated test scripts are removed from the release
+1
- No need to relaunch the tests: just two outdated test scripts are removed from the release
Hi Tamas,
I just do not have the time to invest in this now. Sorry.
Tim
From: Tamas Vami @.*** Sent: 16 August 2022 20:31 To: cms-sw/cmssw Cc: Tim Cox; Mention Subject: Re: [cms-sw/cmssw] Delete old scripts accessing geometry with prior-run2 GT in CalibMuon/CSCCalibration (PR #39011)
Hi Tim, I didnt (and still dont) see your comment on this earlier. Many subsystems have scripts that really should be deleted. I understand yours is not that case. So let's fix these configs.
They were used for producing CSCValidation output in simulation and in real data.
Is there a version of the script that's still used?
They do not make sense as a 'unit test'.
I dont understand why not? CSCValidation.cc is part of this package, and this config file runs it, i.e. it's testing if CSCValidation.cc still works.
Further questions: can we simply run this on Run-3 data? If yes, do you need a special skim? For MC, what input would make sense? Thanks
— Reply to this email directly, view it on GitHubhttps://github.com/cms-sw/cmssw/pull/39011#issuecomment-1217001268, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGYLHQMKHDBA2A72K4LBOTVZPM77ANCNFSM56BA3W3A. You are receiving this because you were mentioned.Message ID: @.***>
I object very strongly to deletion of old scripts for no reason. In what way is it useful to anybody to remove scripts with superseded content? Even a broken config file is useful to somebody in the future arriving with no knowledge of what was done in the past. Isn't that one point of a software repository? It is not as if one can arrive years later, when one need to accomplish whatever the old script used to do, and somehow magically retrieve it from deletion: how would one even know it had ever existed?
And I do not have time to invest in this now.
Tim
Tamas Vami @.***> August 9, 2022 at 16:55
FYI @ptcox https://github.com/ptcox if you disagree with the cleaning, please provide a working config (and make it a unit test), thanks!
— Reply to this email directly, view it on GitHub https://github.com/cms-sw/cmssw/pull/39011#issuecomment-1209490342, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGYLHW74DVK2DWHSCM5AZLVYJWMTANCNFSM56BA3W3A. You are receiving this because you were mentioned.Message ID: @.***>