cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Phase2 duplicate pixels handling

Open jpata opened this issue 3 years ago • 6 comments

In https://github.com/cms-sw/cmssw/pull/37559#issuecomment-1099529597 it was noticed that duplicate pixels are not treated correctly in the Phase2 pixel digitizer. As I understand, their appearance is currently related to the simulation code.

In the longer term (as I suggested above) - certainly longer than the target of this PR (~ urgent for Run3 consistency ), I think the digitizer logic should be changed to avoid duplicate simDigis and just sum them up upstream of any recontruction.

In the meanwhile this can become an open cmssw issue with simulation signature

jpata avatar Aug 09 '22 11:08 jpata

assign simulation

jpata avatar Aug 09 '22 11:08 jpata

New categories assigned: simulation

@mdhildreth,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild avatar Aug 09 '22 11:08 cmsbuild

A new Issue was created by @jpata Joosep Pata.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

cmsbuild avatar Aug 09 '22 11:08 cmsbuild

assign trk-dpg

mmusich avatar Aug 09 '22 13:08 mmusich

@emiglior @suchandradutta FYI

mmusich avatar Aug 09 '22 13:08 mmusich

New categories assigned: trk-dpg

@connorpa,@mmusich,@tsusa you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild avatar Aug 09 '22 13:08 cmsbuild

urgent

  • apparently PR https://github.com/cms-sw/cmssw/pull/37559 has created a serious deterioration of the phase-2 track reconstruction (see https://cms-talk.web.cern.ch/t/new-validation-campaign-12-5-0-pre5-phase2-d88-added/14722/15)

mmusich avatar Sep 15 '22 15:09 mmusich

FYI @cms-sw/l1-l2 How do you use RECO track in L1T campaign? Could you please see the report above on degradation of tracks?

srimanob avatar Sep 16 '22 10:09 srimanob

Hi @mmusich

Thanks for pinging me. Should I assume the issue of tracks will propagate to objects, like electron, muon, jet right? Maybe we need to see how the issue will effect globally also.

srimanob avatar Sep 16 '22 10:09 srimanob