cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

miscellaneous updates to SiPixel Lorentz Angle Calibration harvesting

Open mmusich opened this issue 3 years ago • 29 comments

PR description:

Miscellaneous updates to SiPixel Lorentz Angle Calibration harvesting:

  • introduce a single siPixelLACalibration::cmToum constant and use it everywhere where relevant;
  • address the comment at https://github.com/cms-sw/cmssw/pull/38700#discussion_r930864200
  • provide the code for running the LA fit using Chebyshev polynomials instead of regular ones (currently switched off by default)
  • make the fitting range of the drift vs depth profile configurable;
  • add more fit diagnostic histograms (covariance matrix status and propagated error from the covariance matrix on the drift at half-width).

PR validation:

cmssw compiles, needs more private testing.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Perhaps to be backported to the production release (12.4.X)

mmusich avatar Aug 08 '22 14:08 mmusich

@wweiphy @tsusa FYI

mmusich avatar Aug 08 '22 14:08 mmusich

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38996/31465

  • This PR adds an extra 28KB to repository

cmsbuild avatar Aug 08 '22 14:08 cmsbuild

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CalibTracker/SiPixelLorentzAngle (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. @tocheng, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Aug 08 '22 14:08 cmsbuild

please test

mmusich avatar Aug 08 '22 14:08 mmusich

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23764/26708/summary.html COMMIT: 404b8de0cd41833e7ad0c050a47293a01d341715 CMSSW: CMSSW_12_5_X_2022-08-08-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38996/26708/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3691612
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3691576
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Aug 08 '22 18:08 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38996/31485

  • This PR adds an extra 28KB to repository

cmsbuild avatar Aug 10 '22 14:08 cmsbuild

Pull request #38996 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

cmsbuild avatar Aug 10 '22 14:08 cmsbuild

@cmsbuild , please test

tvami avatar Aug 10 '22 14:08 tvami

-1

Failed Tests: RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23764/26740/summary.html COMMIT: d3d87a84a2f92da1b02d924d96225b0aaa91276f CMSSW: CMSSW_12_5_X_2022-08-10-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38996/26740/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 138.4138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3/step2_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3.log
  • 140.109140.109_RunEGamma2022B+RunEGamma2022B+HLTRUN3+RECONANORUN3+SKIMEGAMMARUN3/step2_RunEGamma2022B+RunEGamma2022B+HLTRUN3+RECONANORUN3+SKIMEGAMMARUN3.log
  • 140.57140.57_RunHI2018Reduced+RunHI2018Reduced+RECOHID18+HARVESTDHI18/step2_RunHI2018Reduced+RunHI2018Reduced+RECOHID18+HARVESTDHI18.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692476
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3692440
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Aug 10 '22 18:08 cmsbuild

I dont see an error....

tvami avatar Aug 10 '22 19:08 tvami

@cmsbuild , please test

  • let's try again

tvami avatar Aug 10 '22 19:08 tvami

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38996/31506

  • This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38996/31506/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38996/31506/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Aug 10 '22 22:08 cmsbuild

type trk, new-feature

mmusich avatar Aug 11 '22 06:08 mmusich

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38996/31509

  • This PR adds an extra 20KB to repository

cmsbuild avatar Aug 11 '22 06:08 cmsbuild

Pull request #38996 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

cmsbuild avatar Aug 11 '22 06:08 cmsbuild

please test

mmusich avatar Aug 11 '22 06:08 mmusich

-1

Failed Tests: RelVals Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23764/26750/summary.html COMMIT: 5dbb520809fd47163167385db3680bd9c16402b0 CMSSW: CMSSW_12_5_X_2022-08-10-2300/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38996/26750/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 1001.01001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5+ALCAHARVD7+ALCAHARVD8/step10_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5+ALCAHARVD7+ALCAHARVD8.log

cmsbuild avatar Aug 11 '22 09:08 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38996/31530

  • This PR adds an extra 20KB to repository

cmsbuild avatar Aug 12 '22 08:08 cmsbuild

Pull request #38996 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

cmsbuild avatar Aug 12 '22 08:08 cmsbuild

@cmsbuild, please test

mmusich avatar Aug 12 '22 08:08 mmusich

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23764/26779/summary.html COMMIT: de1db42dff9868b3914aef30eb476e4a7485dd54 CMSSW: CMSSW_12_5_X_2022-08-11-2300/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38996/26779/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692476
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3692452
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Aug 12 '22 12:08 cmsbuild

@ferencek @wweiphy your feedback / review is also appreciated.

mmusich avatar Aug 12 '22 12:08 mmusich

@mmusich please squash after receiving comments from Wei and Dinko, I'm already good to sign this PR after squashing

tvami avatar Aug 12 '22 18:08 tvami

please squash after receiving comments from Wei and Dinko, I'm already good to sign this PR after squashing

3 commits with pertinent descriptions don't seem eccessive to me. Is now the policy 1 commit per PR?

mmusich avatar Aug 12 '22 18:08 mmusich

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38996/31567

  • This PR adds an extra 20KB to repository

cmsbuild avatar Aug 15 '22 14:08 cmsbuild

Pull request #38996 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

cmsbuild avatar Aug 15 '22 14:08 cmsbuild

@mmusich shall we test this? or something more is coming?

tvami avatar Aug 15 '22 15:08 tvami

or something more is coming?

I am not planning more updates, unless there are more comments.

mmusich avatar Aug 15 '22 15:08 mmusich

@cmsbuild , please test

tvami avatar Aug 15 '22 15:08 tvami

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23764/26828/summary.html COMMIT: 490e6ae7e493e99ddb5a9259f92c65aa0d4120d4 CMSSW: CMSSW_12_5_X_2022-08-15-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38996/26828/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692476
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3692440
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Aug 15 '22 19:08 cmsbuild