cmssw
cmssw copied to clipboard
cms-sw
Replace Geometry_cff with GeometryDB_cff in RecoHI
PR description: Review on the Reco part of https://github.com/cms-sw/cmssw/issues/31113
process.load("Configuration.StandardSequences.Geometry_cff")
was outdated https://github.com/cms-sw/cmssw/pull/8810
It should be replaced with
process.load("Configuration.StandardSequences.GeometryDB_cff")
In this PR, RecoHI configuration 2 files are fixed.
RecoHI/HiEgammaAlgos/test/testSpike_cfg.py
RecoHI/HiJetAlgos/test/testRegionalJetTracking_cfg.py
PR validation:
Tested in CMSSW_12_5_X, the basic test all passed in the CMSSW PR instructions
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38954/31398
- This PR adds an extra 16KB to repository
A new Pull Request was created by @jeongeun (JeongEun Lee) for master.
It involves the following packages:
- RecoHI/HiEgammaAlgos (reconstruction)
- RecoHI/HiJetAlgos (reconstruction)
@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks. @yslai, @jazzitup, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a4111/26618/summary.html
COMMIT: 844f7af4135f050621ed7b173418f4e659c6c812
CMSSW: CMSSW_12_5_X_2022-08-03-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38954/26618/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 6 differences found in the comparisons
- DQMHistoTests: Total files compared: 51
- DQMHistoTests: Total histograms compared: 3691510
- DQMHistoTests: Total failures: 13
- DQMHistoTests: Total nulls: 1
- DQMHistoTests: Total successes: 3691474
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
- DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
- Checked 212 log files, 49 edm output root files, 51 DQM output files
- TriggerResults: no differences found
Yes, I believe these can safely be deleted.
@jeongeun maybe you can update this PR to delete this configs, instead. Thanks!
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38954/31596
- This PR adds an extra 16KB to repository
Pull request #38954 was updated. @jpata, @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a4111/26867/summary.html
COMMIT: e2197889f5e76da3274e2b00235f92bcb233b6f6
CMSSW: CMSSW_12_5_X_2022-08-16-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38954/26867/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 10 differences found in the comparisons
- DQMHistoTests: Total files compared: 51
- DQMHistoTests: Total histograms compared: 3692500
- DQMHistoTests: Total failures: 19
- DQMHistoTests: Total nulls: 1
- DQMHistoTests: Total successes: 3692458
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
- DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
- Checked 212 log files, 49 edm output root files, 51 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
