Update muon shower (HMT) emulator

[kakwok]

PR description:

This PR updates muon shower (HMT) emulator based on the data/emulator comparison study with Run 3 data. Most changes are done in collaboration with TMB developer @tahuang1991 .

Changes for CSC trigger primitive emulator:

• Output a vector of valid HMT bits within TMB readout window
• Remove dead-time selection for anode hits in anode HMT emulation
• Add peak-check option for cathode HMT emulation
• Add dead-time consideration for cathode HMT emulation
• Add configurable matching logic per-station/ring chamber

Changes for CSC Packer/Unpacker:

• Assign BX for anode/cathode and matched HMT during unpacking
• Update corresponding packing

Changes for CSCShowerDigi:

• Add BX property
• Add number of wire/comparator hits
  • Can be filled from emulator or from TMB header

PR validation:

Data/Emulation comparison studies with Run 3 data are presented here: (https://indico.cern.ch/event/1161409/contributions/4965616/attachments/2481743/4260443/HMT_firstLook_L1DPG.pdf)

Unpack-pack-unpack sequence was checked with this config: https://gist.github.com/tahuang1991/3805853ff6c0b340605afe1f461822c8

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38941/31385

• This PR adds an extra 100KB to repository

• Found files with invalid states:

  • DataFormats/CSCDigi/src/classes_def.xml.generated:
    • Added: a5a6c3b12ff3a1ce875efd72286b293c3fbc6424
    • Deleted: af71bd75a4995ce1eed5d248a7aa77db5964696f

[cmsbuild]

A new Pull Request was created by @kakwok for master.

It involves the following packages:

• DataFormats/CSCDigi (simulation)
• EventFilter/CSCRawToDigi (reconstruction)
• L1Trigger/CSCTriggerPrimitives (l1)

@civanch, @epalencia, @clacaputo, @cmsbuild, @rekovic, @mdhildreth, @jpata, @cecilecaillol can you please review it and eventually sign? Thanks. @giovanni-mocellin, @barvic, @rovere, @eyigitba, @valuev, @missirol, @Martin-Grunewald, @ptcox this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

-1

Failed Tests: Build Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7c06f/26610/summary.html COMMIT: af71bd75a4995ce1eed5d248a7aa77db5964696f CMSSW: CMSSW_12_5_X_2022-08-02-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38941/26610/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-08-02-1100/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/GMTCollections.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-08-02-1100/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/GMTSetup.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-08-02-1100/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/GMTTokens.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-08-02-1100/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/GTCollections.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-08-02-1100/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockME.cc: In member function 'virtual bool l1t::stage2::emtf::MEBlockUnpacker::unpack(const l1t::Block&, l1t::UnpackerCollections*)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-08-02-1100/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockME.cc:307:47: error: no matching function for call to 'CSCShowerDigi::CSCShowerDigi(int, int, CSCDetId)'
  307 |                               Hit_.CSC_DetId());
      |                                               ^
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-08-02-1100/src/DataFormats/CSCDigi/interface/CSCShowerDigiCollection.h:5,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-08-02-1100/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFCollections.h:15,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-08-02-1100/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockME.cc:5:

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38941/31422

• This PR adds an extra 72KB to repository

• Found files with invalid states:

  • DataFormats/CSCDigi/src/classes_def.xml.generated:
    • Added: a5a6c3b12ff3a1ce875efd72286b293c3fbc6424
    • Deleted: af71bd75a4995ce1eed5d248a7aa77db5964696f

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38941/31422/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38941/31422/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38941/31423

• This PR adds an extra 76KB to repository

• Found files with invalid states:

  • DataFormats/CSCDigi/src/classes_def.xml.generated:
    • Added: a5a6c3b12ff3a1ce875efd72286b293c3fbc6424
    • Deleted: af71bd75a4995ce1eed5d248a7aa77db5964696f

[cmsbuild]

Pull request #38941 was updated. @civanch, @epalencia, @clacaputo, @cmsbuild, @rekovic, @mdhildreth, @jpata, @cecilecaillol can you please check and sign again.

[kakwok]

@civanch We have fixed the remaining places where CSCShowerDigi is constructed. Can you please start the test again?

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7c06f/26652/summary.html COMMIT: b6a117e394aa98dcf0afa1e60f98d0abf113c2bf CMSSW: CMSSW_12_5_X_2022-08-05-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38941/26652/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3691612
• DQMHistoTests: Total failures: 56
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3691533
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[civanch]

+1

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38941/31466

• This PR adds an extra 292KB to repository

• Found files with invalid states:

  • DataFormats/CSCDigi/src/classes_def.xml.generated:
    • Added: a5a6c3b12ff3a1ce875efd72286b293c3fbc6424
    • Deleted: af71bd75a4995ce1eed5d248a7aa77db5964696f

[cmsbuild]

Pull request #38941 was updated. @civanch, @epalencia, @clacaputo, @cmsbuild, @rekovic, @mdhildreth, @jpata, @cecilecaillol can you please check and sign again.

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7c06f/26719/summary.html COMMIT: 35ff4e1f120b45366ae4db4ecb5112935336eb8d CMSSW: CMSSW_12_5_X_2022-08-08-2300/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38941/26719/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3691612
• DQMHistoTests: Total failures: 39
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3691551
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cecilecaillol]

+l1

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38941/31634

• This PR adds an extra 16KB to repository

• Found files with invalid states:

  • DataFormats/CSCDigi/src/classes_def.xml.generated:
    • Added: a5a6c3b12ff3a1ce875efd72286b293c3fbc6424
    • Deleted: af71bd75a4995ce1eed5d248a7aa77db5964696f

[cmsbuild]

Pull request #38941 was updated. @civanch, @epalencia, @clacaputo, @cmsbuild, @rekovic, @mdhildreth, @jpata, @mandrenguyen, @cecilecaillol can you please check and sign again.

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7c06f/26911/summary.html COMMIT: 5eb66037a3fe46e47876ae64512ddcb10a5cdc49 CMSSW: CMSSW_12_5_X_2022-08-18-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38941/26911/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3693040
• DQMHistoTests: Total failures: 45
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3692973
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cecilecaillol]

+l1

[jpata]

+reconstruction

• on the reco side, there is no impact (I understand it's for emulator studies)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@kakwok please let us know when do you plan to implement the updates that you agreed to apply several days ago already

[kakwok]

Hi @perrotta , I am working on it now. Will finish today

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38941/31853

• This PR adds an extra 332KB to repository

• Found files with invalid states:

  • DataFormats/CSCDigi/src/classes_def.xml.generated:
    • Added: a5a6c3b12ff3a1ce875efd72286b293c3fbc6424
    • Deleted: af71bd75a4995ce1eed5d248a7aa77db5964696f

[cmsbuild]

Pull request #38941 was updated. @civanch, @epalencia, @clacaputo, @cmsbuild, @rekovic, @mdhildreth, @jpata, @mandrenguyen, @cecilecaillol can you please check and sign again.