cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

[106X backport] Add DY option to Embedding HepMC filter

Open IzaakWN opened this issue 2 years ago • 3 comments

PR description

Backport of PR https://github.com/cms-sw/cmssw/pull/38829

PR validation

See PR https://github.com/cms-sw/cmssw/pull/38829 and https://indico.cern.ch/event/1170879/#2-validation-of-exclusive-dy-t

PR backporting

Backporting to CMSSW_10_6_X, beause we would like to reproduce the DYJetsToTauTauToMuTauh_M-50 sample for Run-2 UL MC for TauPOG studies, and allow the H → WW analysis to use this updated filter.

IzaakWN avatar Aug 02 '22 10:08 IzaakWN

A new Pull Request was created by @IzaakWN (Izaak) for CMSSW_10_6_X.

It involves the following packages:

  • GeneratorInterface/Core (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. @alberto-sanchez, @mkirsano this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

  • Backported from #38829

cmsbuild avatar Aug 02 '22 10:08 cmsbuild

please test

SiewYan avatar Aug 02 '22 10:08 SiewYan

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1be0a/26593/summary.html COMMIT: 77092053f690a964d47f1189cb0e3535a00abbcd CMSSW: CMSSW_10_6_X_2022-07-31-0000/slc7_amd64_gcc700 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38936/26593/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215350
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Aug 02 '22 13:08 cmsbuild

Pull request #38936 was updated. @SiewYan, @civanch, @mkirsano, @mdhildreth, @cmsbuild, @alberto-sanchez, @Saptaparna, @menglu21, @GurpreetSinghChahal can you please check and sign again.

cmsbuild avatar Aug 17 '22 09:08 cmsbuild

Pull request #38936 was updated. @SiewYan, @civanch, @mkirsano, @mdhildreth, @cmsbuild, @alberto-sanchez, @Saptaparna, @menglu21, @GurpreetSinghChahal can you please check and sign again.

cmsbuild avatar Aug 17 '22 10:08 cmsbuild

Pull request #38936 was updated. @SiewYan, @civanch, @mkirsano, @mdhildreth, @cmsbuild, @alberto-sanchez, @Saptaparna, @menglu21, @GurpreetSinghChahal can you please check and sign again.

cmsbuild avatar Aug 17 '22 14:08 cmsbuild

please test

perrotta avatar Aug 17 '22 15:08 perrotta

please abort

perrotta avatar Aug 17 '22 15:08 perrotta

test parameters:

  • workflow = 136.9
  • addpkg = TauAnalysis/MCEmbeddingTools

perrotta avatar Aug 17 '22 15:08 perrotta

please test

perrotta avatar Aug 17 '22 15:08 perrotta

backport of https://github.com/cms-sw/cmssw/pull/38829

perrotta avatar Aug 17 '22 15:08 perrotta

(It also backports https://github.com/cms-sw/cmssw/pull/39090, which must be succesfully tested and merged in the master before this one)

perrotta avatar Aug 17 '22 15:08 perrotta

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1be0a/26885/summary.html COMMIT: 2a5907344fb0bed84c28676ba78f09e6fa55146c CMSSW: CMSSW_10_6_X_2022-08-14-0000/slc7_amd64_gcc700 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38936/26885/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215350
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Aug 17 '22 18:08 cmsbuild

+1

civanch avatar Aug 18 '22 07:08 civanch

@cms-sw/generators-l2 Do you have any further comment?

qliphy avatar Aug 22 '22 02:08 qliphy

No further comments. +1

Saptaparna avatar Aug 22 '22 03:08 Saptaparna

+generators see above

qliphy avatar Aug 22 '22 04:08 qliphy

merge

qliphy avatar Aug 22 '22 04:08 qliphy