cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

new Tau discriminator and Jet leg efficiency added

Open vmuralee opened this issue 3 years ago • 9 comments

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Before submitting your pull requests, make sure you followed this checklist:

vmuralee avatar Jul 26 '22 11:07 vmuralee

A new Pull Request was created by @vmuralee for CMSSW_12_4_X.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. @HuguesBrun, @mtosi, @Fedespring, @missirol, @sscruz, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Jul 26 '22 11:07 cmsbuild

@vmuralee Is this a backport PR? If not, please make a forward PR to master (12_5_X).

qliphy avatar Jul 28 '22 01:07 qliphy

please test

emanueleusai avatar Jul 28 '22 03:07 emanueleusai

@vmuralee Is this a backport PR? If not, please make a forward PR to master (12_5_X).

This is the backport PR for 12_4_X , what step I have to follow for the backport

vmuralee avatar Jul 28 '22 06:07 vmuralee

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15875b/26499/summary.html COMMIT: acf7189152620f0dd92805c9be130f94a53b1889 CMSSW: CMSSW_12_4_X_2022-07-27-2300/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38863/26499/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676198
  • DQMHistoTests: Total failures: 861
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3675314
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 38.63 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 6.439 KiB HLT/TAU
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jul 28 '22 07:07 cmsbuild

@vmuralee Is this a backport PR? If not, please make a forward PR to master (12_5_X).

This is the backport PR for 12_4_X , what step I have to follow for the backport

@vmuralee please do exactly what @qliphy wrote, i.e. make an identical PR in the master

perrotta avatar Jul 28 '22 10:07 perrotta

Pull request #38863 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

cmsbuild avatar Aug 03 '22 09:08 cmsbuild

please test

emanueleusai avatar Aug 06 '22 03:08 emanueleusai

-1

Failed Tests: RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15875b/26670/summary.html COMMIT: 13ee9686cc723036f1971a3377f9bbe35fa5a7db CMSSW: CMSSW_12_4_X_2022-08-05-2300/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38863/26670/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 136.7801136.7801_RunHLTPhy2017B_AOD+RunHLTPhy2017B_AOD+DQMHLTonAOD_2017+HARVESTDQMHLTonAOD_2017/step2_RunHLTPhy2017B_AOD+RunHLTPhy2017B_AOD+DQMHLTonAOD_2017+HARVESTDQMHLTonAOD_2017.log
  • 136.7803136.7803_RunHLTPhy2017B_RAWAOD+RunHLTPhy2017B_RAWAOD+DQMHLTonRAWAOD_2017+HARVESTDQMHLTonAOD_2017/step2_RunHLTPhy2017B_RAWAOD+RunHLTPhy2017B_RAWAOD+DQMHLTonRAWAOD_2017+HARVESTDQMHLTonAOD_2017.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677152
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 83
  • DQMHistoTests: Total successes: 3677035
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2322.0410000000006 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 70.633 KiB HLT/TAU
  • DQMHistoSizes: changed ( 11634.0,... ): 369.821 KiB HLT/TAU
  • DQMHistoSizes: changed ( 138.5,... ): 3.550 KiB HLT/TAU
  • DQMHistoSizes: changed ( 139.001 ): 4.231 KiB HLT/TAU
  • DQMHistoSizes: changed ( 4.22 ): 17.601 KiB HLT/TAU
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Aug 06 '22 08:08 cmsbuild

please test

emanueleusai avatar Aug 18 '22 04:08 emanueleusai

-1

Failed Tests: UnitTests RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15875b/26894/summary.html COMMIT: 13ee9686cc723036f1971a3377f9bbe35fa5a7db CMSSW: CMSSW_12_4_X_2022-08-17-2300/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38863/26894/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

RelVals-INPUT

  • 136.7801136.7801_RunHLTPhy2017B_AOD+RunHLTPhy2017B_AOD+DQMHLTonAOD_2017+HARVESTDQMHLTonAOD_2017/step2_RunHLTPhy2017B_AOD+RunHLTPhy2017B_AOD+DQMHLTonAOD_2017+HARVESTDQMHLTonAOD_2017.log
  • 136.7803136.7803_RunHLTPhy2017B_RAWAOD+RunHLTPhy2017B_RAWAOD+DQMHLTonRAWAOD_2017+HARVESTDQMHLTonAOD_2017/step2_RunHLTPhy2017B_RAWAOD+RunHLTPhy2017B_RAWAOD+DQMHLTonRAWAOD_2017+HARVESTDQMHLTonAOD_2017.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677242
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 83
  • DQMHistoTests: Total successes: 3677125
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2322.0410000000006 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 70.633 KiB HLT/TAU
  • DQMHistoSizes: changed ( 11634.0,... ): 369.821 KiB HLT/TAU
  • DQMHistoSizes: changed ( 138.5,... ): 3.550 KiB HLT/TAU
  • DQMHistoSizes: changed ( 139.001 ): 4.231 KiB HLT/TAU
  • DQMHistoSizes: changed ( 4.22 ): 17.601 KiB HLT/TAU
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Aug 18 '22 08:08 cmsbuild

some unit test fail with the following error (likely related to your PR) ----- Begin Fatal Exception 06-Aug-2022 06:37:10 CEST----------------------- An exception of category 'ProductNotFound' occurred while [0] Processing Event run: 297557 lumi: 123 event: 197153873 stream: 0 [1] Running path 'dqmoffline_step' [2] Calling method for module HLTTauRefProducer/'TauRefProducer' Exception Message: Principal::getByToken: Found zero products matching all criteria Looking for type: edm::ValueMapreco::SingleTauDiscriminatorContainer Looking for module label: hpsPFTauDiscriminationByMuonRejection3 Looking for productInstanceName:

Additional Info: [a] If you wish to continue processing events after a ProductNotFound exception, add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

see log: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15875b/26670/runTheMatrixINPUT-results/136.7803_RunHLTPhy2017B_RAWAOD+RunHLTPhy2017B_RAWAOD+DQMHLTonRAWAOD_2017+HARVESTDQMHLTonAOD_2017/step2_RunHLTPhy2017B_RAWAOD+RunHLTPhy2017B_RAWAOD+DQMHLTonRAWAOD_2017+HARVESTDQMHLTonAOD_2017.log

@vmuralee could you please look into it?

emanueleusai avatar Aug 23 '22 19:08 emanueleusai

Pull request #38863 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

cmsbuild avatar Aug 24 '22 09:08 cmsbuild

please test

emanueleusai avatar Aug 25 '22 05:08 emanueleusai

-1

Failed Tests: RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15875b/27072/summary.html COMMIT: 7677930593ae9bd8ca2407af109b466bdd8dcb53 CMSSW: CMSSW_12_4_X_2022-08-24-2300/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38863/27072/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 136.7801136.7801_RunHLTPhy2017B_AOD+RunHLTPhy2017B_AOD+DQMHLTonAOD_2017+HARVESTDQMHLTonAOD_2017/step2_RunHLTPhy2017B_AOD+RunHLTPhy2017B_AOD+DQMHLTonAOD_2017+HARVESTDQMHLTonAOD_2017.log
  • 136.7803136.7803_RunHLTPhy2017B_RAWAOD+RunHLTPhy2017B_RAWAOD+DQMHLTonRAWAOD_2017+HARVESTDQMHLTonAOD_2017/step2_RunHLTPhy2017B_RAWAOD+RunHLTPhy2017B_RAWAOD+DQMHLTonRAWAOD_2017+HARVESTDQMHLTonAOD_2017.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677242
  • DQMHistoTests: Total failures: 312
  • DQMHistoTests: Total nulls: 84
  • DQMHistoTests: Total successes: 3676824
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2322.0450000000005 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 70.633 KiB HLT/TAU
  • DQMHistoSizes: changed ( 11634.0,... ): 369.821 KiB HLT/TAU
  • DQMHistoSizes: changed ( 138.5,... ): 3.550 KiB HLT/TAU
  • DQMHistoSizes: changed ( 139.001 ): 4.231 KiB HLT/TAU
  • DQMHistoSizes: changed ( 4.22 ): 17.601 KiB HLT/TAU
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Aug 25 '22 09:08 cmsbuild

@vmuralee there's a lot of messages like this in the logs (probably related to your code changes): %MSG-w HLTTauDQMOffline: HLTTauDQMOfflineSource:hltTauOfflineMonitor_Inclusive 25-Aug-2022 07:53:20 CEST Run: 160960 Event: 10001698 HLTTauDQML1Plotter::analyze: unable to read L1 met collection caloStage2Digis:EtSum %MSG

See: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15875b/27072/runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

Also there are failures in runthematrix

emanueleusai avatar Aug 29 '22 18:08 emanueleusai

@vmuralee what are the plans for this PR?

emanueleusai avatar Sep 20 '22 21:09 emanueleusai

-1

  • stale PR

emanueleusai avatar Oct 11 '22 04:10 emanueleusai

The integration will continue with the PR #39651. Closing this PR.

vmuralee avatar Oct 11 '22 07:10 vmuralee