cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

L1T DQM: Adding the uGT timing sequence back and updating the relevant algo list

Open vukasinmilosevic opened this issue 3 years ago • 11 comments

L1T DQM update:

  • Putting the uGT timing sequence back into the workflow
  • Updating relevant triggers to match the Run 3 menu (L1Menu_Collisions2022_v1_0_1)

vukasinmilosevic avatar Jul 23 '22 13:07 vukasinmilosevic

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38840/31228

  • This PR adds an extra 16KB to repository

cmsbuild avatar Jul 23 '22 13:07 cmsbuild

A new Pull Request was created by @vukasinmilosevic (Vukasin Milosevic) for master.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Jul 23 '22 13:07 cmsbuild

please test

qliphy avatar Jul 25 '22 00:07 qliphy

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-afe092/26426/summary.html COMMIT: 365f3759191634d2f8b5848d565fb59960d599ff CMSSW: CMSSW_12_5_X_2022-07-24-2300/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38840/26426/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 18 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3667670
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3667634
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2932.0660000000003 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 145.340 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 10824.0,... ): 147.637 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 1306.0,... ): 143.535 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 140.56 ): 146.160 KiB L1T/L1TStage2uGT
  • Checked 210 log files, 47 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jul 25 '22 05:07 cmsbuild

type l1t

emanueleusai avatar Jul 28 '22 03:07 emanueleusai

+1

emanueleusai avatar Jul 28 '22 03:07 emanueleusai

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Jul 28 '22 03:07 cmsbuild

This PR is adding quite several warning lines in the logs of several workflows, for example wf1306.0:

%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_FirstCollisionInTrain" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_LastCollisionInTrain" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleMu22_BMTF" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleMu22_OMTF" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleMu22_EMTF" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleIsoEG28er1p5" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleIsoEG32er2p5" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleEG40er2p5" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleEG60" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleTau120er2p1" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_ETMHF130" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_HTT360er" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_ETT2000" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_FirstCollisionInTrain" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_LastCollisionInTrain" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleMu0_BMTF" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleMu0_OMTF" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleMu0_EMTF" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleEG10er2p5" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleEG15er2p5" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleEG26er2p5" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleLooseIsoEG28er1p5" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleJet60er2p5" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleJet60_FWD3p0" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_ETMHF100" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_HTT120er" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_ETT1200" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG

Please add the new modules only when needed/available, e.g. by using relevant modifiers

perrotta avatar Jul 28 '22 05:07 perrotta

By the way, even the baseline shows for the same wf the following warning messages

%MSG
%MSG-w L1TObjectsTiming:  L1TObjectsTiming:l1tObjectsTiming@streamBeginRun  25-Jul-2022 03:32:54 CEST Run: 1 Stream: 0
Algo "L1_FirstCollisionInTrain" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TObjectsTiming:  L1TObjectsTiming:l1tObjectsTiming@streamBeginRun  25-Jul-2022 03:32:54 CEST Run: 1 Stream: 0
Algo "L1_LastCollisionInTrain" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG

I imagine there are other modules in that sequence that should also get protected behind relevant modifiers

perrotta avatar Jul 28 '22 05:07 perrotta

ping @vukasinmilosevic

qliphy avatar Aug 09 '22 01:08 qliphy

Hi @qliphy, @perrotta, apologies for the delay in response. Ok, this seems like it is complaining due to the L1 menu for 2016 lacking the triggers used in 17/18 and Run 3.

I can add the protections, but could you please point me to the instructions on how to do so (apologies if this is a basic question)?

vukasinmilosevic avatar Aug 09 '22 20:08 vukasinmilosevic

Hi @qliphy, @perrotta, apologies for the delay in response. Ok, this seems like it is complaining due to the L1 menu for 2016 lacking the triggers used in 17/18 and Run 3.

I can add the protections, but could you please point me to the instructions on how to do so (apologies if this is a basic question)?

You can configure for the different data taking periods using the corresponding eras, see e..g. https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideCmsDriverEras

perrotta avatar Aug 16 '22 04:08 perrotta

@vukasinmilosevic is there any news for the expected updates to this PR?

perrotta avatar Aug 22 '22 14:08 perrotta

Hi @perrotta, I'm working on it, will update asap!

vukasinmilosevic avatar Aug 22 '22 15:08 vukasinmilosevic

Hello @perrotta, I tried following what was explained in the link you posted as well as using: https://github.com/cms-sw/cmssw/blob/CMSSW_12_5_X_2022-08-24-1100/DQM/L1TMonitorClient/python/L1TStage2EmulatorMonitorClient_cff.py#L70 as an additional example.

Can you please check if this is the correct way to do this? I only want to enable this module for Run 3 processes (the trigger paths are updated with Run 3 menu and in the tests I don't see any "paths missing" type of warnings).

vukasinmilosevic avatar Aug 24 '22 18:08 vukasinmilosevic

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38840/31776

  • This PR adds an extra 16KB to repository

cmsbuild avatar Aug 24 '22 18:08 cmsbuild

Pull request #38840 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

cmsbuild avatar Aug 24 '22 18:08 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38840/31794

  • This PR adds an extra 16KB to repository

cmsbuild avatar Aug 25 '22 11:08 cmsbuild

Pull request #38840 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

cmsbuild avatar Aug 25 '22 11:08 cmsbuild

please test

perrotta avatar Aug 25 '22 11:08 perrotta

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-afe092/27088/summary.html COMMIT: 6b13b2c9dd6f5000aa25cf159ae9388f77b766c9 CMSSW: CMSSW_12_5_X_2022-08-25-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38840/27088/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3693084
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3693060
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1476.3699999999997 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 147.637 KiB L1T/L1TStage2uGT
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Aug 25 '22 15:08 cmsbuild

+1

emanueleusai avatar Aug 29 '22 18:08 emanueleusai

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Aug 29 '22 18:08 cmsbuild

+1

perrotta avatar Aug 29 '22 19:08 perrotta