cmssw
cmssw copied to clipboard
cms-sw
Replace Geometry_cff with GeometryDB_cff in RecoBTag/RecoBTau
PR description: Review on the Reco part of https://github.com/cms-sw/cmssw/issues/31113
process.load("Configuration.StandardSequences.Geometry_cff")
was outdated https://github.com/cms-sw/cmssw/pull/8810
It should be replaced with
process.load("Configuration.StandardSequences.GeometryDB_cff")
In this PR, RecoBTag (RecoBTau) configuration files 1 file (2 files) are fixed.
modified: RecoBTag/SoftLepton/test/testMuonAssociator.py
modified: RecoBTau/JetTagComputer/test/testGenericMVAJetTagComputer_cfg.py
modified: RecoBTau/JetTagComputer/test/testJetTagProducer_cfg.py
PR validation:
Tested in CMSSW_12_5_X, the basic test all passed in the CMSSW PR instructions
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38787/31140
- This PR adds an extra 12KB to repository
A new Pull Request was created by @jeongeun (JeongEun Lee) for master.
It involves the following packages:
- RecoBTag/SoftLepton (reconstruction)
- RecoBTau/JetTagComputer (reconstruction)
@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks. @JyothsnaKomaragiri, @emilbols, @demuller, @andrzejnovak, @AlexDeMoor this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-040269/26338/summary.html
COMMIT: 11f5ab1d88316113f94dcc5d22eb3f06b75b6c68
CMSSW: CMSSW_12_5_X_2022-07-19-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38787/26338/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 6 differences found in the comparisons
- DQMHistoTests: Total files compared: 50
- DQMHistoTests: Total histograms compared: 3662417
- DQMHistoTests: Total failures: 14
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3662381
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
- Checked 208 log files, 45 edm output root files, 50 DQM output files
- TriggerResults: no differences found
Dear @cms-sw/tau-pog-l2 , it seems to me the config files fixed by this PR aren't updated since a long time (some of them form 2013). Do you know if we still need it, maybe used in some unit-test, or we can remove them? Thanks
Hi, this package is not used by the tau-POG (anymore ?), contains "tau" for historical reasons. BTV should probably confirm what should be done.
Hi, this package is not used by the tau-POG (anymore ?), contains "tau" for historical reasons. BTV should probably confirm what should be done.
@cms-sw/btv-pog-l2 could you please confirm whether these test files are still needed?
@cms-sw/btv-pog-l2 could you please confirm whether these test files are still needed?
a kind ping to @cms-sw/btv-pog-l2
@emilbols, @demuller, @andrzejnovak, @AlexDeMoor can you comment on the tests from the BTV side ?
kind ping BTV folks @emilbols, @demuller, @andrzejnovak, @AlexDeMoor @cms-sw/btv-pog-l2
After reviewing this code, it appears to be old code unrelated to what we do or use now. We no longer use them and agree with their removal.
After reviewing this code, it appears to be old code unrelated to what we do or use now. We no longer use them and agree with their removal.
Hi @AlexDeMoor , thanks for the update. @jeongeun , could you please remove the files?
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38787/32153
- This PR adds an extra 12KB to repository
Pull request #38787 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-040269/27647/summary.html
COMMIT: 94c75f00cb62fb008bdbe492e4dcc6183342f7e3
CMSSW: CMSSW_12_6_X_2022-09-18-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38787/27647/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 1 differences found in the comparisons
- DQMHistoTests: Total files compared: 51
- DQMHistoTests: Total histograms compared: 3621956
- DQMHistoTests: Total failures: 5
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3621929
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
- Checked 212 log files, 49 edm output root files, 51 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
