Replace Geometry_cff with GeometryDB_cff in RecoEcal

[jeongeun]

PR description: Review on the Reco part of https://github.com/cms-sw/cmssw/issues/31113

process.load("Configuration.StandardSequences.Geometry_cff") was outdated https://github.com/cms-sw/cmssw/pull/8810 It should be replaced with process.load("Configuration.StandardSequences.GeometryDB_cff")

In this PR, RecoEcal configuration files (2 files) are fixed.

modified:   RecoEcal/EgammaClusterProducers/test/testRecoEcal_cfg.py
modified:   RecoEcal/EgammaClusterProducers/test/testRecoEcal_cfgV2.py

PR validation:

Tested in CMSSW_12_5_X, the basic test all passed in the CMSSW PR instructions

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38786/31139

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

• RecoEcal/EgammaClusterProducers (reconstruction)

@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks. @Sam-Harper, @lecriste, @rchatter, @jainshilpi, @valsdav, @rovere, @lgray, @sobhatta, @thomreis, @afiqaize, @simonepigazzini, @wrtabb, @argiro, @varuns23, @ram1123 this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[clacaputo]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e67db/26327/summary.html COMMIT: 060508573053a90b5bc8312d099872adf71471f4 CMSSW: CMSSW_12_5_X_2022-07-19-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38786/26327/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3662417
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3662387
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[clacaputo]

Dear @cms-sw/ecal-dpg-l2 , it seems to me the config files fixed by this PR aren't updated since CMSSW_3_X_Y cycle. Do you know if we still need it, maybe used in some unit-test, or we can remove them? Thanks

[clacaputo]

Dear @cms-sw/ecal-dpg-l2 , it seems to me the config files fixed by this PR aren't updated since CMSSW_3_X_Y cycle. Do you know if we still need it, maybe used in some unit-test, or we can remove them? Thanks

A kind ping to @cms-sw/ecal-dpg-l2 , please, if you can have a look. Thanks

[clacaputo]

Hi @thomreis, could you please have a look at these cfgs and check with ecal people whether they are still needed? Thanks

[thomreis]

Hi @clacaputo these test config files are not needed anymore as far as I can tell and can be removed.

[clacaputo]

Hi @clacaputo these test config files are not needed anymore as far as I can tell and can be removed.

Thanks, @thomreis . @jeongeun , could you please take care of it?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38786/31597

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #38786 was updated. @jpata, @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

[jpata]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e67db/26865/summary.html COMMIT: 0a249e8139ea43523f04a7f57ee0c86ba64d7f74 CMSSW: CMSSW_12_5_X_2022-08-16-2300/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38786/26865/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3692500
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3692470
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• delete outdated files

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1