cmssw
cmssw copied to clipboard
cms-sw
Replace Geometry_cff with GeometryDB_cff in RecoJets
PR description: Review on the Reco part of https://github.com/cms-sw/cmssw/issues/31113
process.load("Configuration.StandardSequences.Geometry_cff")
was outdated https://github.com/cms-sw/cmssw/pull/8810
It should be replaced with
process.load("Configuration.StandardSequences.GeometryDB_cff")
In this PR, RecoJets configuration files (4 files) are fixed.
modified: RecoJets/JetAnalyzers/test/JetIdExample.py
modified: RecoJets/JetAssociationProducers/test/pileupJetAnalysis_cfg.py
modified: RecoJets/JetAssociationProducers/test/test_extrapolation_cff.py
modified: RecoJets/JetProducers/test/runSubjetFilter_cfg.py
PR validation:
Tested in CMSSW_12_5_X, the basic test all passed in the CMSSW PR instructions
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38784/31134
- This PR adds an extra 16KB to repository
A new Pull Request was created by @jeongeun (JeongEun Lee) for master.
It involves the following packages:
- RecoJets/JetAnalyzers (reconstruction)
- RecoJets/JetAssociationProducers (reconstruction)
- RecoJets/JetProducers (reconstruction)
@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks. @AlexDeMoor, @rappoccio, @jdolen, @yslai, @emilbols, @jdamgov, @ahinzmann, @nhanvtran, @JyothsnaKomaragiri, @gkasieczka, @clelange, @schoef, @andrzejnovak, @demuller, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aeabb4/26328/summary.html
COMMIT: 4ccfff336e17b3a28fa163e0b39b2e53fd9c1d9c
CMSSW: CMSSW_12_5_X_2022-07-19-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38784/26328/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 2 differences found in the comparisons
- DQMHistoTests: Total files compared: 50
- DQMHistoTests: Total histograms compared: 3662417
- DQMHistoTests: Total failures: 8
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3662387
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
- Checked 208 log files, 45 edm output root files, 50 DQM output files
- TriggerResults: no differences found
sorry it was for @cms-sw/jetmet-pog-l2 (Lauren is on double duty and I got confused).
@joosep Thanks for the ping! From what I can see I think for sure RecoJets/JetAnalyzers/test/JetIdExample.py is not in use since it loads processors that were removed in PR https://github.com/cms-sw/cmssw/pull/19406. Likely we can remove it or should at least update it. Waiting for feedback on the other files.
@joosep Thanks for the ping! From what I can see I think for sure RecoJets/JetAnalyzers/test/JetIdExample.py is not in use since it loads processors that were removed in PR #19406. Likely we can remove it or should at least update it. Waiting for feedback on the other files.
Hi @laurenhay , any update on the other files? Thanks
Hey @clacaputo sorry for the delay I think the consensus is they can go. I asked the current JME conveners (a couple times) and there were no complaints at deleting or requests to keep them. Also asked @rappoccio and he said they can go.
Hey @clacaputo sorry for the delay I think the consensus is they can go. I asked the current JME conveners (a couple times) and there were no complaints at deleting or requests to keep them. Also asked @rappoccio and he said they can go.
Thanks for checking. @jeongeun could you please remove them?
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38784/32740
- This PR adds an extra 16KB to repository
Pull request #38784 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38784/32744
- This PR adds an extra 20KB to repository
Pull request #38784 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aeabb4/28513/summary.html
COMMIT: 2c1adce7b965c03a2c5c4f2e9ece44c1c504c570
CMSSW: CMSSW_12_6_X_2022-10-25-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38784/28513/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
There are some workflows for which there are errors in the baseline: 20834.911 step 3 4.6 step 3 The results for the comparisons for these workflows could be incomplete This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request
Summary:
- No significant changes to the logs found
- Reco comparison results: 15 differences found in the comparisons
- Reco comparison had 6 failed jobs
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3384029
- DQMHistoTests: Total failures: 99
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3383908
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 201 log files, 48 edm output root files, 48 DQM output files
- TriggerResults: no differences found
There are some differences in JetMET folder of DMQ bin-by-bin comparison for wf 20900 [1] (and also other wfs) that shouldn't be there given the PR's nature. Any idea @cms-sw/jetmet-pog-l2 ?
[1] https://tinyurl.com/2c82kenn
There are some differences in JetMET folder of DMQ bin-by-bin comparison for wf
20900[1] (and also other wfs) that shouldn't be there given the PR's nature. Any idea @cms-sw/jetmet-pog-l2 ?[1] https://tinyurl.com/2c82kenn
Update: it seems to be a widespread issue
+reconstruction
- technical PR: removing some unused code
- changes observed are not related to the PR
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
