Tracker Traits and Enabling Phase2 for Inner Tracker Reconstruction

[AdrianoDee]

This PR proposes the addition of a TrackerTraits template parameter for all the modules and the datastructres used for pixel tracks reconstruciton. This trait holds all the methods and constants needed to define the pixel tracker topology. Being a template, this would allow to define different datastructure sizes, selection algorithms, fitting features for the whole chain at compile time. In this way one could keep disentangled the different conditions and reconstuction targets (HLT, offline, HIon, Run3, Phase2 ...).

With the implementation of such a structure this PR allows to run on GPU (and CPU) the whole Phase2 Inner Tracker reconstruction (from DIGI to pixel Tracks). A following PR will allow this also for offline pixel seeding and offline HIon pixel track reconstruction.

Find below some comments to the code to (I hope) better navigate it, the validation for run3 pixel tracks w.r.t. to 12_5_X as it is and the performance for Phase2 IT reconstruction. Few open points are still to be addressed but I would leave them documented in an issue and to be assessed in following PRs.

• [ ] better tuning for Phase2 layer pairs selection: high impact on timing;
• [ ] better tuning for Phase2 High Purity selection;
• [ ] extending the TrackerTraits logic to few RawToDigi methods (such as clusterChargeCut, calibDigisPhase2 ...);
• [x] address CPUvsGPU discrepancies for Phase2;
• [ ] add validation scripts for Phase2 IT reco (local reco and pixel track reco);
• [x] tuning pixel vertex reconstruction (n.b. in the TDR the legacy one was used);
• [x] update Riemann fit also (needed? not actually used in production);
• [ ] updating DQM modules such as SiPixelPhase1CompareTrackSoA to be runnable also for Phase2.

This PR also answers the comments that were left on https://github.com/cms-sw/cmssw/pull/36235 and corrects the pixel digis calibration on gpu (in gpuCalibPixel.h) to reproduce what is in PixelThresholdClusterizer.cc. This implies changes in the constants to be used moved to

 constexpr float ElectronPerADCGain = 1500;
 constexpr uint16_t Phase2DigiBaseline = 1000;

and in Phase2KinkADC usage in the calibration. See the original algorithm (in PixelThresholdClusterizer) and the parameter sets used (in phase2TrackerDigitizer_cfi and SiPixelClusterizer_cfi)

Code comments

"Backward" compatibility

This has been solved by https://github.com/cms-sw/cmssw/pull/38806.

Partial specialization

This has been simplified during the review.

CA params: selections and cuts

In order to have possibly different cuts and selections in cell, tuple and track building and selecting the Params struct used in CAHitNtupletGeneratorKernels has been split in

• AlgoParams that are those that are common to all topologies and act mostly on the configuration of the algorithm itself;

and some specific to the topology:

• CellCutsT that includes the cuts (parameters and methods) to be applied at doublets buidling level. Note that at the moment this are the same for all the topology but having them separated would allow it to be changed in future.
• CAParamsT that include the cuts (parameters and methods) and the ntuplet levels.
• QualityCutsT that acts on the track selection and that was already there. It has been moved to TrackSoAHeterogeneousT header (that seems more natural) and now the struct itself holds the methods to apply the cuts on the tracks.

This (splitting and moving the cuts to be methods of the structs) whould allow to define specific cuts for specific topologies. In order to allow partial specialization and keep common implementation for topologies derived from a base topology, these are wrapped in a topologyCuts struct.

SimplePixelTopology

Now the SimplePixelTopology holds all the constants that are neede for the pixel tracks reconstruction (so the formerly CAConstants, the gpuPixelDoublets and the former SimplePixelTopology itself) moving the definitions from namespaces to structs in order to use them as template parameters.

Note that some "helper" namespace have been kept following the discussion here (PR discussion).

The

template <typename T>
using isPhase1Topology = typename std::enable_if<std::is_base_of<Phase1,T>::value>::type;

template <typename T>
using isPhase2Topology = typename std::enable_if<std::is_base_of<Phase2,T>::value>::type;

have been defined keeping in mind that we may have modifications to Phase1 and Phase2 topologies (e.g. for HIon in Run3). Thus by defining new TrackerTraits struts that inherits from Phase1 and Phase2 and togheter with the isPhase1Topology and the isPhase2Topology one could:

• define a new topology with minimal code duplication;
• use the same specialized templates (for cuts and selections mainly) without having to add a new one for the modified topology.

This is achieved, e.g., the template for ParamsT as

 template <typename TrackerTraits, typename Enable = void>
   struct ParamsT : public AlgoParams

and then specialize it for all the topologies based on Phase1 as

template <typename TrackerTraits>
   struct ParamsT<TrackerTraits, isPhase1Topology<TrackerTraits>> : public AlgoParams

Rolling fits

In HelixFitOnGPU.h the helper

template <auto Start, auto End, auto Inc, class F>  //a compile-time bounded for loop
   constexpr void rolling_fits(F &&f) {
     if constexpr (Start < End) {
       f(std::integral_constant<decltype(Start), Start>());
       rolling_fits<Start + Inc, End, Inc>(f);
     }
   }

is defined to have a "constexpr" for loop useful to avoid code duplication when running the track fits. In this way, with the help of a lambda function the fits may be unrolled as:

       riemannFit::rolling_fits<4, TrackerTraits::maxHitsOnTrackForFullFit, 1>(
           [this, &hv, &tkidGPU, &hitsGPU, &hits_geGPU, &fast_fit_resultsGPU, &offset](auto i) {
             kernel_BLFastFit<i, TrackerTraits>(tuples_,
                                                tupleMultiplicity_,
                                                hv,
                                                tkidGPU.get(),
                                                hitsGPU.get(),
                                                hits_geGPU.get(),
                                                fast_fit_resultsGPU.get(),
                                                i,
                                                i,
                                                offset);

             kernel_BLFit<i, TrackerTraits>(tupleMultiplicity_,
                                            bField_,
                                            outputSoa_,
                                            tkidGPU.get(),
                                            hitsGPU.get(),
                                            hits_geGPU.get(),
                                            fast_fit_resultsGPU.get());
           });

With maxHitsOnTrackForFullFit a new constant defined to limit the number of hits used in the fit.

---

Phase2

Physics validation

Quadruplets:

• CPU vs CPU

Triplets:

• CPU vs CPU

---

Run3

Physics validation

Quadruplets:

• CPU
• GPU

Triplets:

• CPU
• GPU

Throughput

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

Evaluated on fu-c2a02-37-02 T4@P5 via patatrack-scripts.

There's a gain of 7-9%

Dependency graphs

GPU dependency graph

CPU dependency graph

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31086

• This PR adds an extra 412KB to repository

• Found files with invalid states:

  • CUDADataFormats/Track/src/TrackSoAHeterogeneousT.cc:
    • Added: f7cb34ae900a0b7278ddf454d2e4013604ce7d5c
    • Deleted: 9d188ac8f4874957dcfa15312e7d67d3adffd9af

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CUDADataFormats/Common/interface/HeterogeneousSoA.h modified in PR(s): #37952
  • File CUDADataFormats/SiPixelDigi/interface/SiPixelDigisCUDASOAView.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/TrackSoAHeterogeneousT.h modified in PR(s): #37952
  • File CUDADataFormats/Track/src/classes_def.xml modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DReduced.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DSOAView.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/src/TrackingRecHit2DHeterogeneous.cc modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/test/TrackingRecHit2DCUDA_t.cpp modified in PR(s): #37952
  • File DQM/SiPixelPhase1Heterogeneous/plugins/SiPixelPhase1MonitorTrackSoA.cc modified in PR(s): #38758
  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterChargeCut.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClustering.h modified in PR(s): #37359, #35713
  • File RecoLocalTracker/SiPixelClusterizer/test/gpuClustering_t.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelRecHits/plugins/PixelRecHitGPUKernel.cu modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromLegacy.cc modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/BrokenLineFitOnGPU.cu modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cu modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.h modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsAlloc.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsImpl.h modified in PR(s): #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorOnGPU.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelVertexFinding/plugins/gpuVertexFinder.cc modified in PR(s): #37952

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31086/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31086/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31088

• This PR adds an extra 288KB to repository

• Found files with invalid states:

  • CUDADataFormats/Track/src/TrackSoAHeterogeneousT.cc:
    • Added: f7cb34ae900a0b7278ddf454d2e4013604ce7d5c
    • Deleted: 9d188ac8f4874957dcfa15312e7d67d3adffd9af

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CUDADataFormats/Common/interface/HeterogeneousSoA.h modified in PR(s): #37952
  • File CUDADataFormats/SiPixelDigi/interface/SiPixelDigisCUDASOAView.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/TrackSoAHeterogeneousT.h modified in PR(s): #37952
  • File CUDADataFormats/Track/src/classes_def.xml modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DReduced.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DSOAView.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/src/TrackingRecHit2DHeterogeneous.cc modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/test/TrackingRecHit2DCUDA_t.cpp modified in PR(s): #37952
  • File DQM/SiPixelPhase1Heterogeneous/plugins/SiPixelPhase1MonitorTrackSoA.cc modified in PR(s): #38758
  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterChargeCut.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClustering.h modified in PR(s): #37359, #35713
  • File RecoLocalTracker/SiPixelClusterizer/test/gpuClustering_t.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelRecHits/plugins/PixelRecHitGPUKernel.cu modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromLegacy.cc modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/BrokenLineFitOnGPU.cu modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cu modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.h modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsAlloc.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsImpl.h modified in PR(s): #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorOnGPU.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelVertexFinding/plugins/gpuVertexFinder.cc modified in PR(s): #37952

[cmsbuild]

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

• CUDADataFormats/Common (heterogeneous)
• CUDADataFormats/SiPixelDigi (heterogeneous, reconstruction)
• CUDADataFormats/Track (heterogeneous, reconstruction)
• CUDADataFormats/TrackingRecHit (heterogeneous, reconstruction)
• DQM/SiPixelPhase1Heterogeneous (dqm)
• Geometry/CommonTopologies (geometry)
• Geometry/TrackerGeometryBuilder (geometry)
• HLTrigger/Configuration (hlt)
• RecoLocalTracker/SiPixelClusterizer (reconstruction)
• RecoLocalTracker/SiPixelRecHits (reconstruction)
• RecoPixelVertexing/PixelTrackFitting (reconstruction)
• RecoPixelVertexing/PixelTriplets (reconstruction)
• RecoPixelVertexing/PixelVertexFinding (reconstruction)
• RecoTauTag/HLTProducers (hlt)
• RecoTracker/TkSeedGenerator (reconstruction)

@Martin-Grunewald, @civanch, @Dr15Jones, @bsunanda, @makortel, @clacaputo, @emanueleusai, @ianna, @mdhildreth, @cmsbuild, @missirol, @jfernan2, @ahmad3213, @fwyzard, @jpata, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. @felicepantaleo, @Martin-Grunewald, @bsunanda, @OzAmram, @fioriNTU, @mbluj, @threus, @mmusich, @venturia, @hdelanno, @silviodonato, @JanFSchulte, @dgulhan, @missirol, @azotz, @ferencek, @GiacomoSguazzoni, @rovere, @VinInn, @jandrea, @idebruyn, @ebrondol, @mtosi, @fabiocos, @dkotlins, @gpetruc, @tvami this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[makortel]

When trying to run on Run3 RAW files on which the new HLT step has been run (from 12_3_X on). Having tried the usual class versioning instructions (and the CMS_CLASS_VERSION tool) and being unsuccessful I've found a workaround to:

1. avoid making useless all the samples already produced for Run3 since the HLT integration;
2. avoid adding an explicit drop for pixel tracks productes in the RECO step, that seems unreasonable to me;

I've linked here the errors I refer to that happens if I simply redefine the class with the new TrackerTraits.

This is a bit strange since all CUDADataFormats should be transient. Ok, there was a period of time when some of them were not and this was causing issues.

[AdrianoDee]

This is a bit strange since all CUDADataFormats should be transient. Ok, there was a period of time when some of them were not and this was causing issues.

This is odd also to me. I've set up a basic test (simply changing maxNumber() in TrackSoAHeterogeneousT) that outputs the same error as above (full log here):

scram p -n dev CMSSW_12_5_0_pre2 
cd dev/src/ 
cmsenv 
git cms-init 
git cms-merge-topic AdrianoDee:cudaformats_failures 
scram b -j 16 
cmsDriver.py step3 -s RAW2DIGI:RawToDigi_pixelOnly,RECO:reconstruction_pixelTrackingOnly,VALIDATION:@pixelTrackingOnlyValidation,DQM:@pixelTrackingOnlyDQM --conditions auto:phase1_2022_realistic --datatier GEN-SIM-RECO,DQMIO -n 10 --eventcontent RECOSIM,DQM --geometry DB:Extended --era Run3 --procModifiers pixelNtupletFit,gpu --filein /store/relval/CMSSW_12_5_0_pre2/RelValTTbar_14TeV/GEN-SIM-DIGI-RAW/PU_124X_mcRun3_2022_realistic_v3-v1/2580000/148e5f22-ea2b-4dfb-b64f-79e50be63665.root --no_exec --python_filename=step3.py 
cmsRun step3.py

this happening with or without CMS_CLASS_VERSION. At the same time something like runTheMatrix.py -l 11634.502 -w upgrade -j 8 runs smoothly and this points to a problem in reading from already produced samples.

[AdrianoDee]

type tracking

[AdrianoDee]

test parameters:

• enable_tests = gpu
• workflows_gpu = 11634.502, 39434.502, 39634.502, 11634.506, 39434.506, 39634.506
• workflows = 11634.501, 39434.501, 39434.501, 11634.502, 39434.502, 39634.502, 11634.505, 39434.505, 39634.505,11634.506, 39434.506, 39634.506
• relvals_opt= -w standard,highstats,pileup,generator,extendedgen,production,upgrade,cleanedupgrade,ged

[AdrianoDee]

please test

[cmsbuild]

-1

Failed Tests: RelVals Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0dd2fc/26300/summary.html COMMIT: 636a79c21c35605c0ab31fa430e8b397892d245b CMSSW: CMSSW_12_5_X_2022-07-17-2300/el8_amd64_gcc10 Additional Tests: GPU User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38761/26300/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 39500.039500.0_CloseByPGun_CE_H_Coarse_Scint+2026D88+CE_H_Coarse_Scint_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal/step3_CloseByPGun_CE_H_Coarse_Scint+2026D88+CE_H_Coarse_Scint_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal.log
• 39496.039496.0_CloseByPGun_CE_E_Front_120um+2026D88+CE_E_Front_120um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal/step3_CloseByPGun_CE_E_Front_120um+2026D88+CE_E_Front_120um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal.log
• 23234.023234.0_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step3_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log

Expand to see more relval errors ...

• 28234.0
• 35034.0
• 39434.0
• 39434.75
• 39634.999

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19876
• DQMHistoTests: Total failures: 1919
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 17957
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: found differences in 3 / 3 workflows

[fwyzard]

I'm only about 10% through, but I have a general comment: renaming

class SomeClass

to

template <typename TrackerTraits>
class SomeClassT

is not a requirement.

It is useful in some cases (for example if SomeClass also exists), but here it seems to only make the code slightly less readable.

@makortel @VinInn what is your preference ? Should we keep e.g.

template <typename Traits, typename TrackerTraits>
class TrackingRecHit2DHeterogeneous {

or rename it to

template <typename Traits, typename TrackerTraits>
class TrackingRecHit2DHeterogeneousT {

?

[mmusich]

type trk

[makortel]

It is useful in some cases (for example if SomeClass also exists), but here it seems to only make the code slightly less readable.

@makortel @VinInn what is your preference ? Should we keep e.g.

template <typename Traits, typename TrackerTraits>
class TrackingRecHit2DHeterogeneous {

or rename it to

template <typename Traits, typename TrackerTraits>
class TrackingRecHit2DHeterogeneousT {

?

In general my take would be to stay with TrackingRecHit2DHeterogeneous, but for this particular case the dictionary for the type TrackingRecHit2DHeterogeneous<cms::cudacompat::CPUTraits> is (very likely) needed for now in order to read products that have this product as part of their parentage from existing input file (what @AdrianoDee wrote in the description and in the issue #38781). I'm trying to see if I can remove this requirement for the dictionary.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31174

• This PR adds an extra 320KB to repository

• Found files with invalid states:

  • CUDADataFormats/Track/src/TrackSoAHeterogeneousT.cc:
    • Added: f7cb34ae900a0b7278ddf454d2e4013604ce7d5c
    • Deleted: 9d188ac8f4874957dcfa15312e7d67d3adffd9af

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CUDADataFormats/Common/interface/HeterogeneousSoA.h modified in PR(s): #37952
  • File CUDADataFormats/SiPixelDigi/interface/SiPixelDigisCUDASOAView.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/TrackSoAHeterogeneousT.h modified in PR(s): #37952
  • File CUDADataFormats/Track/src/classes_def.xml modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DReduced.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DSOAView.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/src/TrackingRecHit2DHeterogeneous.cc modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/test/TrackingRecHit2DCUDA_t.cpp modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterChargeCut.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClustering.h modified in PR(s): #37359, #35713
  • File RecoLocalTracker/SiPixelClusterizer/test/gpuClustering_t.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelRecHits/plugins/PixelRecHitGPUKernel.cu modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromLegacy.cc modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/BrokenLineFitOnGPU.cu modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cu modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.h modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsAlloc.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsImpl.h modified in PR(s): #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorOnGPU.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelVertexFinding/plugins/gpuVertexFinder.cc modified in PR(s): #37952

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31174/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31174/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

[AdrianoDee]

I'm only about 10% through, but I have a general comment: renaming

class SomeClass

to

template <typename TrackerTraits>
class SomeClassT

is not a requirement.

I've moved all the modules/plugins from SomethingT back to the Something syntax. I've left it for the CUDADataFormats (for the issues above) and for the various structs just to allow to have, e.g., it defined as

template<typename TrackerTraits>
struct ParamsT;

and then, to avoid bringing the <TrackerTraits> all around, aliased in the modules as

template<typename TrackerTraits>
class SomeModule{

using Params = ParamsT<TrackerTraits>;
using CellNeighbors = caStructures::CellNeighborsT<TrackerTraits>;
...

that, going back to CellNeighbors or Params, would imply using new names everywhere, that is doable but I don't know how much desirable. If there's a nicer syntax for this I'm open to suggestions.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31175

• This PR adds an extra 328KB to repository

• Found files with invalid states:

  • CUDADataFormats/Track/src/TrackSoAHeterogeneousT.cc:
    • Added: f7cb34ae900a0b7278ddf454d2e4013604ce7d5c
    • Deleted: 9d188ac8f4874957dcfa15312e7d67d3adffd9af

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CUDADataFormats/Common/interface/HeterogeneousSoA.h modified in PR(s): #37952
  • File CUDADataFormats/SiPixelDigi/interface/SiPixelDigisCUDASOAView.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/TrackSoAHeterogeneousT.h modified in PR(s): #37952
  • File CUDADataFormats/Track/src/classes_def.xml modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DReduced.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DSOAView.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/src/TrackingRecHit2DHeterogeneous.cc modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/test/TrackingRecHit2DCUDA_t.cpp modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterChargeCut.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClustering.h modified in PR(s): #37359, #35713
  • File RecoLocalTracker/SiPixelClusterizer/test/gpuClustering_t.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelRecHits/plugins/PixelRecHitGPUKernel.cu modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromLegacy.cc modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/BrokenLineFitOnGPU.cu modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cu modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.h modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsAlloc.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsImpl.h modified in PR(s): #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorOnGPU.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelVertexFinding/plugins/gpuVertexFinder.cc modified in PR(s): #37952

[cmsbuild]

Pull request #38761 was updated. @Martin-Grunewald, @civanch, @Dr15Jones, @bsunanda, @makortel, @clacaputo, @emanueleusai, @ianna, @mdhildreth, @cmsbuild, @missirol, @jfernan2, @ahmad3213, @fwyzard, @jpata, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31176

• This PR adds an extra 216KB to repository

• Found files with invalid states:

  • CUDADataFormats/Track/src/TrackSoAHeterogeneousT.cc:
    • Added: f7cb34ae900a0b7278ddf454d2e4013604ce7d5c
    • Deleted: 9d188ac8f4874957dcfa15312e7d67d3adffd9af

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CUDADataFormats/Common/interface/HeterogeneousSoA.h modified in PR(s): #37952
  • File CUDADataFormats/SiPixelDigi/interface/SiPixelDigisCUDASOAView.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/TrackSoAHeterogeneousT.h modified in PR(s): #37952
  • File CUDADataFormats/Track/src/classes_def.xml modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DReduced.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DSOAView.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/src/TrackingRecHit2DHeterogeneous.cc modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/test/TrackingRecHit2DCUDA_t.cpp modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterChargeCut.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClustering.h modified in PR(s): #37359, #35713
  • File RecoLocalTracker/SiPixelClusterizer/test/gpuClustering_t.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelRecHits/plugins/PixelRecHitGPUKernel.cu modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromLegacy.cc modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/BrokenLineFitOnGPU.cu modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cu modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.h modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsAlloc.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsImpl.h modified in PR(s): #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorOnGPU.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelVertexFinding/plugins/gpuVertexFinder.cc modified in PR(s): #37952

[cmsbuild]

Pull request #38761 was updated. @Martin-Grunewald, @civanch, @Dr15Jones, @bsunanda, @makortel, @clacaputo, @emanueleusai, @ianna, @mdhildreth, @cmsbuild, @missirol, @jfernan2, @ahmad3213, @fwyzard, @jpata, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[AdrianoDee]

please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31178

• This PR adds an extra 400KB to repository

• Found files with invalid states:

  • CUDADataFormats/Track/src/TrackSoAHeterogeneousT.cc:
    • Added: f7cb34ae900a0b7278ddf454d2e4013604ce7d5c
    • Deleted: 9d188ac8f4874957dcfa15312e7d67d3adffd9af

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CUDADataFormats/Common/interface/HeterogeneousSoA.h modified in PR(s): #37952
  • File CUDADataFormats/SiPixelDigi/interface/SiPixelDigisCUDASOAView.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/TrackSoAHeterogeneousT.h modified in PR(s): #37952
  • File CUDADataFormats/Track/src/classes_def.xml modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DReduced.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DSOAView.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/src/TrackingRecHit2DHeterogeneous.cc modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/test/TrackingRecHit2DCUDA_t.cpp modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterChargeCut.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClustering.h modified in PR(s): #37359, #35713
  • File RecoLocalTracker/SiPixelClusterizer/test/gpuClustering_t.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelRecHits/plugins/PixelRecHitGPUKernel.cu modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromLegacy.cc modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/BrokenLineFitOnGPU.cu modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cu modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.h modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsAlloc.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsImpl.h modified in PR(s): #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorOnGPU.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelVertexFinding/plugins/gpuVertexFinder.cc modified in PR(s): #37952

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31178/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31178/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31184

• This PR adds an extra 136KB to repository

• Found files with invalid states:

  • CUDADataFormats/Track/src/TrackSoAHeterogeneousT.cc:
    • Added: f7cb34ae900a0b7278ddf454d2e4013604ce7d5c
    • Deleted: 9d188ac8f4874957dcfa15312e7d67d3adffd9af

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CUDADataFormats/Common/interface/HeterogeneousSoA.h modified in PR(s): #37952
  • File CUDADataFormats/SiPixelDigi/interface/SiPixelDigisCUDASOAView.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/TrackSoAHeterogeneousT.h modified in PR(s): #37952
  • File CUDADataFormats/Track/src/classes_def.xml modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DReduced.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DSOAView.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/src/TrackingRecHit2DHeterogeneous.cc modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/test/TrackingRecHit2DCUDA_t.cpp modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterChargeCut.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClustering.h modified in PR(s): #37359, #35713
  • File RecoLocalTracker/SiPixelClusterizer/test/gpuClustering_t.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelRecHits/plugins/PixelRecHitGPUKernel.cu modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromLegacy.cc modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/BrokenLineFitOnGPU.cu modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cu modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.h modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsAlloc.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsImpl.h modified in PR(s): #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorOnGPU.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelVertexFinding/plugins/gpuVertexFinder.cc modified in PR(s): #37952

[cmsbuild]

Pull request #38761 was updated. @Martin-Grunewald, @civanch, @Dr15Jones, @bsunanda, @makortel, @clacaputo, @emanueleusai, @ianna, @mdhildreth, @cmsbuild, @missirol, @jfernan2, @ahmad3213, @fwyzard, @jpata, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[AdrianoDee]

please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-GPU RelVals-INPUT AddOn Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0dd2fc/26369/summary.html COMMIT: 72285a95c31a5dd5ab649ebbe76faa87e2d1b6dd CMSSW: CMSSW_12_5_X_2022-07-21-1100/el8_amd64_gcc10 Additional Tests: GPU User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38761/26369/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 139.001

----- Begin Fatal Exception 21-Jul-2022 15:33:38 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin PixelCPEFastESProducer
Exception Message:
unable to load /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38761/26369/CMSSW_12_5_X_2022-07-21-1100/lib/el8_amd64_gcc10/poisoned/plugin-poisoned-RecoLocalTrackerSiPixelRecHitsPlugins.so because /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38761/26369/CMSSW_12_5_X_2022-07-21-1100/lib/el8_amd64_gcc10/poisoned/plugin-poisoned-RecoLocalTrackerSiPixelRecHitsPlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

• 11634.0

----- Begin Fatal Exception 21-Jul-2022 15:46:28 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin PixelCPEFastESProducer
Exception Message:
unable to load /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38761/26369/CMSSW_12_5_X_2022-07-21-1100/lib/el8_amd64_gcc10/poisoned/plugin-poisoned-RecoLocalTrackerSiPixelRecHitsPlugins.so because /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38761/26369/CMSSW_12_5_X_2022-07-21-1100/lib/el8_amd64_gcc10/poisoned/plugin-poisoned-RecoLocalTrackerSiPixelRecHitsPlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

• 11634.7

----- Begin Fatal Exception 21-Jul-2022 15:46:28 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin PixelCPEFastESProducer
Exception Message:
unable to load /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38761/26369/CMSSW_12_5_X_2022-07-21-1100/lib/el8_amd64_gcc10/poisoned/plugin-poisoned-RecoLocalTrackerSiPixelRecHitsPlugins.so because /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38761/26369/CMSSW_12_5_X_2022-07-21-1100/lib/el8_amd64_gcc10/poisoned/plugin-poisoned-RecoLocalTrackerSiPixelRecHitsPlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 11634.911
• 11634.914
• 11834.0
• 12434.0

RelVals-GPU

• 11634.50611634.506_TTbar_14TeV+2021_Patatrack_PixelOnlyTripletsGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano/step2_TTbar_14TeV+2021_Patatrack_PixelOnlyTripletsGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano.log
• 11634.51211634.512_TTbar_14TeV+2021_Patatrack_ECALOnlyGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano/step2_TTbar_14TeV+2021_Patatrack_ECALOnlyGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano.log
• 11634.52211634.522_TTbar_14TeV+2021_Patatrack_HCALOnlyGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano/step2_TTbar_14TeV+2021_Patatrack_HCALOnlyGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano.log

RelVals-INPUT

• 139.001139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB/step2_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB.log
• 139.002139.002_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB/step2_RunZeroBias2021+RunZeroBias2021+HLTDR3_2021+RECODR3_ZBOffline+HARVESTD2021ZB.log
• 139.003139.003_RunHLTPhy2021+RunHLTPhy2021+HLTDR3_2021+RECODR3_HLTPhysics_Offline+HARVESTD2021HLTPhy/step2_RunHLTPhy2021+RunHLTPhy2021+HLTDR3_2021+RECODR3_HLTPhysics_Offline+HARVESTD2021HLTPhy.log

Expand to see more relval errors ...

• 139.004
• 140.001
• 140.002
• 158.1
• 158.2
• 158.3
• 11601.0
• 11602.0
• 11604.0
• 11603.0
• 11607.0
• 11605.0
• 11606.0
• 11608.0
• 11630.0
• 11609.0
• 11634.0
• 11634.24
• 11634.1
• 11634.5
• 11634.501
• 11634.505
• 11634.511
• 11634.521
• 11634.7
• 11634.71
• 11634.72
• 11634.91
• 11643.0
• 11640.0
• 11646.0
• 11650.0
• 11650.501
• 11650.505
• 11723.17
• 11725.0
• 11834.0
• 11834.24
• 11834.21
• 11834.19
• 11834.13
• 11846.0
• 12034.0
• 12434.0
• 11846.19
• 11925.0
• 12634.0
• 12834.0
• 13034.0

AddOn Tests

• hlt_mc_GRun

----- Begin Fatal Exception 21-Jul-2022 15:34:40 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin PixelCPEFastESProducer
Exception Message:
unable to load /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38761/26369/CMSSW_12_5_X_2022-07-21-1100/lib/el8_amd64_gcc10/poisoned/plugin-poisoned-RecoLocalTrackerSiPixelRecHitsPlugins.so because /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38761/26369/CMSSW_12_5_X_2022-07-21-1100/lib/el8_amd64_gcc10/poisoned/plugin-poisoned-RecoLocalTrackerSiPixelRecHitsPlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

• hlt_mc_GRun

----- Begin Fatal Exception 21-Jul-2022 15:35:58 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin PixelTrackSoAFromCUDA
Exception Message:
unable to load /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38761/26369/CMSSW_12_5_X_2022-07-21-1100/lib/el8_amd64_gcc10/poisoned/plugin-poisoned-RecoPixelVertexingPixelTrackFittingPlugins.so because /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38761/26369/CMSSW_12_5_X_2022-07-21-1100/lib/el8_amd64_gcc10/poisoned/plugin-poisoned-RecoPixelVertexingPixelTrackFittingPlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

• hlt_mc_HIon

----- Begin Fatal Exception 21-Jul-2022 15:34:39 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin PixelCPEFastESProducer
Exception Message:
unable to load /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38761/26369/CMSSW_12_5_X_2022-07-21-1100/lib/el8_amd64_gcc10/poisoned/plugin-poisoned-RecoLocalTrackerSiPixelRecHitsPlugins.so because /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38761/26369/CMSSW_12_5_X_2022-07-21-1100/lib/el8_amd64_gcc10/poisoned/plugin-poisoned-RecoLocalTrackerSiPixelRecHitsPlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

• hlt_mc_PIon
• hlt_mc_PRef
• hlt_mc_PRef
• hlt_data_GRun
• hlt_data_GRun
• hlt_data_HIon
• hlt_data_PIon
• hlt_data_PRef
• hlt_data_PRef

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31203

• This PR adds an extra 404KB to repository

• Found files with invalid states:

  • CUDADataFormats/Track/src/TrackSoAHeterogeneousT.cc:
    • Added: f7cb34ae900a0b7278ddf454d2e4013604ce7d5c
    • Deleted: 9d188ac8f4874957dcfa15312e7d67d3adffd9af

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CUDADataFormats/Common/interface/HeterogeneousSoA.h modified in PR(s): #37952
  • File CUDADataFormats/SiPixelDigi/interface/SiPixelDigisCUDASOAView.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/TrackSoAHeterogeneousT.h modified in PR(s): #37952
  • File CUDADataFormats/Track/src/classes_def.xml modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DReduced.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DSOAView.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/src/TrackingRecHit2DHeterogeneous.cc modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/test/TrackingRecHit2DCUDA_t.cpp modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterChargeCut.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClustering.h modified in PR(s): #37359, #35713
  • File RecoLocalTracker/SiPixelClusterizer/test/gpuClustering_t.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelRecHits/plugins/PixelRecHitGPUKernel.cu modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromLegacy.cc modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/BrokenLineFitOnGPU.cu modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cu modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.h modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsAlloc.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsImpl.h modified in PR(s): #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorOnGPU.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelVertexFinding/plugins/gpuVertexFinder.cc modified in PR(s): #37952

[cmsbuild]

Pull request #38761 was updated. @Martin-Grunewald, @civanch, @Dr15Jones, @bsunanda, @makortel, @clacaputo, @emanueleusai, @ianna, @mdhildreth, @cmsbuild, @missirol, @jfernan2, @ahmad3213, @fwyzard, @jpata, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[AdrianoDee]

I've moved all the modules/plugins from SomethingT back to the Something syntax. I've left it for the CUDADataFormats (for the issues above) and for the various structs just to allow to have, e.g., it defined as

template<typename TrackerTraits>
struct ParamsT;

and then, to avoid bringing the <TrackerTraits> all around, aliased in the modules as

template<typename TrackerTraits>
class SomeModule{

using Params = ParamsT<TrackerTraits>;
using CellNeighbors = caStructures::CellNeighborsT<TrackerTraits>;
...

that, going back to CellNeighbors or Params, would imply using new names everywhere, that is doable but I don't know how much desirable. If there's a nicer syntax for this I'm open to suggestions.

@fwyzard @makortel (tagging since this comment above may have been hidden by subsequent commits and bot comments)

The only possible drawback of going back to the SomeClass syntax is that for each plugin I would need to have

using ModulePhase1 = Module<pixelTopology::Phase1>;
DEFINE_FWK_MODULE(MyModulePhase1);
using ModulePhase2 = Module<pixelTopology::Phase2>;
DEFINE_FWK_MODULE(MyModulePhase2);

That means changing all the module names (that I had missed in the customizeHLTForCMSSW customizer). I've changed all the module names like that (adding *Phase1). I haven't still applied the same change to the fillDescriptions just to understand what's your opinion on that. For the moment they still produce myModule_cfi.py for Phase1 and myModulePhase2_cfi.py for Phase2. In case we want to go for adding *Phase1 I would modify also those.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31214

• This PR adds an extra 360KB to repository

• Found files with invalid states:

  • CUDADataFormats/Track/src/TrackSoAHeterogeneousT.cc:
    • Added: f7cb34ae900a0b7278ddf454d2e4013604ce7d5c
    • Deleted: 9d188ac8f4874957dcfa15312e7d67d3adffd9af

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CUDADataFormats/Common/interface/HeterogeneousSoA.h modified in PR(s): #37952
  • File CUDADataFormats/SiPixelDigi/interface/SiPixelDigisCUDASOAView.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/TrackSoAHeterogeneousT.h modified in PR(s): #37952
  • File CUDADataFormats/Track/src/classes_def.xml modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DReduced.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DSOAView.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/src/TrackingRecHit2DHeterogeneous.cc modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/test/TrackingRecHit2DCUDA_t.cpp modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterChargeCut.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClustering.h modified in PR(s): #37359, #35713
  • File RecoLocalTracker/SiPixelClusterizer/test/gpuClustering_t.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelRecHits/plugins/PixelRecHitGPUKernel.cu modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromLegacy.cc modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/BrokenLineFitOnGPU.cu modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cu modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.h modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsAlloc.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsImpl.h modified in PR(s): #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorOnGPU.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelVertexFinding/plugins/gpuVertexFinder.cc modified in PR(s): #37952

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31214/code-checks.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31214/code-checks.patch | patch -p1 You can also run scram build code-checks to apply code checks directly

• code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31214/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31214/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31224

• This PR adds an extra 20KB to repository

• Found files with invalid states:

  • CUDADataFormats/Track/src/TrackSoAHeterogeneousT.cc:
    • Added: f7cb34ae900a0b7278ddf454d2e4013604ce7d5c
    • Deleted: 9d188ac8f4874957dcfa15312e7d67d3adffd9af

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CUDADataFormats/Common/interface/HeterogeneousSoA.h modified in PR(s): #37952
  • File CUDADataFormats/SiPixelDigi/interface/SiPixelDigisCUDASOAView.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/TrackSoAHeterogeneousT.h modified in PR(s): #37952
  • File CUDADataFormats/Track/src/classes_def.xml modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DReduced.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DSOAView.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/src/TrackingRecHit2DHeterogeneous.cc modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/test/TrackingRecHit2DCUDA_t.cpp modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterChargeCut.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClustering.h modified in PR(s): #37359, #35713
  • File RecoLocalTracker/SiPixelClusterizer/test/gpuClustering_t.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelRecHits/plugins/PixelRecHitGPUKernel.cu modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromLegacy.cc modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/BrokenLineFitOnGPU.cu modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cu modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.h modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsAlloc.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsImpl.h modified in PR(s): #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorOnGPU.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelVertexFinding/plugins/gpuVertexFinder.cc modified in PR(s): #37952

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31224/code-checks.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31224/code-checks.patch | patch -p1 You can also run scram build code-checks to apply code checks directly

• code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31224/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31224/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38761/31226

• This PR adds an extra 20KB to repository

• Found files with invalid states:

  • CUDADataFormats/Track/src/TrackSoAHeterogeneousT.cc:
    • Added: f7cb34ae900a0b7278ddf454d2e4013604ce7d5c
    • Deleted: 9d188ac8f4874957dcfa15312e7d67d3adffd9af

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CUDADataFormats/Common/interface/HeterogeneousSoA.h modified in PR(s): #37952
  • File CUDADataFormats/SiPixelDigi/interface/SiPixelDigisCUDASOAView.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/PixelTrackHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/Track/interface/TrackSoAHeterogeneousT.h modified in PR(s): #37952
  • File CUDADataFormats/Track/src/classes_def.xml modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DHeterogeneous.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DReduced.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/interface/TrackingRecHit2DSOAView.h modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/src/TrackingRecHit2DHeterogeneous.cc modified in PR(s): #37952
  • File CUDADataFormats/TrackingRecHit/test/TrackingRecHit2DCUDA_t.cpp modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterChargeCut.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClustering.h modified in PR(s): #37359, #35713
  • File RecoLocalTracker/SiPixelClusterizer/test/gpuClustering_t.h modified in PR(s): #37359
  • File RecoLocalTracker/SiPixelRecHits/plugins/PixelRecHitGPUKernel.cu modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromLegacy.cc modified in PR(s): #37952, #35713
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackSoAFromCUDA.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/BrokenLineFitOnGPU.cu modified in PR(s): #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.cu modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernels.h modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsAlloc.cc modified in PR(s): #37952, #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsImpl.h modified in PR(s): #35713
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorOnGPU.cc modified in PR(s): #37952
  • File RecoPixelVertexing/PixelVertexFinding/plugins/gpuVertexFinder.cc modified in PR(s): #37952