cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

Update BeamSpot in Run3 MC GTs + swap `Run3RoundOptics25ns13TeVLowSigmaZ` with `Realistic25ns13p6TeVEarly2022Collision` vtx smearing

Open mmusich opened this issue 3 years ago • 87 comments

PR description:

PR #38692 changed the default Beam Spot in the Run-3 Global Tag , but it was thn now out-of-synch with the vertex smearing assumed for the Run-3 RelVal workflows, even if it is correct for the 2022 physics MC. This PR fixes the problem by making Realistic25ns13p6TeVEarly2022Collision the default for Run-3 relval workflows and wherever it is necessary to change it in standalone configurations together with the BeamSpot updates in the Run-3 MC GlobalTags. In this PR we add:

  • the new BeamSpot for Run 3 collisions at 13.6 TeV in all Run3 MC GTs
    • Compatible with the VtxSmearing parameters Realistic25ns13p6TeVEarly2022Collision introduced in https://github.com/cms-sw/cmssw/pull/38616 and fixed at https://github.com/cms-sw/cmssw/pull/38825 (after using wrong pixel barycenter positions, as described in this CMS Talk Post
    • The new reco BeamSpot was derived from the RelVal produced in JIRA-PDMVRELVALS-156

The new BeamSpot tags are:

  • BeamSpotObjects_Realistic25ns_13p6TeVCollisions_Early2022_v3_mc
  • BeamSpotOnlineObjects_Realistic25ns_13p6TeVCollisions_Early2022_v2_mc

The GT diffs are:

  • MC Run3 realistic https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/125X_mcRun3_2022_realistic_v2/125X_mcRun3_2022_realistic_v3
  • MC Run3 cosmics realistic https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/125X_mcRun3_2022cosmics_realistic_deco_v2/125X_mcRun3_2022cosmics_realistic_deco_v3
  • MC Run3 realistic HI https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/125X_mcRun3_2022_realistic_HI_v2/125X_mcRun3_2022_realistic_HI_v3
  • MC Run3 2023 realistic https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/125X_mcRun3_2023_realistic_v2/125X_mcRun3_2023_realistic_v3
  • MC Run3 2024 realistic https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/125X_mcRun3_2024_realistic_v2/125X_mcRun3_2024_realistic_v3

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

to be backported together with other updates to 12.4.X

cc: @cms-sw/alca-l2

mmusich avatar Jul 15 '22 18:07 mmusich

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38760/31084

  • This PR adds an extra 80KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): #38681, #38758, #38660, #38711, #38733
    • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #38702, #38660, #38733, #38736, #33532

cmsbuild avatar Jul 15 '22 18:07 cmsbuild

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • EventFilter/CSCRawToDigi (reconstruction)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/HcalCommonData (geometry)
  • Geometry/TrackerCommonData (geometry)
  • Geometry/VeryForwardData (geometry)
  • SimG4CMS/Calo (simulation)
  • SimG4CMS/ShowerLibraryProducer (simulation)
  • SimG4Core/Configuration (simulation)

@civanch, @Dr15Jones, @jordan-martins, @bsunanda, @makortel, @bbilin, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @clacaputo, @kskovpen, @jpata can you please review it and eventually sign? Thanks. @thomreis, @felicepantaleo, @kpedro88, @ghugo83, @Martin-Grunewald, @bsunanda, @grzanka, @trtomei, @slomeo, @venturia, @vargasa, @makortel, @JanFSchulte, @missirol, @simonepigazzini, @beaucero, @barvic, @fabferro, @rovere, @VinInn, @ptcox, @mmusich, @mtosi, @fabiocos this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Jul 15 '22 18:07 cmsbuild

please test

mmusich avatar Jul 15 '22 19:07 mmusich

@mmusich I have prepared the revert of https://github.com/cms-sw/cmssw/pull/38692 in #38762 Since I doubt you'll be able to collect all needed signatures by this evening, let me revert that PR now: you can add the new GTs in this PR of yours, so that all changes can be merged together

perrotta avatar Jul 15 '22 19:07 perrotta

@mmusich @francescobrivio please add back here the commit from https://github.com/cms-sw/cmssw/pull/38692 that was reverted in the master, see https://github.com/cms-sw/cmssw/pull/38762#issuecomment-1185848077

perrotta avatar Jul 15 '22 19:07 perrotta

please add back here the commit from https://github.com/cms-sw/cmssw/pull/38692 that was reverted in the master, see https://github.com/cms-sw/cmssw/pull/38762#issuecomment-1185848077

done.

mmusich avatar Jul 15 '22 19:07 mmusich

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38760/31089

  • This PR adds an extra 80KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/AlCa/python/autoCond.py modified in PR(s): #38758
    • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): #38681, #38758, #38660, #38711, #38733
    • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #38702, #38660, #38733, #38736, #33532

cmsbuild avatar Jul 15 '22 20:07 cmsbuild

Pull request #38760 was updated. @malbouis, @civanch, @yuanchao, @jordan-martins, @bsunanda, @makortel, @bbilin, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @Dr15Jones, @clacaputo, @kskovpen, @jpata, @tvami, @ChrisMisan, @francescobrivio can you please check and sign again.

cmsbuild avatar Jul 15 '22 20:07 cmsbuild

@cmsbuild, please test

mmusich avatar Jul 15 '22 20:07 mmusich

-1

Failed Tests: UnitTests RelVals RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b625f/26274/summary.html COMMIT: 4bc7dca5e8024c393db78a4d4410cdad9cfa12be CMSSW: CMSSW_12_5_X_2022-07-15-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38760/26274/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

  • @cms-sw cms-sw/cmssw#38762
  • @Dr15Jones cms-sw/cmssw#38754
  • @wpmccormack cms-sw/cmssw#37963
  • @francescobrivio cms-sw/cmssw#38692
  • @bsunanda cms-sw/cmssw#38746

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b625f/26274/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b625f/26274/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

RelVals

  • 136.7611136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log
  • 136.88811136.88811_RunJetHT2018D_reminiaodUL+RunJetHT2018D_reminiaodUL+REMINIAOD_data2018UL+HARVEST2018_REMINIAOD_data2018UL/step2_RunJetHT2018D_reminiaodUL+RunJetHT2018D_reminiaodUL+REMINIAOD_data2018UL+HARVEST2018_REMINIAOD_data2018UL.log
  • 136.8311136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017/step2_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017.log
Expand to see more relval errors ...

RelVals-INPUT

  • 4.64.6_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1/step2_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1.log
  • 136.72411136.72411_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM.log
  • 136.72412136.72412_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM+HARVESTDR2_REMININANO_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM+HARVESTDR2_REMININANO_data2016UL_HIPM.log
Expand to see more relval errors ...

cmsbuild avatar Jul 15 '22 21:07 cmsbuild

By the way, I think that also the GEN-SIM samples from which the PU events are drawn for the mixing in the PU workflows should be updated in order to be consistent with the vertex smearing of the signal. Are these the relevant lines:

https://github.com/cms-sw/cmssw/blob/2a0aaba061bee4d7559a605eb7465733f2972641/Configuration/PyReleaseValidation/python/relval_steps.py#L3571-L3574

? @cms-sw/pdmv-l2

mmusich avatar Jul 15 '22 22:07 mmusich

@cmsbuild please test

  • The failures all report: OSError: No such file or directory 'RecoMET/METPUSubtraction/data/models/deepmet_phase2/deepmet_v1_phase2/model.graphdef' in the CMSSW_SEARCH_PATH which is unrelated to this PR

francescobrivio avatar Jul 16 '22 09:07 francescobrivio

By the way, I think that also the GEN-SIM samples from which the PU events are drawn for the mixing in the PU workflows should be updated in order to be consistent with the vertex smearing of the signal.

And that prevents the possibility to backport it in 12_4_X (just to make it clear and avoid discussions at the ORP meetings)

perrotta avatar Jul 16 '22 10:07 perrotta

And that prevents the possibility to backport it in 12_4_X

Not sure to understand why this is a decisive argument, but in any case the agreement was to update relvals in 12_5_X only, so the 12_4_X version (currently held) should only contain the GEM alignment update

mmusich avatar Jul 16 '22 12:07 mmusich

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b625f/26282/summary.html COMMIT: 4bc7dca5e8024c393db78a4d4410cdad9cfa12be CMSSW: CMSSW_12_5_X_2022-07-15-2300/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38760/26282/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 21805 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3654053
  • DQMHistoTests: Total failures: 49862
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3604168
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.191 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 2.191 KiB SiStrip/MechanicalView
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 7 / 49 workflows

cmsbuild avatar Jul 16 '22 14:07 cmsbuild

+1

civanch avatar Jul 16 '22 16:07 civanch

+alca

francescobrivio avatar Jul 18 '22 09:07 francescobrivio

And that prevents the possibility to backport it in 12_4_X

Not sure to understand why this is a decisive argument, but in any case the agreement was to update relvals in 12_5_X only, so the 12_4_X version (currently held) should only contain the GEM alignment update

Hi @perrotta, @mmusich, Do I understand correctly that we should not update the GTs with the new BeamSpot tags in the 12_4_X autoCond even if the big 12_4_X MC production is already using the new beamspot even in the premix and GEN-SIM steps?

francescobrivio avatar Jul 18 '22 09:07 francescobrivio

Do I understand correctly that we should not update the GTs with the new BeamSpot tags in the 12_4_X autoCond even if the big 12_4_X MC production is already using the new beamspot even in the premix and GEN-SIM steps?

Yes. It's a too big change for a closed cycle.

mmusich avatar Jul 18 '22 10:07 mmusich

Sorry for the naive questions.... but this means we have a closed cycled release which is inconsistent with the ongoing production with the very same closed cycle release (which also was just delayed exactly in order to have the beamspot measurement included).... Can you please elaborate a little bit more, because to me this doesnt fully add up (sorry :( )

tvami avatar Jul 18 '22 10:07 tvami

but this means we have a closed cycled release which is inconsistent with the ongoing production with the very same closed cycle release (which also was just delayed exactly in order to have the beamspot measurement included)..

So what? It happened all the time. Also technically the reco beamspot is not validated in any cycle. The only ingredient you have used is the vertex smearing.

mmusich avatar Jul 18 '22 11:07 mmusich

Updated the realisticMC GTs (with the new beamspot tags) to 125X. Will re-trigger the tests.

malbouis avatar Jul 18 '22 15:07 malbouis

@cmsbuild please test

malbouis avatar Jul 18 '22 15:07 malbouis

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38760/31115

  • This PR adds an extra 12KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/AlCa/python/autoCond.py modified in PR(s): #38758
    • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): #38681, #38758, #38660, #38711, #38733
    • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): #38702, #38660, #38733, #38736, #33532

cmsbuild avatar Jul 18 '22 15:07 cmsbuild

Pull request #38760 was updated. @malbouis, @civanch, @yuanchao, @jordan-martins, @bsunanda, @makortel, @bbilin, @ianna, @mdhildreth, @AdrianoDee, @srimanob, @Dr15Jones, @clacaputo, @kskovpen, @jpata, @tvami, @ChrisMisan, @francescobrivio can you please check and sign again.

cmsbuild avatar Jul 18 '22 15:07 cmsbuild

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b625f/26310/summary.html COMMIT: 08980dc1d2226a334c6fb41f873b9b2ee51b72dc CMSSW: CMSSW_12_5_X_2022-07-18-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38760/26310/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 21805 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3662417
  • DQMHistoTests: Total failures: 50068
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3612326
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.191 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 2.191 KiB SiStrip/MechanicalView
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 7 / 49 workflows

cmsbuild avatar Jul 18 '22 20:07 cmsbuild

+alca

  • re-sign since the last commit (08980dc) was a simple renaming (from 124X to 125X) of the realistic MC GTs:
    • 2022 realistic MC: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_mcRun3_2022_realistic_v9/125X_mcRun3_2022_realistic_v1
    • 2022 realistic cosmic MC: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_mcRun3_2022cosmics_realistic_deco_v10/125X_mcRun3_2022cosmics_realistic_deco_v1
    • 2022 realistic HI MC: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_mcRun3_2022_realistic_HI_v9/125X_mcRun3_2022_realistic_HI_v1
    • 2023 realistic MC: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_mcRun3_2023_realistic_v10/125X_mcRun3_2023_realistic_v1
    • 2024 realistic MC: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_mcRun3_2024_realistic_v10/125X_mcRun3_2024_realistic_v1

francescobrivio avatar Jul 19 '22 09:07 francescobrivio

+geometry

bsunanda avatar Jul 19 '22 09:07 bsunanda

+Upgrade

srimanob avatar Jul 19 '22 11:07 srimanob

re-sign since the last commit (https://github.com/cms-sw/cmssw/commit/08980dc1d2226a334c6fb41f873b9b2ee51b72dc) was a simple renaming (from 124X to 125X) of the realistic MC GTs:

PR desciption updated as well: https://github.com/cms-sw/cmssw/pull/38760#issue-1306353104

mmusich avatar Jul 19 '22 11:07 mmusich