cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

[12_4_X] Run3 GEMGeometryBuilder Run3 modifier and fix DQM GEM chambers

Open francescobrivio opened this issue 3 years ago • 19 comments

PR description:

Backport of #38666 and #38908:

  • GEM Run3 modifier setup for the alignment.
  • Fix the geometry information of GEM chambers in DQM.

@hyunyong @jshlee @watson-ij @quark2 since we are very tight with times I took the liberty of opening the backport, it is a verbatim copy of @hyunyong's and @quark2's master PRs.

PR validation:

Code compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38666 and #38908

francescobrivio avatar Jul 11 '22 21:07 francescobrivio

backport of #38666

francescobrivio avatar Jul 11 '22 21:07 francescobrivio

A new Pull Request was created by @francescobrivio for CMSSW_12_4_X.

It involves the following packages:

  • Geometry/GEMGeometryBuilder (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. @giovanni-mocellin, @watson-ij, @fabiocos, @jshlee, @bsunanda, @trtomei, @beaucero, @slomeo this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

  • Backported from #38666

cmsbuild avatar Jul 11 '22 21:07 cmsbuild

test parameters:

  • pull_request = #38693

francescobrivio avatar Jul 11 '22 21:07 francescobrivio

@cmsbuild please test

francescobrivio avatar Jul 11 '22 21:07 francescobrivio

type gem

francescobrivio avatar Jul 11 '22 21:07 francescobrivio

-1

Failed Tests: UnitTests RelVals RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84e70a/26151/summary.html COMMIT: 8b6337b6a4b127adde031818dc1f3f997a7e61b7 CMSSW: CMSSW_12_4_X_2022-07-11-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38694/26151/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-beam_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-mutracking_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-pixel_dqm_sourceclient had ERRORS

RelVals

----- Begin Fatal Exception 12-Jul-2022 00:52:11 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Calling method for module GEMDigiProducer/'simMuonGEMDigis'
   [1] Calling method for EventSetup module GEMGeometryESModule/'gemGeometry'
   [2] While getting dependent Record from Record MuonGeometryRecord
Exception Message:
No "GEMAlignmentRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 12-Jul-2022 00:52:11 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Calling method for module GEMDigiProducer/'simMuonGEMDigis'
   [1] Calling method for EventSetup module GEMGeometryESModule/'gemGeometry'
   [2] While getting dependent Record from Record MuonGeometryRecord
Exception Message:
No "GEMAlignmentRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 12-Jul-2022 00:52:13 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Calling method for module GEMDigiProducer/'simMuonGEMDigis'
   [1] Calling method for EventSetup module GEMGeometryESModule/'gemGeometry'
   [2] While getting dependent Record from Record MuonGeometryRecord
Exception Message:
No "GEMAlignmentRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 23234.2123234.21_TTbar_14TeV+2026D49_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+MiniAOD/step2_TTbar_14TeV+2026D49_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+MiniAOD.log
  • 23234.023234.0_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal.log
  • 23434.2123434.21_TTbar_14TeV+2026D49PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU/step2_TTbar_14TeV+2026D49PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU.log
Expand to see more relval errors ...

cmsbuild avatar Jul 12 '22 00:07 cmsbuild

Pull request #38694 was updated. @civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

cmsbuild avatar Jul 12 '22 13:07 cmsbuild

@cmsbuild please test

francescobrivio avatar Jul 12 '22 13:07 francescobrivio

-1

Failed Tests: UnitTests Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84e70a/26168/summary.html COMMIT: 0602e19b249070c37b2f1c634f1f97ef9c7c31b5 CMSSW: CMSSW_12_4_X_2022-07-12-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38694/26168/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-beam_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-mutracking_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-pixel_dqm_sourceclient had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 20893 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676111
  • DQMHistoTests: Total failures: 57960
  • DQMHistoTests: Total nulls: 5
  • DQMHistoTests: Total successes: 3618124
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.25 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 2.250 KiB SiStrip/MechanicalView
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 7 / 49 workflows

cmsbuild avatar Jul 12 '22 19:07 cmsbuild

test parameters:

  • pull_requests = #38693,#38713

francescobrivio avatar Jul 12 '22 21:07 francescobrivio

@cmsbuild please test

francescobrivio avatar Jul 12 '22 21:07 francescobrivio

-1

Failed Tests: UnitTests Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84e70a/26179/summary.html COMMIT: 0602e19b249070c37b2f1c634f1f97ef9c7c31b5 CMSSW: CMSSW_12_4_X_2022-07-12-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38694/26179/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-beamhlt_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-es_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-ctpps_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-gem_dqm_sourceclient had ERRORS
and more ...

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 20893 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676111
  • DQMHistoTests: Total failures: 57960
  • DQMHistoTests: Total nulls: 5
  • DQMHistoTests: Total successes: 3618124
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.25 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 2.250 KiB SiStrip/MechanicalView
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 7 / 49 workflows

cmsbuild avatar Jul 13 '22 07:07 cmsbuild

test parameters: *

francescobrivio avatar Aug 04 '22 10:08 francescobrivio

Pull request #38694 was updated. @civanch, @Dr15Jones, @bsunanda, @makortel, @emanueleusai, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @ahmad3213, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

cmsbuild avatar Aug 04 '22 10:08 cmsbuild

@cmsbuild please test

francescobrivio avatar Aug 04 '22 10:08 francescobrivio

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84e70a/26639/summary.html COMMIT: a7d1a5c08c15554583119fb8551be50b9116e2b9 CMSSW: CMSSW_12_4_X_2022-08-03-2300/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38694/26639/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676198
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3676166
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Aug 04 '22 14:08 cmsbuild

Test are now successful. @hyunyong @quark2 @jshlee @watson-ij please clarify the urgency of this PR (or if it is needed at all in 12_4_X...)

francescobrivio avatar Aug 08 '22 13:08 francescobrivio

Hi @francescobrivio,

I think the fix of the GEM onlineDQM is well-propagated.

Best regards, Byeonghak Ko

quark2 avatar Aug 08 '22 17:08 quark2

+geometry

bsunanda avatar Aug 08 '22 18:08 bsunanda

+dqm

emanueleusai avatar Aug 16 '22 15:08 emanueleusai

+Upgrade

srimanob avatar Aug 22 '22 07:08 srimanob

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Aug 22 '22 07:08 cmsbuild

please test (18 days old tests need to be refreshed)

perrotta avatar Aug 22 '22 09:08 perrotta

This is a verbatim backport of https://github.com/cms-sw/cmssw/pull/38666 and https://github.com/cms-sw/cmssw/pull/38908 (note for the release managers)

perrotta avatar Aug 22 '22 10:08 perrotta

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84e70a/26973/summary.html COMMIT: a7d1a5c08c15554583119fb8551be50b9116e2b9 CMSSW: CMSSW_12_4_X_2022-08-22-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38694/26973/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677242
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3677210
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Aug 22 '22 14:08 cmsbuild

+1

perrotta avatar Aug 22 '22 14:08 perrotta