cms-sw
[L1T] phase-2, Use the track selector producer for the MET simulation and emulation
PR description:
Porting local https://github.com/cms-l1t-offline/cmssw/pull/1017
This PR modifies the L1TrackerEtMissProducer and L1TrackerEtMissEmulatorProducer codes to rely on the L1TrackSelectionProducer rather than their own internal track selection and vertex association codes.
This PR does not depend on any other external changes or PRs. PR validation:
Mostly the output of the two modules won't change at all. This simply more accurately reflects how the firmware will behave and makes it so that the same track selection code can be used by multiple modules. The simulation results are exactly the same. There is some slight difference in the behavior of the MET emulator, mostly coming from the fact that the minimum pt set for the simulation is 2.0 and for the emulation it was 2.02, but this is now unified at 2.0 for both simulation and emulation. See the cross checks below.
The original output of the ntuple values:
root [2] eventTree->Scan("trueMET:trueTkMET:trkMET:trkMETEmu")
- Row * trueMET * trueTkMET * trkMET * trkMETEmu *
-
0 * 2.3996737 * 38.388885 * 57.587577 * 52 * -
1 * 40.216548 * 19.016733 * 4.4636359 * 4.625 * -
2 * 0 * 15.146577 * 30.108165 * 31.25 * -
3 * 42.769996 * 19.578226 * 35.952037 * 35.25 * -
4 * 0.4338081 * 26.260469 * 65.721168 * 54.25 * -
5 * 125.65923 * 41.218193 * 37.652301 * 38.5 * -
6 * 16.149637 * 9.0316028 * 48.163761 * 46.75 * -
7 * 26.199499 * 25.994577 * 36.374916 * 41.25 * -
8 * 53.656692 * 14.420878 * 10.569204 * 11.625 * -
9 * 0 * 102.31497 * 83.241920 * 87.125 *
The output after the changes from this PR:
root [2] eventTree->Scan("trueMET:trueTkMET:trkMET:trkMETEmu")
- Row * trueMET * trueTkMET * trkMET * trkMETEmu *
-
0 * 2.3996737 * 38.388885 * 57.587577 * 54.25 * -
1 * 40.216548 * 19.016733 * 4.4636359 * 6.5 * -
2 * 0 * 15.146577 * 30.108165 * 30 * -
3 * 42.769996 * 19.578226 * 35.952037 * 30.375 * -
4 * 0.4338081 * 26.260469 * 65.721168 * 61.5 * -
5 * 125.65923 * 41.218193 * 37.652301 * 39 * -
6 * 16.149637 * 9.0316028 * 48.163761 * 50.75 * -
7 * 26.199499 * 25.994577 * 36.374916 * 41 * -
8 * 53.656692 * 14.420878 * 10.569204 * 9.625 * -
9 * 0 * 102.31497 * 83.241920 * 82.5 *
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38334/30512
- This PR adds an extra 52KB to repository
A new Pull Request was created by @cecilecaillol for master.
It involves the following packages:
- DataFormats/L1TrackTrigger (upgrade, l1)
- L1Trigger/L1TTrackMatch (upgrade, l1)
@rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks. @rovere, @Martin-Grunewald, @missirol, @sviret, @trtomei, @beaucero this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8940b7/25447/summary.html
COMMIT: cd9ff1638ad4c0f5a0f90a618a577fb6429ca345
CMSSW: CMSSW_12_5_X_2022-06-11-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38334/25447/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 6 differences found in the comparisons
- DQMHistoTests: Total files compared: 50
- DQMHistoTests: Total histograms compared: 3658678
- DQMHistoTests: Total failures: 14
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3658642
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
- Checked 208 log files, 45 edm output root files, 50 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
@cmsbuild please test
Just to refresh the test result as the previous one was almost 2 weeks ago.
-1
Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8940b7/26475/summary.html
COMMIT: cd9ff1638ad4c0f5a0f90a618a577fb6429ca345
CMSSW: CMSSW_12_5_X_2022-07-26-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38334/26475/install.sh to create a dev area with all the needed externals and cmssw changes.
Unit Tests
I found errors in the following unit tests:
---> test test-das-selected-lumis had ERRORS
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 4 differences found in the comparisons
- DQMHistoTests: Total files compared: 51
- DQMHistoTests: Total histograms compared: 3667670
- DQMHistoTests: Total failures: 8
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3667640
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
- Checked 210 log files, 47 edm output root files, 51 DQM output files
- TriggerResults: no differences found
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8940b7/26478/summary.html
COMMIT: cd9ff1638ad4c0f5a0f90a618a577fb6429ca345
CMSSW: CMSSW_12_5_X_2022-07-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38334/26478/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 10 differences found in the comparisons
- DQMHistoTests: Total files compared: 51
- DQMHistoTests: Total histograms compared: 3667670
- DQMHistoTests: Total failures: 19
- DQMHistoTests: Total nulls: 1
- DQMHistoTests: Total successes: 3667628
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
- DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
- Checked 210 log files, 47 edm output root files, 51 DQM output files
- TriggerResults: no differences found
Pull request has been put on hold by @qliphy
They need to issue an unhold command to remove the hold state or L1 can unhold it for all
Will reopen once https://github.com/cms-sw/cmssw/pull/38337 is completed.
