cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Published 20 hours ago • verified publisher icon cms-sw

Introduction of New-All-In-One tool for Offline Validation of TrkAlignment

Open antoniovagnerini opened this issue 2 years ago • 110 comments

PR description:

The aim of this PR is to introduce a new "All-In-One-Tool" common interface for the offline validation of the alignment. In particular, the validations affected are the functionality of DMR, PV (and relative trends), Geometry Comparisons as well as the JetHT validation.

The main improvements consist in the following:

  • semi-automatic analysis using CRAB
  • compatibility with Python3
  • git for output tracking
  • common plotting style for trends

PR validation:

Unit test have been devised for each validation type to ensure correctness of the outcome.

@connorpa @consuegs @mmusich

antoniovagnerini avatar Jun 09 '22 13:06 antoniovagnerini

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38304/30467

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38304/30467/cms-checkout-topic.log

cmsbuild avatar Jun 09 '22 13:06 cmsbuild

@antoniovagnerini seems we have a merge conflict

CONFLICT (content): Merge conflict in Alignment/OfflineValidation/scripts/validateAlignments.py Auto-merging Alignment/OfflineValidation/test/BuildFile.xml CONFLICT (content): Merge conflict in Alignment/OfflineValidation/test/BuildFile.xml

Please resolve conflict and commit again.

Also having more commits than the number of files changed... that's somewhat discouraged. Please group them together into a few bigger commits with the squash option of git.

tvami avatar Jun 09 '22 15:06 tvami

Oh also, just looking at the first file, .gitignore should not be commited.

tvami avatar Jun 09 '22 15:06 tvami

Also what does "aligned" in the title mean?

mmusich avatar Jun 09 '22 16:06 mmusich

type trk

tvami avatar Jun 09 '22 18:06 tvami

@cms-sw/orp-l2 can you remind me what's our review policy for files under /bin/? Is that the same policy as for /test/?

tvami avatar Jun 10 '22 13:06 tvami

@antoniovagnerini et al, I see a few files added under /data/, so those should technically go into the cms-data repository not the main repo here

tvami avatar Jun 10 '22 13:06 tvami

assign trk-dpg

mmusich avatar Jun 13 '22 07:06 mmusich

I am having a look at suggested changes and will try to perform rebase. It will take me some time, so please be patient. It is also likely I will add some small changes with fully new commits. In any case you can contact me here.

TomasKello avatar Jun 13 '22 08:06 TomasKello

Hi @antoniovagnerini given that there is a lot to do with this PR, would you mind changing it's status to a "draft PR"? Thanks!

tvami avatar Jun 15 '22 09:06 tvami

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38304/30941

ERROR: Build errors found during clang-tidy run.

Alignment/OfflineValidation/interface/Trend.h:126:119: error: format string is not a string literal (potentially insecure) [clang-diagnostic-format-security]
template<typename T, typename ... Args> inline T * Get (Args ... args) { return dynamic_cast<T*>(gDirectory->Get(Form(args...))); } 
                                                                                                                      ^
Alignment/OfflineValidation/bin/DMRtrends.cc:221:22: note: in instantiation of function template specialization 'Get<TGraphErrors, TString>' requested here
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild avatar Jul 08 '22 14:07 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38304/30961

  • This PR adds an extra 868KB to repository

  • Found files with invalid states:

    • Alignment/OfflineValidation/test/example.yaml:
      • Added: ba85caa0bd966a67a20733aa17012cf313346b49
      • Modified: 9275902a1d53655cc8558993a2aecd5d17e235df, 39ef13dc69b32ca6ebc22d6666361a4b199ee669
      • Deleted: 503d85134c5d31bbb32945c106fd825848c4bcd5
    • DMRsingle.cc:
      • Added: d0043ff8143abf9a6667536986bb05d181e20eb2
      • Deleted: fb080cfab403a339c7702896559ac75900e95358
    • Alignment/OfflineValidation/bin/example.json:
      • Added: 83450bdf55e1ff6fb17d3e03e1d741f775dba5b4
      • Modified: 5a339a94ccec773c338dee1963bc447dcd809dbc, 5dd3655e405098a686fcb8725e87245c5b1879a9
      • Deleted: ba85caa0bd966a67a20733aa17012cf313346b49
    • merge.cc:
      • Added: fb080cfab403a339c7702896559ac75900e95358
      • Modified: 89a1cdd8dff4956ba689f56a50e4af44c15e3272
      • Deleted: bbefbc387e873db1fd8176b2571c724600ddb3bf
    • Alignment/OfflineValidation/src/PlotTrends.cc:
      • Added: d46fa75b60eb87d37efa388991762f305a9c3859
      • Modified: 1ab3ead4784ba3c837d1a40f2d758c75a4f83098, 68c1db27ceba817b56ac1699a848776202d1b463
      • Deleted: d311266ea326893c6c2618759df5346e9eb5954b
    • Alignment/OfflineValidation/test/test_SplitVsingleAndMerge.sh:
      • Added: 3b084608adfa503d226054a2f1cc31013b7f7d59
      • Modified: 039790e212fe5d997c007324f1d538c313733518
      • Deleted: bf5b3cbe54b1acf7bcb4cf7f68b78bedab08a8b4
    • Alignment/OfflineValidation/scripts/haddws.C:
      • Added: abb617dd0f0918c0bfb7fd76b2db7ab51943e694
      • Deleted: 6f35505eede40378e0b5fbbba471023b6cab438c
    • Alignment/OfflineValidation/bin/DAG.cc:
      • Added: bbefbc387e873db1fd8176b2571c724600ddb3bf
      • Modified: efb7517e6307a50b6db437387088c64cbe2c9660, e05438a2cfe72e8bb7ed3f9a7b05da800b0d6354, 33060f92c59a2beef9d2eb280e9b0ee7c875beca
      • Deleted: 28a9337f525d1abbb837165597fd074a4a748e69
    • Alignment/OfflineValidation/bin/.default.sub:
      • Added: e05438a2cfe72e8bb7ed3f9a7b05da800b0d6354
      • Modified: 2a2ca2167a2097bde896b8e102f40382103f321c
      • Deleted: c065b338a0108febe87cd8e91670d1ca0104f658
    • Alignment/OfflineValidation/test/testDMR_ULRun2_and_ReReco.json:
      • Added: 4eaa4c7f6f4f4fb78b851f74eb1b1514d33a2828
      • Modified: 7c685cf5ca10c7ef79e15fc52e1528740f949dc9
      • Deleted: a02d20e52fc7af4e08631097e567c743f0e1dc41
    • Alignment/OfflineValidation/test/exampleDMR_ULRun2.yaml:
      • Added: 7c685cf5ca10c7ef79e15fc52e1528740f949dc9
      • Deleted: a02d20e52fc7af4e08631097e567c743f0e1dc41
    • Alignment/OfflineValidation/test/exampleDMRmerge.json:
      • Added: 7c685cf5ca10c7ef79e15fc52e1528740f949dc9
      • Deleted: 503d85134c5d31bbb32945c106fd825848c4bcd5
    • Alignment/OfflineValidation/interface/PlotTrends.h:
      • Added: d46fa75b60eb87d37efa388991762f305a9c3859
      • Modified: 1ab3ead4784ba3c837d1a40f2d758c75a4f83098
      • Deleted: d311266ea326893c6c2618759df5346e9eb5954b
    • Alignment/OfflineValidation/bin/default.sub:
      • Added: bbefbc387e873db1fd8176b2571c724600ddb3bf
      • Modified: efb7517e6307a50b6db437387088c64cbe2c9660
      • Deleted: e05438a2cfe72e8bb7ed3f9a7b05da800b0d6354
    • validateAlignment.cc:
      • Added: d0043ff8143abf9a6667536986bb05d181e20eb2
      • Modified: 89a1cdd8dff4956ba689f56a50e4af44c15e3272, a770bdf6002c4f088351504e855235009b02e635, 0a03640a00d6f51ef739cd9ed89f492e1009f1d6
      • Deleted: bbefbc387e873db1fd8176b2571c724600ddb3bf
    • Alignment/OfflineValidation/data/lumiperFullRun2_delivered.txt:
      • Added: 1ab3ead4784ba3c837d1a40f2d758c75a4f83098
      • Deleted: 6853ed5c73eea983ff7aeafd916af5c0a5c3ee73
    • Alignment/OfflineValidation/bin/merge.cc:
      • Added: bbefbc387e873db1fd8176b2571c724600ddb3bf
      • Deleted: e05438a2cfe72e8bb7ed3f9a7b05da800b0d6354
    • exceptions.h:
      • Added: d0043ff8143abf9a6667536986bb05d181e20eb2
      • Modified: 89a1cdd8dff4956ba689f56a50e4af44c15e3272, a770bdf6002c4f088351504e855235009b02e635
      • Deleted: bbefbc387e873db1fd8176b2571c724600ddb3bf
    • Alignment/OfflineValidation/bin/.example.info:
      • Added: e05438a2cfe72e8bb7ed3f9a7b05da800b0d6354
      • Modified: e7717730a146d0a401a8a2b1c23e0e12136517b9, 33060f92c59a2beef9d2eb280e9b0ee7c875beca, 9b0c70a8df8ed224ef8bece5060a290b3135697d
      • Deleted: 28a9337f525d1abbb837165597fd074a4a748e69
    • Alignment/OfflineValidation/bin/nextweek.sub:
      • Added: bbefbc387e873db1fd8176b2571c724600ddb3bf
      • Deleted: 4e68ba6f93e68b7dff899d6374e0447c32887245
    • getINFO.cc:
      • Added: a770bdf6002c4f088351504e855235009b02e635
      • Deleted: bbefbc387e873db1fd8176b2571c724600ddb3bf
    • Alignment/OfflineValidation/test/example.json:
      • Added: ba85caa0bd966a67a20733aa17012cf313346b49
      • Modified: 9275902a1d53655cc8558993a2aecd5d17e235df
      • Deleted: 503d85134c5d31bbb32945c106fd825848c4bcd5
    • Alignment/OfflineValidation/test/test_PVsingleAndmerge.sh:
      • Added: dc544389b99bac36ba9c815443fe22f23b89dc70
      • Modified: 1a314818d139c3968dc990eae1858c56a0156d0b, 0eb2fe5dde26e2eb15917c6da9ad4bb34c67e4fc
      • Deleted: bf5b3cbe54b1acf7bcb4cf7f68b78bedab08a8b4
    • Alignment/OfflineValidation/test/exampleDMR_ReReco.json:
      • Added: 7c685cf5ca10c7ef79e15fc52e1528740f949dc9
      • Deleted: a02d20e52fc7af4e08631097e567c743f0e1dc41
    • Alignment/OfflineValidation/test/testDMR_ReReco_cfg.py:
      • Added: 4eaa4c7f6f4f4fb78b851f74eb1b1514d33a2828
      • Deleted: a02d20e52fc7af4e08631097e567c743f0e1dc41
    • Alignment/OfflineValidation/test/test_DMRmerge.sh:
      • Added: 7c685cf5ca10c7ef79e15fc52e1528740f949dc9
      • Deleted: bf5b3cbe54b1acf7bcb4cf7f68b78bedab08a8b4
    • DAG.cc:
      • Added: d0043ff8143abf9a6667536986bb05d181e20eb2
      • Modified: fb080cfab403a339c7702896559ac75900e95358, 89a1cdd8dff4956ba689f56a50e4af44c15e3272, a770bdf6002c4f088351504e855235009b02e635, 0a03640a00d6f51ef739cd9ed89f492e1009f1d6, 312c418eb4c815c4b4a05780f93cfbe42f748beb, 0071e088f83aab9a90055c80d33d01350bfaec28, 1f48c8729e5d8edc41fbbeab6ab82919382250bb
      • Deleted: bbefbc387e873db1fd8176b2571c724600ddb3bf
    • Alignment/OfflineValidation/bin/.gitignore:
      • Added: 9840a96b22f0e2e466b67eb18cbed540363fa186
      • Modified: 33060f92c59a2beef9d2eb280e9b0ee7c875beca
      • Deleted: 28a9337f525d1abbb837165597fd074a4a748e69
    • Alignment/OfflineValidation/test/exampleDMR_ULRun2.json:
      • Added: 7c685cf5ca10c7ef79e15fc52e1528740f949dc9
      • Deleted: a02d20e52fc7af4e08631097e567c743f0e1dc41
    • Alignment/OfflineValidation/bin/validateAlignment.cc:
      • Added: bbefbc387e873db1fd8176b2571c724600ddb3bf
      • Modified: efb7517e6307a50b6db437387088c64cbe2c9660
      • Deleted: 28a9337f525d1abbb837165597fd074a4a748e69
    • Options.h:
      • Added: d0043ff8143abf9a6667536986bb05d181e20eb2
      • Modified: a770bdf6002c4f088351504e855235009b02e635
      • Deleted: bbefbc387e873db1fd8176b2571c724600ddb3bf
    • Alignment/OfflineValidation/bin/example.cc:
      • Added: e05438a2cfe72e8bb7ed3f9a7b05da800b0d6354
      • Deleted: 28a9337f525d1abbb837165597fd074a4a748e69
    • Alignment/OfflineValidation/test/testDMR_ULRun2_and_ReReco.yaml:
      • Added: 4eaa4c7f6f4f4fb78b851f74eb1b1514d33a2828
      • Modified: 7c685cf5ca10c7ef79e15fc52e1528740f949dc9
      • Deleted: a02d20e52fc7af4e08631097e567c743f0e1dc41
    • Alignment/OfflineValidation/test/testDMR_ULRun2_cfg.py:
      • Added: 4eaa4c7f6f4f4fb78b851f74eb1b1514d33a2828
      • Modified: 7c685cf5ca10c7ef79e15fc52e1528740f949dc9
      • Deleted: a02d20e52fc7af4e08631097e567c743f0e1dc41
    • Alignment/OfflineValidation/interface/outTrends.h:
      • Added: 1ab3ead4784ba3c837d1a40f2d758c75a4f83098
      • Modified: e3821de8510f38402361553a5b260f5a8c48cebc
      • Deleted: 5dd2f6e0a890061bb08edb4ca59bef165176da6d
    • Makefile:
      • Added: d0043ff8143abf9a6667536986bb05d181e20eb2
      • Modified: fb080cfab403a339c7702896559ac75900e95358, 89a1cdd8dff4956ba689f56a50e4af44c15e3272, a770bdf6002c4f088351504e855235009b02e635, 0dba4cd4480a47ae3ccecf05725cae654923d3e8, 1f48c8729e5d8edc41fbbeab6ab82919382250bb
      • Deleted: bbefbc387e873db1fd8176b2571c724600ddb3bf
    • nextweek.sub:
      • Added: 0071e088f83aab9a90055c80d33d01350bfaec28
      • Deleted: bbefbc387e873db1fd8176b2571c724600ddb3bf
    • single.cc:
      • Added: fb080cfab403a339c7702896559ac75900e95358
      • Modified: 89a1cdd8dff4956ba689f56a50e4af44c15e3272
      • Deleted: bbefbc387e873db1fd8176b2571c724600ddb3bf
    • README.md:
      • Added: d0043ff8143abf9a6667536986bb05d181e20eb2
      • Modified: fb080cfab403a339c7702896559ac75900e95358, 89a1cdd8dff4956ba689f56a50e4af44c15e3272, a770bdf6002c4f088351504e855235009b02e635, 0071e088f83aab9a90055c80d33d01350bfaec28, 1f48c8729e5d8edc41fbbeab6ab82919382250bb
      • Deleted: bbefbc387e873db1fd8176b2571c724600ddb3bf
    • Alignment/OfflineValidation/test/PVtrends.yaml:
      • Added: 1ab3ead4784ba3c837d1a40f2d758c75a4f83098
      • Modified: 68c1db27ceba817b56ac1699a848776202d1b463
      • Deleted: d311266ea326893c6c2618759df5346e9eb5954b
    • Alignment/OfflineValidation/test/test_GCPfull.sh:
      • Added: b2651b88785d24dc82a0cbb7a4803d58399f19a1
      • Modified: ad4eb97ea2fd4404704e272a7d137e016b75d6bd, 701526d844de1f1a7d8df94e3f654f1c3faad23e
      • Deleted: bf5b3cbe54b1acf7bcb4cf7f68b78bedab08a8b4
    • Alignment/OfflineValidation/bin/getINFO.cc:
      • Added: bbefbc387e873db1fd8176b2571c724600ddb3bf
      • Modified: e05438a2cfe72e8bb7ed3f9a7b05da800b0d6354, 83450bdf55e1ff6fb17d3e03e1d741f775dba5b4
      • Deleted: 28a9337f525d1abbb837165597fd074a4a748e69
    • Alignment/OfflineValidation/scripts/GCP:
      • Added: 9b0c70a8df8ed224ef8bece5060a290b3135697d
      • Deleted: ab61205b6ea11e5196310a6db517ae3ee5844b77
    • Alignment/OfflineValidation/test/exampleDMR_ReReco.yaml:
      • Added: 7c685cf5ca10c7ef79e15fc52e1528740f949dc9
      • Deleted: a02d20e52fc7af4e08631097e567c743f0e1dc41
    • Alignment/OfflineValidation/bin/GeometryComparisonPlotter.h:
      • Added: e05438a2cfe72e8bb7ed3f9a7b05da800b0d6354
      • Modified: 4e68ba6f93e68b7dff899d6374e0447c32887245, 555f95cd6741933ed06e1a4b03766ccfa1fc987d
      • Deleted: ab61205b6ea11e5196310a6db517ae3ee5844b77
    • DAG.h:
      • Added: d0043ff8143abf9a6667536986bb05d181e20eb2
      • Modified: fb080cfab403a339c7702896559ac75900e95358, 89a1cdd8dff4956ba689f56a50e4af44c15e3272, 0a03640a00d6f51ef739cd9ed89f492e1009f1d6, 0071e088f83aab9a90055c80d33d01350bfaec28, 1f48c8729e5d8edc41fbbeab6ab82919382250bb
      • Deleted: bbefbc387e873db1fd8176b2571c724600ddb3bf
    • Alignment/OfflineValidation/bin/single.cc:
      • Added: bbefbc387e873db1fd8176b2571c724600ddb3bf
      • Deleted: e05438a2cfe72e8bb7ed3f9a7b05da800b0d6354
    • Alignment/OfflineValidation/test/PV_test.yaml:
      • Added: 32f88970febfc668c7679555512347c32c067a17
      • Deleted: 503d85134c5d31bbb32945c106fd825848c4bcd5
    • Alignment/OfflineValidation/bin/DAG.h:
      • Added: bbefbc387e873db1fd8176b2571c724600ddb3bf
      • Modified: efb7517e6307a50b6db437387088c64cbe2c9660, e05438a2cfe72e8bb7ed3f9a7b05da800b0d6354
      • Deleted: 28a9337f525d1abbb837165597fd074a4a748e69
    • Options.cc:
      • Added: d0043ff8143abf9a6667536986bb05d181e20eb2
      • Modified: 89a1cdd8dff4956ba689f56a50e4af44c15e3272, a770bdf6002c4f088351504e855235009b02e635, 0071e088f83aab9a90055c80d33d01350bfaec28
      • Deleted: bbefbc387e873db1fd8176b2571c724600ddb3bf
    • example.info:
      • Added: 1e9fcb2725450bcaebd93689f8f840f867ee6764
      • Deleted: bbefbc387e873db1fd8176b2571c724600ddb3bf
    • Alignment/OfflineValidation/bin/.defaultWithCMSRun.sub:
      • Added: 4fbfeaa0df73854182eaaa0ce0d37f7a471ca9d8
      • Deleted: c065b338a0108febe87cd8e91670d1ca0104f658
    • Alignment/OfflineValidation/test/test_DMRsingleAndmerge.sh:
      • Added: 4eaa4c7f6f4f4fb78b851f74eb1b1514d33a2828
      • Modified: 7c685cf5ca10c7ef79e15fc52e1528740f949dc9, d5c3f55a4b3a6130ca0c158eab34a09f08159516, be05f6c4ed27803c5f1d15086182c2d50a9cade7
      • Deleted: bf5b3cbe54b1acf7bcb4cf7f68b78bedab08a8b4
    • toolbox.h:
      • Added: a770bdf6002c4f088351504e855235009b02e635
      • Deleted: bbefbc387e873db1fd8176b2571c724600ddb3bf
    • default.sub:
      • Added: 0071e088f83aab9a90055c80d33d01350bfaec28
      • Deleted: bbefbc387e873db1fd8176b2571c724600ddb3bf
    • config.info:
      • Added: d0043ff8143abf9a6667536986bb05d181e20eb2
      • Modified: fb080cfab403a339c7702896559ac75900e95358, 89a1cdd8dff4956ba689f56a50e4af44c15e3272, a770bdf6002c4f088351504e855235009b02e635, 0a03640a00d6f51ef739cd9ed89f492e1009f1d6, 312c418eb4c815c4b4a05780f93cfbe42f748beb, 0071e088f83aab9a90055c80d33d01350bfaec28, 1f48c8729e5d8edc41fbbeab6ab82919382250bb
      • Deleted: 1e9fcb2725450bcaebd93689f8f840f867ee6764
    • Alignment/OfflineValidation/test/test.yaml:
      • Added: 4f0c8ba2c0809fce0907e696502023b4f77ecf1b
      • Deleted: 503d85134c5d31bbb32945c106fd825848c4bcd5
    • Alignment/OfflineValidation/test/testDMRmerge.json:
      • Added: 4eaa4c7f6f4f4fb78b851f74eb1b1514d33a2828
      • Deleted: 7c685cf5ca10c7ef79e15fc52e1528740f949dc9
    • Alignment/OfflineValidation/bin/GeometryComparisonPlotter.cc:
      • Added: e05438a2cfe72e8bb7ed3f9a7b05da800b0d6354
      • Modified: 4e68ba6f93e68b7dff899d6374e0447c32887245, 555f95cd6741933ed06e1a4b03766ccfa1fc987d
      • Deleted: ab61205b6ea11e5196310a6db517ae3ee5844b77
    • Alignment/OfflineValidation/bin/example.info:
      • Added: bbefbc387e873db1fd8176b2571c724600ddb3bf, 33060f92c59a2beef9d2eb280e9b0ee7c875beca
      • Deleted: e05438a2cfe72e8bb7ed3f9a7b05da800b0d6354, 28a9337f525d1abbb837165597fd074a4a748e69
    • Alignment/OfflineValidation/bin/example.yaml:
      • Added: 97aeba331e3830fb057966ccf613cc0082a6a2d3
      • Deleted: ba85caa0bd966a67a20733aa17012cf313346b49

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File .gitignore modified in PR(s): #30594

cmsbuild avatar Jul 09 '22 16:07 cmsbuild

New categories assigned: trk-dpg

@connorpa,@mmusich,@tsusa you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild avatar Jul 09 '22 16:07 cmsbuild

A new Pull Request was created by @antoniovagnerini for master.

It involves the following packages:

  • .gitignore (core)
  • Alignment/OfflineValidation (alca)

@connorpa, @yuanchao, @smuzaffar, @makortel, @malbouis, @cmsbuild, @Dr15Jones, @tsusa, @mmusich, @tvami, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks. @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Jul 09 '22 16:07 cmsbuild

please test

mmusich avatar Jul 10 '22 11:07 mmusich

-1

Failed Tests: Build ClangBuild Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-578721/26110/summary.html COMMIT: 3a94a0bedd0bc4fd571a06b6db40e656a74a14c7 CMSSW: CMSSW_12_5_X_2022-07-10-0000/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38304/26110/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

cmsbuild avatar Jul 10 '22 13:07 cmsbuild

@ChrisMisan

Can you consider updating legacy EDAnalyzers under:

none of these analyzer is being touched here. They're brought via dependencies and they should be taken care of by the central DQM team.

mmusich avatar Jul 11 '22 13:07 mmusich

@ChrisMisan this PR is touching in Alignment/OfflineValidation, DQMServices/Demo is a different business.

tvami avatar Jul 11 '22 13:07 tvami

@mmusich @tvami sorry, my mistake.

ChrisMisan avatar Jul 11 '22 13:07 ChrisMisan

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38304/30983

ERROR: Build errors found during clang-tidy run.

Alignment/OfflineValidation/interface/Trend.h:126:119: error: format string is not a string literal (potentially insecure) [clang-diagnostic-format-security]
template<typename T, typename ... Args> inline T * Get (Args ... args) { return dynamic_cast<T*>(gDirectory->Get(Form(args...))); } 
                                                                                                                      ^
Alignment/OfflineValidation/bin/DMRtrends.cc:221:22: note: in instantiation of function template specialization 'Get<TGraphErrors, TString>' requested here
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild avatar Jul 11 '22 14:07 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38304/30984

  • This PR adds an extra 896KB to repository

  • Found files with invalid states:

    • Alignment/OfflineValidation/test/example.yaml:
      • Added: 14a56a7f51ba88bcdc6b2dd9832ad2107f9a888d
      • Modified: af825f6cd7ffac21377d35fabdce8ce508f26757, 5aecee0b0a62cecc1a0164a1160f22ae3c3e8e4b
      • Deleted: 0517b8fa3797eb1c7893d54ddf94666626563a43
    • DMRsingle.cc:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Deleted: 97ec22969460fb75592dd62a807f57f7f1840d62
    • Alignment/OfflineValidation/bin/example.json:
      • Added: 0aa8dbd2e894b915a6f5f9b845eefb3036e7ebd9
      • Modified: 0116143927ce435cd799225c1c3dbc77bb838d8a, f49d3fbdcb33e81aa43e757970545cace206dae0
      • Deleted: 14a56a7f51ba88bcdc6b2dd9832ad2107f9a888d
    • merge.cc:
      • Added: 97ec22969460fb75592dd62a807f57f7f1840d62
      • Modified: 15f3721967cf605888275ca38d1dfe3452ea50b7
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/src/PlotTrends.cc:
      • Added: ff03d93420a379a2199416541d3316929f1d9a17
      • Modified: 886ecf9d253da78c7704ca0f8929c72e232585a2, 5578202f7c4c2338a20b7c37e29a72bd2c351de8
      • Deleted: 85feaf1e41ab487cee19deebca115ab49a3cec16
    • Alignment/OfflineValidation/test/test_SplitVsingleAndMerge.sh:
      • Added: 9ceed56bf35fffe3f52e3808173bb148d54f96bd
      • Modified: c41eb12ce0133f04cefd1aa9559693e156d6df87
      • Deleted: 5d70fb82c88c0edb8df00da375d26f5aa5ddccc3
    • Alignment/OfflineValidation/scripts/haddws.C:
      • Added: 6d692aacf9199748a54937cd14c1809b062347ea
      • Deleted: 94d3e0be317d42dff32a889e0b8a5aa94b385c3e
    • Alignment/OfflineValidation/bin/DAG.cc:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Modified: dcabe7e35286c63a0cf5ef6f45da4e16c639a4ef, 0ddb6d8f7e1afd71caa94b682b036ac96366d614, b2f7abf2bbd8c0cd6cfe4d1c6ed4816cb8c9264d
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/bin/.default.sub:
      • Added: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Modified: 8ef7829f9ebfed1d9f36193b1fa60307b0e512f7
      • Deleted: dba64540e36ec5879cca34d5fcc0fdb44040907f
    • Alignment/OfflineValidation/test/testDMR_ULRun2_and_ReReco.json:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Modified: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/test/exampleDMR_ULRun2.yaml:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/test/exampleDMRmerge.json:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: 0517b8fa3797eb1c7893d54ddf94666626563a43
    • Alignment/OfflineValidation/interface/PlotTrends.h:
      • Added: ff03d93420a379a2199416541d3316929f1d9a17
      • Modified: 886ecf9d253da78c7704ca0f8929c72e232585a2
      • Deleted: 85feaf1e41ab487cee19deebca115ab49a3cec16
    • Alignment/OfflineValidation/bin/default.sub:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Modified: dcabe7e35286c63a0cf5ef6f45da4e16c639a4ef
      • Deleted: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
    • validateAlignment.cc:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, ced079b4cdd6c707f35849f356587642775aab85
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/data/lumiperFullRun2_delivered.txt:
      • Added: 886ecf9d253da78c7704ca0f8929c72e232585a2
      • Deleted: 0f54acc12de6451ccdf2fba5ee628cebbd211f98
    • Alignment/OfflineValidation/bin/merge.cc:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Deleted: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
    • exceptions.h:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/bin/.example.info:
      • Added: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Modified: 330b258db8a67f22a225b82a2054d67301e93b6b, b2f7abf2bbd8c0cd6cfe4d1c6ed4816cb8c9264d, 66bcf47b40904a27fa7da414d9435cdba476617a
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/bin/nextweek.sub:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Deleted: 09835e5a05b23a669152faa15b2e154ccbba4f90
    • getINFO.cc:
      • Added: 746adeacb9ffd393d66e89048988bc01a4cfabc0
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/test/example.json:
      • Added: 14a56a7f51ba88bcdc6b2dd9832ad2107f9a888d
      • Modified: af825f6cd7ffac21377d35fabdce8ce508f26757
      • Deleted: 0517b8fa3797eb1c7893d54ddf94666626563a43
    • Alignment/OfflineValidation/test/test_PVsingleAndmerge.sh:
      • Added: c043926f27900c494a992f34ca06e3b2e067a93b
      • Modified: fdb4af28e2c8598583f000e8d18a45f9edd78d0b, 10f486a95623483cefbd85fcd24af95a9d6edd20
      • Deleted: 5d70fb82c88c0edb8df00da375d26f5aa5ddccc3
    • Alignment/OfflineValidation/test/exampleDMR_ReReco.json:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/test/testDMR_ReReco_cfg.py:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/test/test_DMRmerge.sh:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: 5d70fb82c88c0edb8df00da375d26f5aa5ddccc3
    • DAG.cc:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 97ec22969460fb75592dd62a807f57f7f1840d62, 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, ced079b4cdd6c707f35849f356587642775aab85, 79ff3b5d6bd7c8d6cdf17b0b01e5fa646d33bb9b, fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621, c62522afb36d4ffb4267fe82bab3983df3305a9e
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/bin/.gitignore:
      • Added: cdaf73dc76e1221ef5bce275f9af77a68be33138
      • Modified: b2f7abf2bbd8c0cd6cfe4d1c6ed4816cb8c9264d
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/test/exampleDMR_ULRun2.json:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/bin/validateAlignment.cc:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Modified: dcabe7e35286c63a0cf5ef6f45da4e16c639a4ef
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Options.h:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 746adeacb9ffd393d66e89048988bc01a4cfabc0
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/bin/example.cc:
      • Added: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/test/testDMR_ULRun2_and_ReReco.yaml:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Modified: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/test/testDMR_ULRun2_cfg.py:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Modified: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/interface/outTrends.h:
      • Added: 886ecf9d253da78c7704ca0f8929c72e232585a2
      • Modified: d8f3d324f349f5e9e9f16c9a66b2806adbdd5eb7
      • Deleted: 2894f7e58d4c6fd71cfd8c44b9ec0cc1e09e450a
    • Makefile:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 97ec22969460fb75592dd62a807f57f7f1840d62, 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, 229c8b8f244a05dfcb0000fa2d78a36fdb38a8e0, c62522afb36d4ffb4267fe82bab3983df3305a9e
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • nextweek.sub:
      • Added: fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • single.cc:
      • Added: 97ec22969460fb75592dd62a807f57f7f1840d62
      • Modified: 15f3721967cf605888275ca38d1dfe3452ea50b7
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • README.md:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 97ec22969460fb75592dd62a807f57f7f1840d62, 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621, c62522afb36d4ffb4267fe82bab3983df3305a9e
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/test/PVtrends.yaml:
      • Added: 886ecf9d253da78c7704ca0f8929c72e232585a2
      • Modified: 5578202f7c4c2338a20b7c37e29a72bd2c351de8
      • Deleted: 85feaf1e41ab487cee19deebca115ab49a3cec16
    • Alignment/OfflineValidation/test/test_GCPfull.sh:
      • Added: d88a4fe191014639c22e3a65d678353115bc7bac
      • Modified: 2a7352a8d693c0768673b3e0123a62530f34ec26, e9d411fd1fa99d98733eb6e4c0c366b16f97b2eb
      • Deleted: 5d70fb82c88c0edb8df00da375d26f5aa5ddccc3
    • Alignment/OfflineValidation/bin/getINFO.cc:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Modified: 0ddb6d8f7e1afd71caa94b682b036ac96366d614, 0aa8dbd2e894b915a6f5f9b845eefb3036e7ebd9
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/scripts/GCP:
      • Added: 66bcf47b40904a27fa7da414d9435cdba476617a
      • Deleted: f29bb254fdac20a3b4be6c29e2aa6912b47ae210
    • Alignment/OfflineValidation/test/exampleDMR_ReReco.yaml:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/bin/GeometryComparisonPlotter.h:
      • Added: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Modified: 09835e5a05b23a669152faa15b2e154ccbba4f90, 309a1fa3e3ef9421a6f1abf4bf198735152c4f13
      • Deleted: f29bb254fdac20a3b4be6c29e2aa6912b47ae210
    • DAG.h:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 97ec22969460fb75592dd62a807f57f7f1840d62, 15f3721967cf605888275ca38d1dfe3452ea50b7, ced079b4cdd6c707f35849f356587642775aab85, fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621, c62522afb36d4ffb4267fe82bab3983df3305a9e
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/bin/single.cc:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Deleted: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
    • Alignment/OfflineValidation/test/PV_test.yaml:
      • Added: 42532a9231191bfe68af533c0e8042eef4c2d9a9
      • Deleted: 0517b8fa3797eb1c7893d54ddf94666626563a43
    • Alignment/OfflineValidation/bin/DAG.h:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Modified: dcabe7e35286c63a0cf5ef6f45da4e16c639a4ef, 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Options.cc:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • example.info:
      • Added: 3b8a9787d3488a9d5d44438e7158272f10639cbe
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/bin/.defaultWithCMSRun.sub:
      • Added: a119d6e3fc2df40cfe33fb1f619e424c092786c1
      • Deleted: dba64540e36ec5879cca34d5fcc0fdb44040907f
    • Alignment/OfflineValidation/test/test_DMRsingleAndmerge.sh:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Modified: fa8139dc110431813070354bb779554ff94bf76c, 48e4e4d7e65b53d3d65613a0d26ca904b8f87ac8, 57d51a9f2e313f7eb61fc8e69abe05cc600969d8
      • Deleted: 5d70fb82c88c0edb8df00da375d26f5aa5ddccc3
    • toolbox.h:
      • Added: 746adeacb9ffd393d66e89048988bc01a4cfabc0
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • default.sub:
      • Added: fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • config.info:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 97ec22969460fb75592dd62a807f57f7f1840d62, 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, ced079b4cdd6c707f35849f356587642775aab85, 79ff3b5d6bd7c8d6cdf17b0b01e5fa646d33bb9b, fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621, c62522afb36d4ffb4267fe82bab3983df3305a9e
      • Deleted: 3b8a9787d3488a9d5d44438e7158272f10639cbe
    • Alignment/OfflineValidation/test/test.yaml:
      • Added: 8069201951698707d2a2b3d526f56349290d4c5a
      • Deleted: 0517b8fa3797eb1c7893d54ddf94666626563a43
    • Alignment/OfflineValidation/test/testDMRmerge.json:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Deleted: fa8139dc110431813070354bb779554ff94bf76c
    • Alignment/OfflineValidation/bin/GeometryComparisonPlotter.cc:
      • Added: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Modified: 09835e5a05b23a669152faa15b2e154ccbba4f90, 309a1fa3e3ef9421a6f1abf4bf198735152c4f13
      • Deleted: f29bb254fdac20a3b4be6c29e2aa6912b47ae210
    • Alignment/OfflineValidation/bin/example.info:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3, b2f7abf2bbd8c0cd6cfe4d1c6ed4816cb8c9264d
      • Deleted: 0ddb6d8f7e1afd71caa94b682b036ac96366d614, 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/bin/example.yaml:
      • Added: 275f5e0ebbd0092ca30f6da75880e46f005b5ac6
      • Deleted: 14a56a7f51ba88bcdc6b2dd9832ad2107f9a888d

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File .gitignore modified in PR(s): #30594

cmsbuild avatar Jul 11 '22 14:07 cmsbuild

Pull request #38304 was updated. @connorpa, @yuanchao, @smuzaffar, @makortel, @malbouis, @cmsbuild, @Dr15Jones, @tsusa, @mmusich, @tvami, @ChrisMisan, @francescobrivio can you please check and sign again.

cmsbuild avatar Jul 11 '22 14:07 cmsbuild

@cmsbuild, please test

mmusich avatar Jul 11 '22 14:07 mmusich

-1

Failed Tests: UnitTests Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-578721/26138/summary.html COMMIT: 940c9d5c4710dd0111687966fe411cd529b4beaa CMSSW: CMSSW_12_5_X_2022-07-11-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38304/26138/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test GCPall had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3655970
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3655940
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jul 11 '22 18:07 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38304/30993

  • This PR adds an extra 884KB to repository

  • Found files with invalid states:

    • Alignment/OfflineValidation/test/example.yaml:
      • Added: 14a56a7f51ba88bcdc6b2dd9832ad2107f9a888d
      • Modified: af825f6cd7ffac21377d35fabdce8ce508f26757, 5aecee0b0a62cecc1a0164a1160f22ae3c3e8e4b
      • Deleted: 0517b8fa3797eb1c7893d54ddf94666626563a43
    • DMRsingle.cc:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Deleted: 97ec22969460fb75592dd62a807f57f7f1840d62
    • Alignment/OfflineValidation/bin/example.json:
      • Added: 0aa8dbd2e894b915a6f5f9b845eefb3036e7ebd9
      • Modified: 0116143927ce435cd799225c1c3dbc77bb838d8a, f49d3fbdcb33e81aa43e757970545cace206dae0
      • Deleted: 14a56a7f51ba88bcdc6b2dd9832ad2107f9a888d
    • merge.cc:
      • Added: 97ec22969460fb75592dd62a807f57f7f1840d62
      • Modified: 15f3721967cf605888275ca38d1dfe3452ea50b7
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/src/PlotTrends.cc:
      • Added: ff03d93420a379a2199416541d3316929f1d9a17
      • Modified: 886ecf9d253da78c7704ca0f8929c72e232585a2, 5578202f7c4c2338a20b7c37e29a72bd2c351de8
      • Deleted: 85feaf1e41ab487cee19deebca115ab49a3cec16
    • Alignment/OfflineValidation/test/test_SplitVsingleAndMerge.sh:
      • Added: 9ceed56bf35fffe3f52e3808173bb148d54f96bd
      • Modified: c41eb12ce0133f04cefd1aa9559693e156d6df87
      • Deleted: 5d70fb82c88c0edb8df00da375d26f5aa5ddccc3
    • Alignment/OfflineValidation/scripts/haddws.C:
      • Added: 6d692aacf9199748a54937cd14c1809b062347ea
      • Deleted: 94d3e0be317d42dff32a889e0b8a5aa94b385c3e
    • Alignment/OfflineValidation/bin/DAG.cc:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Modified: dcabe7e35286c63a0cf5ef6f45da4e16c639a4ef, 0ddb6d8f7e1afd71caa94b682b036ac96366d614, b2f7abf2bbd8c0cd6cfe4d1c6ed4816cb8c9264d
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/bin/.default.sub:
      • Added: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Modified: 8ef7829f9ebfed1d9f36193b1fa60307b0e512f7
      • Deleted: dba64540e36ec5879cca34d5fcc0fdb44040907f
    • Alignment/OfflineValidation/test/testDMR_ULRun2_and_ReReco.json:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Modified: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/test/exampleDMR_ULRun2.yaml:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/test/exampleDMRmerge.json:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: 0517b8fa3797eb1c7893d54ddf94666626563a43
    • Alignment/OfflineValidation/interface/PlotTrends.h:
      • Added: ff03d93420a379a2199416541d3316929f1d9a17
      • Modified: 886ecf9d253da78c7704ca0f8929c72e232585a2
      • Deleted: 85feaf1e41ab487cee19deebca115ab49a3cec16
    • Alignment/OfflineValidation/bin/default.sub:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Modified: dcabe7e35286c63a0cf5ef6f45da4e16c639a4ef
      • Deleted: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
    • validateAlignment.cc:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, ced079b4cdd6c707f35849f356587642775aab85
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/data/lumiperFullRun2_delivered.txt:
      • Added: 886ecf9d253da78c7704ca0f8929c72e232585a2
      • Deleted: 0f54acc12de6451ccdf2fba5ee628cebbd211f98
    • Alignment/OfflineValidation/bin/merge.cc:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Deleted: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
    • exceptions.h:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/bin/.example.info:
      • Added: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Modified: 330b258db8a67f22a225b82a2054d67301e93b6b, b2f7abf2bbd8c0cd6cfe4d1c6ed4816cb8c9264d, 66bcf47b40904a27fa7da414d9435cdba476617a
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/bin/nextweek.sub:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Deleted: 09835e5a05b23a669152faa15b2e154ccbba4f90
    • getINFO.cc:
      • Added: 746adeacb9ffd393d66e89048988bc01a4cfabc0
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/test/example.json:
      • Added: 14a56a7f51ba88bcdc6b2dd9832ad2107f9a888d
      • Modified: af825f6cd7ffac21377d35fabdce8ce508f26757
      • Deleted: 0517b8fa3797eb1c7893d54ddf94666626563a43
    • Alignment/OfflineValidation/test/test_PVsingleAndmerge.sh:
      • Added: c043926f27900c494a992f34ca06e3b2e067a93b
      • Modified: fdb4af28e2c8598583f000e8d18a45f9edd78d0b, 10f486a95623483cefbd85fcd24af95a9d6edd20
      • Deleted: 5d70fb82c88c0edb8df00da375d26f5aa5ddccc3
    • Alignment/OfflineValidation/test/exampleDMR_ReReco.json:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/test/testDMR_ReReco_cfg.py:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/test/test_DMRmerge.sh:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: 5d70fb82c88c0edb8df00da375d26f5aa5ddccc3
    • DAG.cc:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 97ec22969460fb75592dd62a807f57f7f1840d62, 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, ced079b4cdd6c707f35849f356587642775aab85, 79ff3b5d6bd7c8d6cdf17b0b01e5fa646d33bb9b, fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621, c62522afb36d4ffb4267fe82bab3983df3305a9e
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/bin/.gitignore:
      • Added: cdaf73dc76e1221ef5bce275f9af77a68be33138
      • Modified: b2f7abf2bbd8c0cd6cfe4d1c6ed4816cb8c9264d
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/test/exampleDMR_ULRun2.json:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/bin/validateAlignment.cc:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Modified: dcabe7e35286c63a0cf5ef6f45da4e16c639a4ef
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Options.h:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 746adeacb9ffd393d66e89048988bc01a4cfabc0
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/bin/example.cc:
      • Added: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/test/testDMR_ULRun2_and_ReReco.yaml:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Modified: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/test/testDMR_ULRun2_cfg.py:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Modified: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/interface/outTrends.h:
      • Added: 886ecf9d253da78c7704ca0f8929c72e232585a2
      • Modified: d8f3d324f349f5e9e9f16c9a66b2806adbdd5eb7
      • Deleted: 2894f7e58d4c6fd71cfd8c44b9ec0cc1e09e450a
    • Makefile:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 97ec22969460fb75592dd62a807f57f7f1840d62, 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, 229c8b8f244a05dfcb0000fa2d78a36fdb38a8e0, c62522afb36d4ffb4267fe82bab3983df3305a9e
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • nextweek.sub:
      • Added: fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • single.cc:
      • Added: 97ec22969460fb75592dd62a807f57f7f1840d62
      • Modified: 15f3721967cf605888275ca38d1dfe3452ea50b7
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • README.md:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 97ec22969460fb75592dd62a807f57f7f1840d62, 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621, c62522afb36d4ffb4267fe82bab3983df3305a9e
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/test/PVtrends.yaml:
      • Added: 886ecf9d253da78c7704ca0f8929c72e232585a2
      • Modified: 5578202f7c4c2338a20b7c37e29a72bd2c351de8
      • Deleted: 85feaf1e41ab487cee19deebca115ab49a3cec16
    • Alignment/OfflineValidation/test/test_GCPfull.sh:
      • Added: d88a4fe191014639c22e3a65d678353115bc7bac
      • Modified: 2a7352a8d693c0768673b3e0123a62530f34ec26, e9d411fd1fa99d98733eb6e4c0c366b16f97b2eb
      • Deleted: 5d70fb82c88c0edb8df00da375d26f5aa5ddccc3
    • Alignment/OfflineValidation/bin/getINFO.cc:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Modified: 0ddb6d8f7e1afd71caa94b682b036ac96366d614, 0aa8dbd2e894b915a6f5f9b845eefb3036e7ebd9
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/scripts/GCP:
      • Added: 66bcf47b40904a27fa7da414d9435cdba476617a
      • Deleted: f29bb254fdac20a3b4be6c29e2aa6912b47ae210
    • Alignment/OfflineValidation/test/exampleDMR_ReReco.yaml:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/bin/GeometryComparisonPlotter.h:
      • Added: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Modified: 09835e5a05b23a669152faa15b2e154ccbba4f90, 309a1fa3e3ef9421a6f1abf4bf198735152c4f13
      • Deleted: f29bb254fdac20a3b4be6c29e2aa6912b47ae210
    • DAG.h:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 97ec22969460fb75592dd62a807f57f7f1840d62, 15f3721967cf605888275ca38d1dfe3452ea50b7, ced079b4cdd6c707f35849f356587642775aab85, fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621, c62522afb36d4ffb4267fe82bab3983df3305a9e
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/bin/single.cc:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Deleted: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
    • Alignment/OfflineValidation/test/PV_test.yaml:
      • Added: 42532a9231191bfe68af533c0e8042eef4c2d9a9
      • Deleted: 0517b8fa3797eb1c7893d54ddf94666626563a43
    • Alignment/OfflineValidation/bin/DAG.h:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Modified: dcabe7e35286c63a0cf5ef6f45da4e16c639a4ef, 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Options.cc:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • example.info:
      • Added: 3b8a9787d3488a9d5d44438e7158272f10639cbe
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/bin/.defaultWithCMSRun.sub:
      • Added: a119d6e3fc2df40cfe33fb1f619e424c092786c1
      • Deleted: dba64540e36ec5879cca34d5fcc0fdb44040907f
    • Alignment/OfflineValidation/test/test_DMRsingleAndmerge.sh:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Modified: fa8139dc110431813070354bb779554ff94bf76c, 48e4e4d7e65b53d3d65613a0d26ca904b8f87ac8, 57d51a9f2e313f7eb61fc8e69abe05cc600969d8
      • Deleted: 5d70fb82c88c0edb8df00da375d26f5aa5ddccc3
    • toolbox.h:
      • Added: 746adeacb9ffd393d66e89048988bc01a4cfabc0
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • default.sub:
      • Added: fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • config.info:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 97ec22969460fb75592dd62a807f57f7f1840d62, 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, ced079b4cdd6c707f35849f356587642775aab85, 79ff3b5d6bd7c8d6cdf17b0b01e5fa646d33bb9b, fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621, c62522afb36d4ffb4267fe82bab3983df3305a9e
      • Deleted: 3b8a9787d3488a9d5d44438e7158272f10639cbe
    • Alignment/OfflineValidation/test/test.yaml:
      • Added: 8069201951698707d2a2b3d526f56349290d4c5a
      • Deleted: 0517b8fa3797eb1c7893d54ddf94666626563a43
    • Alignment/OfflineValidation/test/testDMRmerge.json:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Deleted: fa8139dc110431813070354bb779554ff94bf76c
    • Alignment/OfflineValidation/bin/GeometryComparisonPlotter.cc:
      • Added: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Modified: 09835e5a05b23a669152faa15b2e154ccbba4f90, 309a1fa3e3ef9421a6f1abf4bf198735152c4f13
      • Deleted: f29bb254fdac20a3b4be6c29e2aa6912b47ae210
    • Alignment/OfflineValidation/bin/example.info:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3, b2f7abf2bbd8c0cd6cfe4d1c6ed4816cb8c9264d
      • Deleted: 0ddb6d8f7e1afd71caa94b682b036ac96366d614, 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/bin/example.yaml:
      • Added: 275f5e0ebbd0092ca30f6da75880e46f005b5ac6
      • Deleted: 14a56a7f51ba88bcdc6b2dd9832ad2107f9a888d

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File .gitignore modified in PR(s): #30594

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38304/30993/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38304/30993/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Jul 11 '22 22:07 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38304/30994

  • This PR adds an extra 884KB to repository

  • Found files with invalid states:

    • Alignment/OfflineValidation/test/example.yaml:
      • Added: 14a56a7f51ba88bcdc6b2dd9832ad2107f9a888d
      • Modified: af825f6cd7ffac21377d35fabdce8ce508f26757, 5aecee0b0a62cecc1a0164a1160f22ae3c3e8e4b
      • Deleted: 0517b8fa3797eb1c7893d54ddf94666626563a43
    • DMRsingle.cc:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Deleted: 97ec22969460fb75592dd62a807f57f7f1840d62
    • Alignment/OfflineValidation/bin/example.json:
      • Added: 0aa8dbd2e894b915a6f5f9b845eefb3036e7ebd9
      • Modified: 0116143927ce435cd799225c1c3dbc77bb838d8a, f49d3fbdcb33e81aa43e757970545cace206dae0
      • Deleted: 14a56a7f51ba88bcdc6b2dd9832ad2107f9a888d
    • merge.cc:
      • Added: 97ec22969460fb75592dd62a807f57f7f1840d62
      • Modified: 15f3721967cf605888275ca38d1dfe3452ea50b7
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/src/PlotTrends.cc:
      • Added: ff03d93420a379a2199416541d3316929f1d9a17
      • Modified: 886ecf9d253da78c7704ca0f8929c72e232585a2, 5578202f7c4c2338a20b7c37e29a72bd2c351de8
      • Deleted: 85feaf1e41ab487cee19deebca115ab49a3cec16
    • Alignment/OfflineValidation/test/test_SplitVsingleAndMerge.sh:
      • Added: 9ceed56bf35fffe3f52e3808173bb148d54f96bd
      • Modified: c41eb12ce0133f04cefd1aa9559693e156d6df87
      • Deleted: 5d70fb82c88c0edb8df00da375d26f5aa5ddccc3
    • Alignment/OfflineValidation/scripts/haddws.C:
      • Added: 6d692aacf9199748a54937cd14c1809b062347ea
      • Deleted: 94d3e0be317d42dff32a889e0b8a5aa94b385c3e
    • Alignment/OfflineValidation/bin/DAG.cc:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Modified: dcabe7e35286c63a0cf5ef6f45da4e16c639a4ef, 0ddb6d8f7e1afd71caa94b682b036ac96366d614, b2f7abf2bbd8c0cd6cfe4d1c6ed4816cb8c9264d
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/bin/.default.sub:
      • Added: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Modified: 8ef7829f9ebfed1d9f36193b1fa60307b0e512f7
      • Deleted: dba64540e36ec5879cca34d5fcc0fdb44040907f
    • Alignment/OfflineValidation/test/testDMR_ULRun2_and_ReReco.json:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Modified: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/test/exampleDMR_ULRun2.yaml:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/test/exampleDMRmerge.json:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: 0517b8fa3797eb1c7893d54ddf94666626563a43
    • Alignment/OfflineValidation/interface/PlotTrends.h:
      • Added: ff03d93420a379a2199416541d3316929f1d9a17
      • Modified: 886ecf9d253da78c7704ca0f8929c72e232585a2
      • Deleted: 85feaf1e41ab487cee19deebca115ab49a3cec16
    • Alignment/OfflineValidation/bin/default.sub:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Modified: dcabe7e35286c63a0cf5ef6f45da4e16c639a4ef
      • Deleted: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
    • validateAlignment.cc:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, ced079b4cdd6c707f35849f356587642775aab85
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/data/lumiperFullRun2_delivered.txt:
      • Added: 886ecf9d253da78c7704ca0f8929c72e232585a2
      • Deleted: 0f54acc12de6451ccdf2fba5ee628cebbd211f98
    • Alignment/OfflineValidation/bin/merge.cc:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Deleted: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
    • exceptions.h:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/bin/.example.info:
      • Added: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Modified: 330b258db8a67f22a225b82a2054d67301e93b6b, b2f7abf2bbd8c0cd6cfe4d1c6ed4816cb8c9264d, 66bcf47b40904a27fa7da414d9435cdba476617a
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/bin/nextweek.sub:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Deleted: 09835e5a05b23a669152faa15b2e154ccbba4f90
    • getINFO.cc:
      • Added: 746adeacb9ffd393d66e89048988bc01a4cfabc0
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/test/example.json:
      • Added: 14a56a7f51ba88bcdc6b2dd9832ad2107f9a888d
      • Modified: af825f6cd7ffac21377d35fabdce8ce508f26757
      • Deleted: 0517b8fa3797eb1c7893d54ddf94666626563a43
    • Alignment/OfflineValidation/test/test_PVsingleAndmerge.sh:
      • Added: c043926f27900c494a992f34ca06e3b2e067a93b
      • Modified: fdb4af28e2c8598583f000e8d18a45f9edd78d0b, 10f486a95623483cefbd85fcd24af95a9d6edd20
      • Deleted: 5d70fb82c88c0edb8df00da375d26f5aa5ddccc3
    • Alignment/OfflineValidation/test/exampleDMR_ReReco.json:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/test/testDMR_ReReco_cfg.py:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/test/test_DMRmerge.sh:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: 5d70fb82c88c0edb8df00da375d26f5aa5ddccc3
    • DAG.cc:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 97ec22969460fb75592dd62a807f57f7f1840d62, 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, ced079b4cdd6c707f35849f356587642775aab85, 79ff3b5d6bd7c8d6cdf17b0b01e5fa646d33bb9b, fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621, c62522afb36d4ffb4267fe82bab3983df3305a9e
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/bin/.gitignore:
      • Added: cdaf73dc76e1221ef5bce275f9af77a68be33138
      • Modified: b2f7abf2bbd8c0cd6cfe4d1c6ed4816cb8c9264d
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/test/exampleDMR_ULRun2.json:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/bin/validateAlignment.cc:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Modified: dcabe7e35286c63a0cf5ef6f45da4e16c639a4ef
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Options.h:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 746adeacb9ffd393d66e89048988bc01a4cfabc0
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/bin/example.cc:
      • Added: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/test/testDMR_ULRun2_and_ReReco.yaml:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Modified: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/test/testDMR_ULRun2_cfg.py:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Modified: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/interface/outTrends.h:
      • Added: 886ecf9d253da78c7704ca0f8929c72e232585a2
      • Modified: d8f3d324f349f5e9e9f16c9a66b2806adbdd5eb7
      • Deleted: 2894f7e58d4c6fd71cfd8c44b9ec0cc1e09e450a
    • Makefile:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 97ec22969460fb75592dd62a807f57f7f1840d62, 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, 229c8b8f244a05dfcb0000fa2d78a36fdb38a8e0, c62522afb36d4ffb4267fe82bab3983df3305a9e
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • nextweek.sub:
      • Added: fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • single.cc:
      • Added: 97ec22969460fb75592dd62a807f57f7f1840d62
      • Modified: 15f3721967cf605888275ca38d1dfe3452ea50b7
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • README.md:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 97ec22969460fb75592dd62a807f57f7f1840d62, 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621, c62522afb36d4ffb4267fe82bab3983df3305a9e
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/test/PVtrends.yaml:
      • Added: 886ecf9d253da78c7704ca0f8929c72e232585a2
      • Modified: 5578202f7c4c2338a20b7c37e29a72bd2c351de8
      • Deleted: 85feaf1e41ab487cee19deebca115ab49a3cec16
    • Alignment/OfflineValidation/test/test_GCPfull.sh:
      • Added: d88a4fe191014639c22e3a65d678353115bc7bac
      • Modified: 2a7352a8d693c0768673b3e0123a62530f34ec26, e9d411fd1fa99d98733eb6e4c0c366b16f97b2eb
      • Deleted: 5d70fb82c88c0edb8df00da375d26f5aa5ddccc3
    • Alignment/OfflineValidation/bin/getINFO.cc:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Modified: 0ddb6d8f7e1afd71caa94b682b036ac96366d614, 0aa8dbd2e894b915a6f5f9b845eefb3036e7ebd9
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/scripts/GCP:
      • Added: 66bcf47b40904a27fa7da414d9435cdba476617a
      • Deleted: f29bb254fdac20a3b4be6c29e2aa6912b47ae210
    • Alignment/OfflineValidation/test/exampleDMR_ReReco.yaml:
      • Added: fa8139dc110431813070354bb779554ff94bf76c
      • Deleted: b4cd12bf1a720fa483700585d5056e13c2636af1
    • Alignment/OfflineValidation/bin/GeometryComparisonPlotter.h:
      • Added: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Modified: 09835e5a05b23a669152faa15b2e154ccbba4f90, 309a1fa3e3ef9421a6f1abf4bf198735152c4f13
      • Deleted: f29bb254fdac20a3b4be6c29e2aa6912b47ae210
    • DAG.h:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 97ec22969460fb75592dd62a807f57f7f1840d62, 15f3721967cf605888275ca38d1dfe3452ea50b7, ced079b4cdd6c707f35849f356587642775aab85, fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621, c62522afb36d4ffb4267fe82bab3983df3305a9e
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/bin/single.cc:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Deleted: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
    • Alignment/OfflineValidation/test/PV_test.yaml:
      • Added: 42532a9231191bfe68af533c0e8042eef4c2d9a9
      • Deleted: 0517b8fa3797eb1c7893d54ddf94666626563a43
    • Alignment/OfflineValidation/bin/DAG.h:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3
      • Modified: dcabe7e35286c63a0cf5ef6f45da4e16c639a4ef, 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Deleted: 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Options.cc:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • example.info:
      • Added: 3b8a9787d3488a9d5d44438e7158272f10639cbe
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • Alignment/OfflineValidation/bin/.defaultWithCMSRun.sub:
      • Added: a119d6e3fc2df40cfe33fb1f619e424c092786c1
      • Deleted: dba64540e36ec5879cca34d5fcc0fdb44040907f
    • Alignment/OfflineValidation/test/test_DMRsingleAndmerge.sh:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Modified: fa8139dc110431813070354bb779554ff94bf76c, 48e4e4d7e65b53d3d65613a0d26ca904b8f87ac8, 57d51a9f2e313f7eb61fc8e69abe05cc600969d8
      • Deleted: 5d70fb82c88c0edb8df00da375d26f5aa5ddccc3
    • toolbox.h:
      • Added: 746adeacb9ffd393d66e89048988bc01a4cfabc0
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • default.sub:
      • Added: fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621
      • Deleted: 08e458f96605f3ee021102dbcf68b2062139dde3
    • config.info:
      • Added: a6f9b24401dbfe1113f0e7092e073a2f59d9504d
      • Modified: 97ec22969460fb75592dd62a807f57f7f1840d62, 15f3721967cf605888275ca38d1dfe3452ea50b7, 746adeacb9ffd393d66e89048988bc01a4cfabc0, ced079b4cdd6c707f35849f356587642775aab85, 79ff3b5d6bd7c8d6cdf17b0b01e5fa646d33bb9b, fd6b5f988f8d2e29ff7cc427c9ea9ecd6011c621, c62522afb36d4ffb4267fe82bab3983df3305a9e
      • Deleted: 3b8a9787d3488a9d5d44438e7158272f10639cbe
    • Alignment/OfflineValidation/test/test.yaml:
      • Added: 8069201951698707d2a2b3d526f56349290d4c5a
      • Deleted: 0517b8fa3797eb1c7893d54ddf94666626563a43
    • Alignment/OfflineValidation/test/testDMRmerge.json:
      • Added: 143a9d1f4a4a73fbbae83152b6971dd42a07444b
      • Deleted: fa8139dc110431813070354bb779554ff94bf76c
    • Alignment/OfflineValidation/bin/GeometryComparisonPlotter.cc:
      • Added: 0ddb6d8f7e1afd71caa94b682b036ac96366d614
      • Modified: 09835e5a05b23a669152faa15b2e154ccbba4f90, 309a1fa3e3ef9421a6f1abf4bf198735152c4f13
      • Deleted: f29bb254fdac20a3b4be6c29e2aa6912b47ae210
    • Alignment/OfflineValidation/bin/example.info:
      • Added: 08e458f96605f3ee021102dbcf68b2062139dde3, b2f7abf2bbd8c0cd6cfe4d1c6ed4816cb8c9264d
      • Deleted: 0ddb6d8f7e1afd71caa94b682b036ac96366d614, 6ed63de75f71c7a04c54419b21f4b8441b7922e6
    • Alignment/OfflineValidation/bin/example.yaml:
      • Added: 275f5e0ebbd0092ca30f6da75880e46f005b5ac6
      • Deleted: 14a56a7f51ba88bcdc6b2dd9832ad2107f9a888d

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File .gitignore modified in PR(s): #30594

cmsbuild avatar Jul 11 '22 22:07 cmsbuild

Pull request #38304 was updated. @connorpa, @yuanchao, @smuzaffar, @makortel, @malbouis, @cmsbuild, @Dr15Jones, @tsusa, @mmusich, @tvami, @ChrisMisan, @francescobrivio can you please check and sign again.

cmsbuild avatar Jul 11 '22 22:07 cmsbuild

@cmsbuild, please test

TomasKello avatar Jul 11 '22 23:07 TomasKello

please test

mmusich avatar Jul 12 '22 04:07 mmusich

-1

Failed Tests: UnitTests Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-578721/26156/summary.html COMMIT: 9432f45ed84869c7bb83214049dae639dacaeb58 CMSSW: CMSSW_12_5_X_2022-07-11-2300/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38304/26156/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test GCPall had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3655970
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3655934
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jul 12 '22 10:07 cmsbuild