cmssw
cmssw copied to clipboard
cms-sw
instability in the runMETCorrectionsAndUncertainties
The functions for the METcorrectiona and uncertainties as defined here PhysicsTools/PatUtils/python/tools/runMETCorrectionsAndUncertainties.py are used both in the nano and mini.
It was observed in https://github.com/cms-sw/cmssw/pull/32328#issue-529226128 that we have some problem with the scheduling of the modules.
For the moment we have just switched off the genmatching as the puppi-jets are not stored. Should be properly addressed.
If possible the tool should be simplified as much as possible.
Update on the aug30: the tools is enable to support the mini and nano with the same job. Typical error example is in https://github.com/cms-sw/cmssw/pull/34714#issue-700979113 This means all the "Sequences" should be translated to the "Tasks"
A new Issue was created by @mariadalfonso .
@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.
cms-bot commands are listed here
New categories assigned: xpog,reconstruction
@slava77,@fgolf,@mariadalfonso,@perrotta,@jpata,@gouskos you have been requested to review this Pull request/Issue and eventually sign? Thanks
For the record, the issue seems related with the definition of patJetPartons here https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/jets_cff.py#L609-L614 and its call: https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/jets_cff.py#L752
This conflicts with another definition through the addJetCollection function (when MC information is switched on): https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/nano_cff.py#L232
@lathomas @kirschen
Please have a look at this issue. It affects the genMatching when you reclusters jets.
hello JME. any news on this item reported December last year ?
probably I fixed, but you have to check https://github.com/cms-sw/cmssw/pull/34661/files#diff-377770d6a7d4705da48aa96709bdedefcb42d5b5497c85ba41a3f11074c148a0
hello JME. any news on this item reported December last year ?
probably I fixed, but you have to check https://github.com/cms-sw/cmssw/pull/34661/files#diff-377770d6a7d4705da48aa96709bdedefcb42d5b5497c85ba41a3f11074c148a0
For the record the trick of setting the following is still needed otherwise the MC matching is called also in the data sequence process.patJetsPuppi.addGenPartonMatch = cms.bool(False) process.patJetsPuppi.addGenJetMatch = cms.bool(False)
@michaelwassmer @dvannerom @mcremone @alkaloge @alefisico @camclean @laurenhay @nurfikri89 @abenecke @lathomas FYI
Is this still relevant? Maybe it makes more sense to revisit this as soon as https://github.com/michaelwassmer/cmssw/tree/CMSSW_12_0_0_ReworkMETCors is ready, because this PR tries to get rid of all the sequences and replaces them by tasks (as demanded by the first post of this thread).
@michaelwassmer ; has the branch CMSSW_12_0_0_ReworkMETCors made it in to a PR that you could reference here ?
@vlimant Not yet. My latest state on this is here: https://github.com/michaelwassmer/cmssw/tree/CMSSW_12_3_4_patch1_ReworkMETCors I think I just need to get started on the rebasing of this branch into master and then create a PR. I'll try to get this done in the next 1-2 weeks.
Sorry for the delay. It's on my to-do list with a high priority. @vlimant I created the PR, see https://github.com/cms-sw/cmssw/pull/40002.
@michaelwassmer do you confirm #40002 solves all the issues reported in this ticket, and we can close it now?
@swertz At least three of the workflows mentioned there (10224.15, 11024.15, 25202.15) worked in my local setup without a problem. The other wf (136.72413) still showed a problem, but I don't think that's related to the scheduling of modules but one of the modules is somehow overwritten while being used elsewhere. I can have a look at that.