cmssw Refactoring gen weight storage in EDM + Nano integration

PR description:

This PR introduces new weight products to hold the Meta Info of the weights, and the weights themselves, organized into groups of a given type (Scale, Pdf, MEParam, etc.)

This has been presented several times in GEN and X-POG, such as https://indico.cern.ch/event/944653/#5-status-of-new-data-structure

The structure of the products is in place. We are still finalizing the NanoAOD integration and testing for parsing corner cases. We expect these tests to be wrapped up in a couple of weeks, but because of the scale of the changes, it would be useful to have feedback already (I'm sure there will be lost of coding suggestions).

This builds on the work of several people, including @dteague @sroychow @guitargeek @cericeci

@agrohsje and @kpedro88 have contributed to the design and review.

PR validation:

We have validated MiniAOD --> NanoAOD, adding products to the event, and GEN-->NanoAOD instantiating products to files. A large testing campaign will take place before NanoAOD v9 and we will report the status here.

NanoAOD and MiniAOD file type size changes

The size of the Nano will in general not be changed, by default the same number of PDF and scale weights are stored. The main change is to make the selection of weights to be stored much more convenient, significantly reduce the number of samples where the weights are not found and not stored (makes those individual samples larger but not a big impact on the average), and provides features for keeping more weights in private production.

The change in size of the MiniAOD will depend on the strategy we adopt, which I'd like a bit more feedback on. If we duplicate the event weight information, it is a 10% increase. I assume this is not under consideration. If we zero the weights in the existing product (produce a new LHEEventProduct with only the central weight for example), the change will be negligible. If we only ever produce the product on the fly the size change will be 0.

Perhaps a good option would be to keep the duplicate product at the gen data tier, and zero it out at the MiniAOD step. This requires fixing code that depends on the weights in the LHEEventProduct (Rivet, for example, https://github.com/cms-sw/cmssw/blob/master/GeneratorInterface/RivetInterface/plugins/RivetAnalyzer.cc, but the change is straightforward) and in updating the name of the LHEEventProduct anywhere it is read if it is produced by a new producer (copy previous with zeroed weights). I guess this could be tedious.

Nov 17 '20 21:11 kdlong

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32167/19876

ERROR: Build errors found during clang-tidy run.

  ^~~~~~~
  kCounter
--
PhysicsTools/NanoAOD/plugins/GenWeightsTableProducer.cc:1234:10: error: member reference base type 'EDataType' is not a structure or union [clang-diagnostic-error]
  counter.incGenOnly(genWeight);
         ^
PhysicsTools/NanoAOD/plugins/GenWeightsTableProducer.cc:1236:30: error: use of undeclared identifier 'streamCache' [clang-diagnostic-error]
  std::string& model_label = streamCache(id)->getLabel();
                             ^
PhysicsTools/NanoAOD/plugins/GenWeightsTableProducer.cc:1247:21: error: use of undeclared identifier 'genWeightToken_' [clang-diagnostic-error]
  iEvent.getByToken(genWeightToken_, genWeightHandle);
                    ^
PhysicsTools/NanoAOD/plugins/GenWeightsTableProducer.cc:1249:20: warning: the variable 'genWeights' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference [performance-unnecessary-copy-initialization]
--
PhysicsTools/NanoAOD/plugins/GenWeightsTableProducer.cc:1251:30: error: use of undeclared identifier 'luminosityBlockCache' [clang-diagnostic-error]
  auto const& weightInfos = *luminosityBlockCache(iEvent.getLuminosityBlock().index());
                             ^
PhysicsTools/NanoAOD/plugins/GenWeightsTableProducer.cc:1257:19: error: use of undeclared identifier 'weightTypeNames_' [clang-diagnostic-error]
  for (auto& wg : weightTypeNames_) {
                  ^
SimDataFormats/GeneratorProducts/interface/LHEEventProduct.h:30:38: warning: use std::make_unique instead [modernize-make-unique]
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

Nov 17 '20 21:11 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32167/19879

ERROR: Build errors found during clang-tidy run.

Suppressed 1252 warnings (1251 in non-user code, 1 with check filters).
--
SimDataFormats/GeneratorProducts/interface/LHEEventProduct.h:30:45: error: no member named 'makemake_unique' in namespace 'std' [clang-diagnostic-error]
  void setPDF(const PDF &pdf) { pdf_ = std::makemake_unique > (pdf); }
                                            ^
Suppressed 1439 warnings (1438 in non-user code, 1 with check filters).
--
SimDataFormats/GeneratorProducts/interface/LHEEventProduct.h:30:45: error: no member named 'makemake_unique' in namespace 'std' [clang-diagnostic-error]
  void setPDF(const PDF &pdf) { pdf_ = std::makemake_unique > (pdf); }
                                            ^
Suppressed 1601 warnings (1600 in non-user code, 1 with check filters).
--
SimDataFormats/GeneratorProducts/interface/LHEEventProduct.h:30:45: error: no member named 'makemake_unique' in namespace 'std' [clang-diagnostic-error]
  void setPDF(const PDF &pdf) { pdf_ = std::makemake_unique > (pdf); }
                                            ^
Suppressed 1744 warnings (1742 in non-user code, 2 with check filters).
--
SimDataFormats/GeneratorProducts/interface/LHEEventProduct.h:30:45: error: no member named 'makemake_unique' in namespace 'std' [clang-diagnostic-error]
  void setPDF(const PDF &pdf) { pdf_ = std::makemake_unique > (pdf); }
                                            ^
Suppressed 1849 warnings (1847 in non-user code, 2 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

Nov 17 '20 22:11 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32167/19884

This PR adds an extra 904KB to repository
Found files with invalid states:
- testFiles/W1jet_260_weight_info.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- testFiles/overview.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- TestWeightInfo/TestAnalyzer/test/test_catch2_TestAnalyzer.cc:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- PhysicsTools/NanoAOD/python/lheWeightsTable_cfi.py:
  - Added: a073bf035eb793147ec0dd90075c32b1bdb6c8ef
  - Deleted: 48fcabd86936600d60a9957c591819f952e068af
- testFiles/WJ_NNLOPS_weightinfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- SimDataFormats/GeneratorProducts/src/LHEWeightInfoProduct.cc:
  - Added: 7cfc2feb0447c7f9c6f87ce2a3f402aa1c3ee7e7
  - Modified: 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c, 23bee6651a368d039c37fa89cfa9a231f03b02dd, 0ba28e0e82f8b6ae52dde4a2cc9bdea0f48e033d, 5668f0da242c77aa8e6a38aa25d59e9263d500cd, ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: c535b5555a10d4e577de6348a79fe364f4d4a572
- GeneratorInterface/LHEInterface/interface/TestWeightInfo.h:
  - Added: 444dbc3d3924c325ca58144515c988d9874862c8
  - Modified: 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c, 23bee6651a368d039c37fa89cfa9a231f03b02dd, 0ba28e0e82f8b6ae52dde4a2cc9bdea0f48e033d, 9ba9510ed189b63a00d1e489cb8fa6e147605e18, 8397fca6352d6d36297683c2d6dcc9400a035a60, 8fcc2305c2f0c46e180f9acb8e641640d0b024bb
  - Deleted: 9bd87c7b4ddfb64cb93fc814b580458197132ac9
- testFiles/ZZTo4L_powheg_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/Core/test/testLHEWeightProducer_cfg.py:
  - Added: b6e3285ab650f7c00ea64adcada148c9121de778
  - Modified: ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: 176adbfe905a4c7c7503856b77cb7ba617aabe67
- testFiles/susyweights.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/Core/test/testGenWeights_simpleZanalyzer_cfg.py:
  - Added: d307670532843a19d40b326ed6676f918c46c92e
  - Modified: bbdd4626eed90e045dfdc0a1826da10673187d4a
  - Deleted: 884dc84cf36c5578e59c7300e2f63c11403f07b2
- testFiles/DrellYan_NLO_MGFXFXv242_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- Test/Test/src/classes_def.xml:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- TestWeightInfo/TestAnalyzer/test/test_cfg.py:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Modified: b6e3285ab650f7c00ea64adcada148c9121de778
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- SimDataFormats/GeneratorProducts/interface/LHEWeightInfoProduct.h:
  - Added: 208a4a32607492d78c629c5878a9d8112b014c11
  - Modified: 0a8810ee2870d5109feecef3c19dbd2e4a97c77f, 7cfc2feb0447c7f9c6f87ce2a3f402aa1c3ee7e7, 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c, 23bee6651a368d039c37fa89cfa9a231f03b02dd, 0ba28e0e82f8b6ae52dde4a2cc9bdea0f48e033d, 5668f0da242c77aa8e6a38aa25d59e9263d500cd, ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: c535b5555a10d4e577de6348a79fe364f4d4a572
- GeneratorInterface/Core/interface/LHEWeightGroupReaderHelper.h:
  - Added: 682ac14c6bc1d726141403970a70a4ed97d9fc82
  - Deleted: 037f6f9cd0508d68aa8e262e93ebe496da00137e
- testFiles/DrellYan_NLO_MGFXFXv233_2016_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/interface/LHEWeightGroupReaderHelper.h:
  - Added: 071c069ce03bd33257f30f205694fdd8b39c881a
  - Modified: 6bfea57af6dd3765ccb06147daa8491e40568964, f62468c7e64b1d83c0d30df79754e27332d847f5, 28f0ba2f3ff4d69e3fa10b1d6c3a78925965e666, 71629cd0b87c58911e047368aa45d2bd3393df06, c98a07826f18351a74c30e47c31e1f078e129487, 1c1da7637d6c910ab5b99eca20a2a59e42a030c8, 80cde77e1e419d54a1ec19c5f7bdc91b070a010f, 33e246685138ddac48d2c72588aa2c82662a941f, 9baeee20d3686431d22a290965c55a95fcfbda87, f1a3ae406e49d6c904e27d83efa3050452aeb96b
  - Deleted: 682ac14c6bc1d726141403970a70a4ed97d9fc82
- Test/Test/BuildFile.xml:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- SimDataFormats/GeneratorProducts/interface/LHEWeightProduct.h:
  - Added: 208a4a32607492d78c629c5878a9d8112b014c11
  - Modified: 444dbc3d3924c325ca58144515c988d9874862c8, 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c
  - Deleted: c535b5555a10d4e577de6348a79fe364f4d4a572
- GeneratorInterface/LHEInterface/test/testWeights.py:
  - Added: df8416421345ba3a7e3d920edc30c914ad7d7cf2
  - Modified: 5668f0da242c77aa8e6a38aa25d59e9263d500cd, 8c0c98e491fced903b41919d38e4336fbd963f74, b6e3285ab650f7c00ea64adcada148c9121de778, c535b5555a10d4e577de6348a79fe364f4d4a572, acc3817b6f810b8f2fdd40e0c0c66ed86d989a13, a30dacf9518651c94a251e3ff3c8f4d7a46f4ad3
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- TestWeightInfo/TestAnalyzer/plugins/TestAnalyzer.cc:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Modified: 07eb97abc8336ed0006db49d6a46c6b229ac2d8f, c535b5555a10d4e577de6348a79fe364f4d4a572
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- testFiles/DrellYan_LO_MGMLMv233_2016_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/test/test_Weights_cfg.py:
  - Added: df8416421345ba3a7e3d920edc30c914ad7d7cf2
  - Modified: 59691bc6a647eef22e57ed248fa4d9a0d9520a8a, 33e246685138ddac48d2c72588aa2c82662a941f, 1038e0df4d60d1679b531d77e3c243e0e4253987, f1a3ae406e49d6c904e27d83efa3050452aeb96b, 5668f0da242c77aa8e6a38aa25d59e9263d500cd, b6e3285ab650f7c00ea64adcada148c9121de778, d6c2452601abe4d59950ad790612f187fe2eeb3e
  - Deleted: 8f74a2c0642870ca8f74f1697941b21d160b1e71
- PhysicsTools/NanoAOD/test/nanoGen_test_cfg.py:
  - Added: afe662adbe2679072ca219b6a606c4462962301d
  - Modified: ca22fc5b12d786f48a74678a7fee1a1dd5eb3f10
  - Deleted: 8f74a2c0642870ca8f74f1697941b21d160b1e71
- testFiles/DrellYan_LO_MGMLMv242_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- TestWeightInfo/TestAnalyzer/test/test_catch2_main.cc:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- testFiles/W1jet_260_simplescale_weight_info.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- testFiles/WZVBS_private_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- Test/Test/src/classes.h:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- testFiles/ZJ_MiNNLO_weightinfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- PhysicsTools/NanoAOD/python/genWeightsTable_cfi.py:
  - Added: 45be54a91e93c7aefdfdda3c49dc4135b40e34b2
  - Modified: 8f74a2c0642870ca8f74f1697941b21d160b1e71
  - Deleted: 48fcabd86936600d60a9957c591819f952e068af
- Test/Test/src/test.cc:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- testFiles/WJ_MiNNLO_weightinfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/Core/plugins/GenWeightsTestAnalyzer.cc:
  - Added: d307670532843a19d40b326ed6676f918c46c92e
  - Modified: bbdd4626eed90e045dfdc0a1826da10673187d4a, 8fcc2305c2f0c46e180f9acb8e641640d0b024bb
  - Deleted: 884dc84cf36c5578e59c7300e2f63c11403f07b2
- testFiles/ZZTo4L_powheg_2016_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- SimDataFormats/GeneratorProducts/src/ScaleWeightGroupInfo.h:
  - Added: 9e062713d369cd61c3b0514c98f51515570eb4a1
  - Deleted: f62468c7e64b1d83c0d30df79754e27332d847f5
- TestWeightInfo/TestAnalyzer/test/BuildFile.xml:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- PhysicsTools/NanoAOD/plugins/LHEWeightsTableProducer.cc:
  - Added: 70cdb973eb995bd020db9d8830f0ef53bb3fd043
  - Modified: 205de35015c23df0523b8c1b52c7c857754b3c31, d663d2f5cb2d2b9bf1dbcbe66845b4844a7c34de, 45be54a91e93c7aefdfdda3c49dc4135b40e34b2, 6c5900c5e79cb695aa803c3d6c80ec5efe627601, fb19c05ff6a881b79291269911a376709d20c2c3, ae40865dd6c1a0d3488eba13abf7c6669110867f, e542eaa66bc0cdff977f45bfe3d1aa58647bdb2c, ca22fc5b12d786f48a74678a7fee1a1dd5eb3f10, 8fcc2305c2f0c46e180f9acb8e641640d0b024bb, 3dbdd4c2515791462b43bf4d3f346456a4c366dd, 265e6a0463c2712017d231cafc9db23850c9897c, 6aaef397110c974d83ba52e75c65e5819dd9fc1d, 6ccee5d97cb552ffbad85a773e833fc8e6ef658b, 8c2927e4630a4953f2c726750c15f9994e9a10e4, 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 3180b59bfee7660535dce9e9142ba890c1319b33, 2622c4060c071a2828b44ac284cff3c5eca9aac7, d057424e79f0cd65fe4aa2df693f8abcda5bc521, 0f1a1ac5e9a4226e4c2de24ea7ed5450e8f59fdf, 87330083d1dea5005c284a657eee44c644b61ec0, 20f26343af75c5c1e11df57345c3ffb4c95a938d, a91bdf2d849587546a22f0274b98541fc7e75ecb, 3f41984dbc7fa15c568eb02604c1899534a499ef, a073bf035eb793147ec0dd90075c32b1bdb6c8ef, 8ca625f91f8bfe87dbb6f4313447530596d7df0b, f46cc339bcbe527847695289200daf4b90f0d6cd, 41c79e2f389e640ac0964398bc1440503c9f31b2, 5d2297c253349834740f894dc177a16da3647981, ef90c0377a5a196ebef68aa55467919b5bc9cc13, 34b9c3a91ba6e88ca3c26706963bbc300dff6b13, 5613cf66afec04ccd0f7221251cbb159a2c01a24, 93ecbf8d2d0e6a91bf220e6cd96ffec7ca1be794, 601b0907bf1cc35b17d5506f92a4d2e76281f3f5, 099b683922bf633424d140f0ae15707be4e5ae0e, ae87760c3ce63dd22818b899a604d81691202e97, 882f046b23ac8eaba4737a0b0a2a620bc2d83991, 76b867cb5703d932c5045ce19c2b2143eb588ec0, e1539bafc0216955a0eb013ba844b7e04b45261c, 49b5d2b34fc45cefa325f4915f3799833b8ba119, db98fc424b7930355f4c14c433be2306d962657a
  - Deleted: 48fcabd86936600d60a9957c591819f952e068af
- testFiles/WZVBS_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/test/test_ZPlotting_LHEweights_cfg.py:
  - Added: ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: d307670532843a19d40b326ed6676f918c46c92e
- lhe_test.C:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 8f74a2c0642870ca8f74f1697941b21d160b1e71
- SimDataFormats/GeneratorProducts/src/PartonShowerWeights.cc:
  - Added: 3e4861786d64c142e076e4d6c8b9d20bfd143f9d
  - Modified: 8c2927e4630a4953f2c726750c15f9994e9a10e4, 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, ba5be6c63b9506d23357404c5e532af3ff00ad50
  - Deleted: 21e251a44c9fe184bab891e81b101ce763f92494
- TestWeightInfo/TestAnalyzer/plugins/BuildFile.xml:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- Test/Test/interface/test.h:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- testFiles/ZMiNNLO.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/plugins/LHEWeightsTest.cc:
  - Added: c82792f33130092fba6fa07871218dadcdbcb830
  - Modified: ffd0503039329ada0dc9713ba88ef6b83dfcf8ed, c535b5555a10d4e577de6348a79fe364f4d4a572, 27a923953edc24c3909ee96ffcc59c48150d3625, 7402487d89a5c1d1dd40bda529e4d0089bc5b4e6, b744a77cacdc520c1d7da23ead44966c5ddc6e99
  - Deleted: d307670532843a19d40b326ed6676f918c46c92e
- testFiles/VVV_2017_weight_info.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/plugins/NanoAODOutputModule.cc modified in PR(s): #31531
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): #31531

Nov 18 '20 08:11 cmsbuild

A new Pull Request was created by @kdlong (Kenneth Long) for master.

It involves the following packages:

DataFormats/NanoAOD GeneratorInterface/Core GeneratorInterface/LHEInterface PhysicsTools/NanoAOD SimDataFormats/GeneratorProducts

@SiewYan, @perrotta, @gouskos, @mkirsano, @cmsbuild, @jpata, @fgolf, @slava77, @alberto-sanchez, @agrohsje, @mariadalfonso, @santocch, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. @mkirsano, @swertz, @rovere, @peruzzim, @apsallid, @lecriste, @alberto-sanchez, @gpetruc, @fabiocos this is something you requested to watch as well. @silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Nov 18 '20 08:11 cmsbuild

please test

Nov 18 '20 14:11 kpedro88

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-11-17-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10838/console Started: 2020/11/18 15:01

Nov 18 '20 14:11 cmsbuild

-1

Tested at: 45323bb8e501e9132b8ede0a5289873ec2429a22

CMSSW: CMSSW_11_2_X_2020-11-17-2300 SCRAM_ARCH: slc7_amd64_gcc820 You can see the results of the tests here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3df97d/10838/summary.html

I found follow errors while testing this PR

Failed tests: HeaderConsistency ClangBuild

Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

Nov 18 '20 15:11 cmsbuild

Comparison job queued.

Nov 18 '20 15:11 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32167/19898

This PR adds an extra 32KB to repository
Found files with invalid states:
- testFiles/W1jet_260_weight_info.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- testFiles/overview.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- TestWeightInfo/TestAnalyzer/test/test_catch2_TestAnalyzer.cc:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- PhysicsTools/NanoAOD/python/lheWeightsTable_cfi.py:
  - Added: a073bf035eb793147ec0dd90075c32b1bdb6c8ef
  - Deleted: 48fcabd86936600d60a9957c591819f952e068af
- testFiles/WJ_NNLOPS_weightinfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- SimDataFormats/GeneratorProducts/src/LHEWeightInfoProduct.cc:
  - Added: 7cfc2feb0447c7f9c6f87ce2a3f402aa1c3ee7e7
  - Modified: 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c, 23bee6651a368d039c37fa89cfa9a231f03b02dd, 0ba28e0e82f8b6ae52dde4a2cc9bdea0f48e033d, 5668f0da242c77aa8e6a38aa25d59e9263d500cd, ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: c535b5555a10d4e577de6348a79fe364f4d4a572
- GeneratorInterface/LHEInterface/interface/TestWeightInfo.h:
  - Added: 444dbc3d3924c325ca58144515c988d9874862c8
  - Modified: 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c, 23bee6651a368d039c37fa89cfa9a231f03b02dd, 0ba28e0e82f8b6ae52dde4a2cc9bdea0f48e033d, 9ba9510ed189b63a00d1e489cb8fa6e147605e18, 8397fca6352d6d36297683c2d6dcc9400a035a60, 8fcc2305c2f0c46e180f9acb8e641640d0b024bb
  - Deleted: 9bd87c7b4ddfb64cb93fc814b580458197132ac9
- testFiles/ZZTo4L_powheg_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/Core/test/testLHEWeightProducer_cfg.py:
  - Added: b6e3285ab650f7c00ea64adcada148c9121de778
  - Modified: ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: 176adbfe905a4c7c7503856b77cb7ba617aabe67
- testFiles/susyweights.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/Core/test/testGenWeights_simpleZanalyzer_cfg.py:
  - Added: d307670532843a19d40b326ed6676f918c46c92e
  - Modified: bbdd4626eed90e045dfdc0a1826da10673187d4a
  - Deleted: 884dc84cf36c5578e59c7300e2f63c11403f07b2
- testFiles/DrellYan_NLO_MGFXFXv242_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- Test/Test/src/classes_def.xml:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- TestWeightInfo/TestAnalyzer/test/test_cfg.py:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Modified: b6e3285ab650f7c00ea64adcada148c9121de778
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- SimDataFormats/GeneratorProducts/interface/LHEWeightInfoProduct.h:
  - Added: 208a4a32607492d78c629c5878a9d8112b014c11
  - Modified: 0a8810ee2870d5109feecef3c19dbd2e4a97c77f, 7cfc2feb0447c7f9c6f87ce2a3f402aa1c3ee7e7, 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c, 23bee6651a368d039c37fa89cfa9a231f03b02dd, 0ba28e0e82f8b6ae52dde4a2cc9bdea0f48e033d, 5668f0da242c77aa8e6a38aa25d59e9263d500cd, ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: c535b5555a10d4e577de6348a79fe364f4d4a572
- GeneratorInterface/Core/interface/LHEWeightGroupReaderHelper.h:
  - Added: 682ac14c6bc1d726141403970a70a4ed97d9fc82
  - Deleted: 037f6f9cd0508d68aa8e262e93ebe496da00137e
- testFiles/DrellYan_NLO_MGFXFXv233_2016_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/interface/LHEWeightGroupReaderHelper.h:
  - Added: 071c069ce03bd33257f30f205694fdd8b39c881a
  - Modified: 6bfea57af6dd3765ccb06147daa8491e40568964, f62468c7e64b1d83c0d30df79754e27332d847f5, 28f0ba2f3ff4d69e3fa10b1d6c3a78925965e666, 71629cd0b87c58911e047368aa45d2bd3393df06, c98a07826f18351a74c30e47c31e1f078e129487, 1c1da7637d6c910ab5b99eca20a2a59e42a030c8, 80cde77e1e419d54a1ec19c5f7bdc91b070a010f, 33e246685138ddac48d2c72588aa2c82662a941f, 9baeee20d3686431d22a290965c55a95fcfbda87, f1a3ae406e49d6c904e27d83efa3050452aeb96b
  - Deleted: 682ac14c6bc1d726141403970a70a4ed97d9fc82
- Test/Test/BuildFile.xml:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- SimDataFormats/GeneratorProducts/interface/LHEWeightProduct.h:
  - Added: 208a4a32607492d78c629c5878a9d8112b014c11
  - Modified: 444dbc3d3924c325ca58144515c988d9874862c8, 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c
  - Deleted: c535b5555a10d4e577de6348a79fe364f4d4a572
- GeneratorInterface/LHEInterface/test/testWeights.py:
  - Added: df8416421345ba3a7e3d920edc30c914ad7d7cf2
  - Modified: 5668f0da242c77aa8e6a38aa25d59e9263d500cd, 8c0c98e491fced903b41919d38e4336fbd963f74, b6e3285ab650f7c00ea64adcada148c9121de778, c535b5555a10d4e577de6348a79fe364f4d4a572, acc3817b6f810b8f2fdd40e0c0c66ed86d989a13, a30dacf9518651c94a251e3ff3c8f4d7a46f4ad3
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- TestWeightInfo/TestAnalyzer/plugins/TestAnalyzer.cc:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Modified: 07eb97abc8336ed0006db49d6a46c6b229ac2d8f, c535b5555a10d4e577de6348a79fe364f4d4a572
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- testFiles/DrellYan_LO_MGMLMv233_2016_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/test/test_Weights_cfg.py:
  - Added: df8416421345ba3a7e3d920edc30c914ad7d7cf2
  - Modified: 59691bc6a647eef22e57ed248fa4d9a0d9520a8a, 33e246685138ddac48d2c72588aa2c82662a941f, 1038e0df4d60d1679b531d77e3c243e0e4253987, f1a3ae406e49d6c904e27d83efa3050452aeb96b, 5668f0da242c77aa8e6a38aa25d59e9263d500cd, b6e3285ab650f7c00ea64adcada148c9121de778, d6c2452601abe4d59950ad790612f187fe2eeb3e
  - Deleted: 8f74a2c0642870ca8f74f1697941b21d160b1e71
- PhysicsTools/NanoAOD/test/nanoGen_test_cfg.py:
  - Added: afe662adbe2679072ca219b6a606c4462962301d
  - Modified: ca22fc5b12d786f48a74678a7fee1a1dd5eb3f10
  - Deleted: 8f74a2c0642870ca8f74f1697941b21d160b1e71
- testFiles/DrellYan_LO_MGMLMv242_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- TestWeightInfo/TestAnalyzer/test/test_catch2_main.cc:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- testFiles/W1jet_260_simplescale_weight_info.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- testFiles/WZVBS_private_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- Test/Test/src/classes.h:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- testFiles/ZJ_MiNNLO_weightinfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- PhysicsTools/NanoAOD/python/genWeightsTable_cfi.py:
  - Added: 45be54a91e93c7aefdfdda3c49dc4135b40e34b2
  - Modified: 8f74a2c0642870ca8f74f1697941b21d160b1e71
  - Deleted: 48fcabd86936600d60a9957c591819f952e068af
- Test/Test/src/test.cc:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- testFiles/WJ_MiNNLO_weightinfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/Core/plugins/GenWeightsTestAnalyzer.cc:
  - Added: d307670532843a19d40b326ed6676f918c46c92e
  - Modified: bbdd4626eed90e045dfdc0a1826da10673187d4a, 8fcc2305c2f0c46e180f9acb8e641640d0b024bb
  - Deleted: 884dc84cf36c5578e59c7300e2f63c11403f07b2
- testFiles/ZZTo4L_powheg_2016_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- SimDataFormats/GeneratorProducts/src/ScaleWeightGroupInfo.h:
  - Added: 9e062713d369cd61c3b0514c98f51515570eb4a1
  - Deleted: f62468c7e64b1d83c0d30df79754e27332d847f5
- TestWeightInfo/TestAnalyzer/test/BuildFile.xml:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- PhysicsTools/NanoAOD/plugins/LHEWeightsTableProducer.cc:
  - Added: 70cdb973eb995bd020db9d8830f0ef53bb3fd043
  - Modified: 205de35015c23df0523b8c1b52c7c857754b3c31, d663d2f5cb2d2b9bf1dbcbe66845b4844a7c34de, 45be54a91e93c7aefdfdda3c49dc4135b40e34b2, 6c5900c5e79cb695aa803c3d6c80ec5efe627601, fb19c05ff6a881b79291269911a376709d20c2c3, ae40865dd6c1a0d3488eba13abf7c6669110867f, e542eaa66bc0cdff977f45bfe3d1aa58647bdb2c, ca22fc5b12d786f48a74678a7fee1a1dd5eb3f10, 8fcc2305c2f0c46e180f9acb8e641640d0b024bb, 3dbdd4c2515791462b43bf4d3f346456a4c366dd, 265e6a0463c2712017d231cafc9db23850c9897c, 6aaef397110c974d83ba52e75c65e5819dd9fc1d, 6ccee5d97cb552ffbad85a773e833fc8e6ef658b, 8c2927e4630a4953f2c726750c15f9994e9a10e4, 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 3180b59bfee7660535dce9e9142ba890c1319b33, 2622c4060c071a2828b44ac284cff3c5eca9aac7, d057424e79f0cd65fe4aa2df693f8abcda5bc521, 0f1a1ac5e9a4226e4c2de24ea7ed5450e8f59fdf, 87330083d1dea5005c284a657eee44c644b61ec0, 20f26343af75c5c1e11df57345c3ffb4c95a938d, a91bdf2d849587546a22f0274b98541fc7e75ecb, 3f41984dbc7fa15c568eb02604c1899534a499ef, a073bf035eb793147ec0dd90075c32b1bdb6c8ef, 8ca625f91f8bfe87dbb6f4313447530596d7df0b, f46cc339bcbe527847695289200daf4b90f0d6cd, 41c79e2f389e640ac0964398bc1440503c9f31b2, 5d2297c253349834740f894dc177a16da3647981, ef90c0377a5a196ebef68aa55467919b5bc9cc13, 34b9c3a91ba6e88ca3c26706963bbc300dff6b13, 5613cf66afec04ccd0f7221251cbb159a2c01a24, 93ecbf8d2d0e6a91bf220e6cd96ffec7ca1be794, 601b0907bf1cc35b17d5506f92a4d2e76281f3f5, 099b683922bf633424d140f0ae15707be4e5ae0e, ae87760c3ce63dd22818b899a604d81691202e97, 882f046b23ac8eaba4737a0b0a2a620bc2d83991, 76b867cb5703d932c5045ce19c2b2143eb588ec0, e1539bafc0216955a0eb013ba844b7e04b45261c, 49b5d2b34fc45cefa325f4915f3799833b8ba119, db98fc424b7930355f4c14c433be2306d962657a
  - Deleted: 48fcabd86936600d60a9957c591819f952e068af
- testFiles/WZVBS_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/test/test_ZPlotting_LHEweights_cfg.py:
  - Added: ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: d307670532843a19d40b326ed6676f918c46c92e
- lhe_test.C:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 8f74a2c0642870ca8f74f1697941b21d160b1e71
- SimDataFormats/GeneratorProducts/src/PartonShowerWeights.cc:
  - Added: 3e4861786d64c142e076e4d6c8b9d20bfd143f9d
  - Modified: 8c2927e4630a4953f2c726750c15f9994e9a10e4, 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, ba5be6c63b9506d23357404c5e532af3ff00ad50
  - Deleted: 21e251a44c9fe184bab891e81b101ce763f92494
- TestWeightInfo/TestAnalyzer/plugins/BuildFile.xml:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- Test/Test/interface/test.h:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- testFiles/ZMiNNLO.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/plugins/LHEWeightsTest.cc:
  - Added: c82792f33130092fba6fa07871218dadcdbcb830
  - Modified: ffd0503039329ada0dc9713ba88ef6b83dfcf8ed, c535b5555a10d4e577de6348a79fe364f4d4a572, 27a923953edc24c3909ee96ffcc59c48150d3625, 7402487d89a5c1d1dd40bda529e4d0089bc5b4e6, b744a77cacdc520c1d7da23ead44966c5ddc6e99
  - Deleted: d307670532843a19d40b326ed6676f918c46c92e
- testFiles/VVV_2017_weight_info.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/plugins/NanoAODOutputModule.cc modified in PR(s): #31531
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): #31531

Nov 18 '20 17:11 cmsbuild

Pull request #32167 was updated. @SiewYan, @perrotta, @gouskos, @mkirsano, @cmsbuild, @jpata, @fgolf, @slava77, @alberto-sanchez, @agrohsje, @mariadalfonso, @santocch, @GurpreetSinghChahal can you please check and sign again.

Nov 18 '20 17:11 cmsbuild

code-checks

to trigger removal of the reco signature

Nov 19 '20 19:11 slava77

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32167/19916

This PR adds an extra 12KB to repository
Found files with invalid states:
- testFiles/W1jet_260_weight_info.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- testFiles/overview.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- TestWeightInfo/TestAnalyzer/test/test_catch2_TestAnalyzer.cc:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- PhysicsTools/NanoAOD/python/lheWeightsTable_cfi.py:
  - Added: a073bf035eb793147ec0dd90075c32b1bdb6c8ef
  - Deleted: 48fcabd86936600d60a9957c591819f952e068af
- testFiles/WJ_NNLOPS_weightinfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- SimDataFormats/GeneratorProducts/src/LHEWeightInfoProduct.cc:
  - Added: 7cfc2feb0447c7f9c6f87ce2a3f402aa1c3ee7e7
  - Modified: 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c, 23bee6651a368d039c37fa89cfa9a231f03b02dd, 0ba28e0e82f8b6ae52dde4a2cc9bdea0f48e033d, 5668f0da242c77aa8e6a38aa25d59e9263d500cd, ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: c535b5555a10d4e577de6348a79fe364f4d4a572
- GeneratorInterface/LHEInterface/interface/TestWeightInfo.h:
  - Added: 444dbc3d3924c325ca58144515c988d9874862c8
  - Modified: 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c, 23bee6651a368d039c37fa89cfa9a231f03b02dd, 0ba28e0e82f8b6ae52dde4a2cc9bdea0f48e033d, 9ba9510ed189b63a00d1e489cb8fa6e147605e18, 8397fca6352d6d36297683c2d6dcc9400a035a60, 8fcc2305c2f0c46e180f9acb8e641640d0b024bb
  - Deleted: 9bd87c7b4ddfb64cb93fc814b580458197132ac9
- testFiles/ZZTo4L_powheg_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/Core/test/testLHEWeightProducer_cfg.py:
  - Added: b6e3285ab650f7c00ea64adcada148c9121de778
  - Modified: ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: 176adbfe905a4c7c7503856b77cb7ba617aabe67
- testFiles/susyweights.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/Core/test/testGenWeights_simpleZanalyzer_cfg.py:
  - Added: d307670532843a19d40b326ed6676f918c46c92e
  - Modified: bbdd4626eed90e045dfdc0a1826da10673187d4a
  - Deleted: 884dc84cf36c5578e59c7300e2f63c11403f07b2
- testFiles/DrellYan_NLO_MGFXFXv242_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- Test/Test/src/classes_def.xml:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- TestWeightInfo/TestAnalyzer/test/test_cfg.py:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Modified: b6e3285ab650f7c00ea64adcada148c9121de778
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- SimDataFormats/GeneratorProducts/interface/LHEWeightInfoProduct.h:
  - Added: 208a4a32607492d78c629c5878a9d8112b014c11
  - Modified: 0a8810ee2870d5109feecef3c19dbd2e4a97c77f, 7cfc2feb0447c7f9c6f87ce2a3f402aa1c3ee7e7, 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c, 23bee6651a368d039c37fa89cfa9a231f03b02dd, 0ba28e0e82f8b6ae52dde4a2cc9bdea0f48e033d, 5668f0da242c77aa8e6a38aa25d59e9263d500cd, ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: c535b5555a10d4e577de6348a79fe364f4d4a572
- GeneratorInterface/Core/interface/LHEWeightGroupReaderHelper.h:
  - Added: 682ac14c6bc1d726141403970a70a4ed97d9fc82
  - Deleted: 037f6f9cd0508d68aa8e262e93ebe496da00137e
- testFiles/DrellYan_NLO_MGFXFXv233_2016_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/interface/LHEWeightGroupReaderHelper.h:
  - Added: 071c069ce03bd33257f30f205694fdd8b39c881a
  - Modified: 6bfea57af6dd3765ccb06147daa8491e40568964, f62468c7e64b1d83c0d30df79754e27332d847f5, 28f0ba2f3ff4d69e3fa10b1d6c3a78925965e666, 71629cd0b87c58911e047368aa45d2bd3393df06, c98a07826f18351a74c30e47c31e1f078e129487, 1c1da7637d6c910ab5b99eca20a2a59e42a030c8, 80cde77e1e419d54a1ec19c5f7bdc91b070a010f, 33e246685138ddac48d2c72588aa2c82662a941f, 9baeee20d3686431d22a290965c55a95fcfbda87, f1a3ae406e49d6c904e27d83efa3050452aeb96b
  - Deleted: 682ac14c6bc1d726141403970a70a4ed97d9fc82
- Test/Test/BuildFile.xml:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- SimDataFormats/GeneratorProducts/interface/LHEWeightProduct.h:
  - Added: 208a4a32607492d78c629c5878a9d8112b014c11
  - Modified: 444dbc3d3924c325ca58144515c988d9874862c8, 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c
  - Deleted: c535b5555a10d4e577de6348a79fe364f4d4a572
- GeneratorInterface/LHEInterface/test/testWeights.py:
  - Added: df8416421345ba3a7e3d920edc30c914ad7d7cf2
  - Modified: 5668f0da242c77aa8e6a38aa25d59e9263d500cd, 8c0c98e491fced903b41919d38e4336fbd963f74, b6e3285ab650f7c00ea64adcada148c9121de778, c535b5555a10d4e577de6348a79fe364f4d4a572, acc3817b6f810b8f2fdd40e0c0c66ed86d989a13, a30dacf9518651c94a251e3ff3c8f4d7a46f4ad3
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- TestWeightInfo/TestAnalyzer/plugins/TestAnalyzer.cc:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Modified: 07eb97abc8336ed0006db49d6a46c6b229ac2d8f, c535b5555a10d4e577de6348a79fe364f4d4a572
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- testFiles/DrellYan_LO_MGMLMv233_2016_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/test/test_Weights_cfg.py:
  - Added: df8416421345ba3a7e3d920edc30c914ad7d7cf2
  - Modified: 59691bc6a647eef22e57ed248fa4d9a0d9520a8a, 33e246685138ddac48d2c72588aa2c82662a941f, 1038e0df4d60d1679b531d77e3c243e0e4253987, f1a3ae406e49d6c904e27d83efa3050452aeb96b, 5668f0da242c77aa8e6a38aa25d59e9263d500cd, b6e3285ab650f7c00ea64adcada148c9121de778, d6c2452601abe4d59950ad790612f187fe2eeb3e
  - Deleted: 8f74a2c0642870ca8f74f1697941b21d160b1e71
- PhysicsTools/NanoAOD/test/nanoGen_test_cfg.py:
  - Added: afe662adbe2679072ca219b6a606c4462962301d
  - Modified: ca22fc5b12d786f48a74678a7fee1a1dd5eb3f10
  - Deleted: 8f74a2c0642870ca8f74f1697941b21d160b1e71
- testFiles/DrellYan_LO_MGMLMv242_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- TestWeightInfo/TestAnalyzer/test/test_catch2_main.cc:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- testFiles/W1jet_260_simplescale_weight_info.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- testFiles/WZVBS_private_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- Test/Test/src/classes.h:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- testFiles/ZJ_MiNNLO_weightinfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- PhysicsTools/NanoAOD/python/genWeightsTable_cfi.py:
  - Added: 45be54a91e93c7aefdfdda3c49dc4135b40e34b2
  - Modified: 8f74a2c0642870ca8f74f1697941b21d160b1e71
  - Deleted: 48fcabd86936600d60a9957c591819f952e068af
- Test/Test/src/test.cc:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- testFiles/WJ_MiNNLO_weightinfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/Core/plugins/GenWeightsTestAnalyzer.cc:
  - Added: d307670532843a19d40b326ed6676f918c46c92e
  - Modified: bbdd4626eed90e045dfdc0a1826da10673187d4a, 8fcc2305c2f0c46e180f9acb8e641640d0b024bb
  - Deleted: 884dc84cf36c5578e59c7300e2f63c11403f07b2
- testFiles/ZZTo4L_powheg_2016_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- SimDataFormats/GeneratorProducts/src/ScaleWeightGroupInfo.h:
  - Added: 9e062713d369cd61c3b0514c98f51515570eb4a1
  - Deleted: f62468c7e64b1d83c0d30df79754e27332d847f5
- TestWeightInfo/TestAnalyzer/test/BuildFile.xml:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- PhysicsTools/NanoAOD/plugins/LHEWeightsTableProducer.cc:
  - Added: 70cdb973eb995bd020db9d8830f0ef53bb3fd043
  - Modified: 205de35015c23df0523b8c1b52c7c857754b3c31, d663d2f5cb2d2b9bf1dbcbe66845b4844a7c34de, 45be54a91e93c7aefdfdda3c49dc4135b40e34b2, 6c5900c5e79cb695aa803c3d6c80ec5efe627601, fb19c05ff6a881b79291269911a376709d20c2c3, ae40865dd6c1a0d3488eba13abf7c6669110867f, e542eaa66bc0cdff977f45bfe3d1aa58647bdb2c, ca22fc5b12d786f48a74678a7fee1a1dd5eb3f10, 8fcc2305c2f0c46e180f9acb8e641640d0b024bb, 3dbdd4c2515791462b43bf4d3f346456a4c366dd, 265e6a0463c2712017d231cafc9db23850c9897c, 6aaef397110c974d83ba52e75c65e5819dd9fc1d, 6ccee5d97cb552ffbad85a773e833fc8e6ef658b, 8c2927e4630a4953f2c726750c15f9994e9a10e4, 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 3180b59bfee7660535dce9e9142ba890c1319b33, 2622c4060c071a2828b44ac284cff3c5eca9aac7, d057424e79f0cd65fe4aa2df693f8abcda5bc521, 0f1a1ac5e9a4226e4c2de24ea7ed5450e8f59fdf, 87330083d1dea5005c284a657eee44c644b61ec0, 20f26343af75c5c1e11df57345c3ffb4c95a938d, a91bdf2d849587546a22f0274b98541fc7e75ecb, 3f41984dbc7fa15c568eb02604c1899534a499ef, a073bf035eb793147ec0dd90075c32b1bdb6c8ef, 8ca625f91f8bfe87dbb6f4313447530596d7df0b, f46cc339bcbe527847695289200daf4b90f0d6cd, 41c79e2f389e640ac0964398bc1440503c9f31b2, 5d2297c253349834740f894dc177a16da3647981, ef90c0377a5a196ebef68aa55467919b5bc9cc13, 34b9c3a91ba6e88ca3c26706963bbc300dff6b13, 5613cf66afec04ccd0f7221251cbb159a2c01a24, 93ecbf8d2d0e6a91bf220e6cd96ffec7ca1be794, 601b0907bf1cc35b17d5506f92a4d2e76281f3f5, 099b683922bf633424d140f0ae15707be4e5ae0e, ae87760c3ce63dd22818b899a604d81691202e97, 882f046b23ac8eaba4737a0b0a2a620bc2d83991, 76b867cb5703d932c5045ce19c2b2143eb588ec0, e1539bafc0216955a0eb013ba844b7e04b45261c, 49b5d2b34fc45cefa325f4915f3799833b8ba119, db98fc424b7930355f4c14c433be2306d962657a
  - Deleted: 48fcabd86936600d60a9957c591819f952e068af
- testFiles/WZVBS_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/test/test_ZPlotting_LHEweights_cfg.py:
  - Added: ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: d307670532843a19d40b326ed6676f918c46c92e
- lhe_test.C:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 8f74a2c0642870ca8f74f1697941b21d160b1e71
- SimDataFormats/GeneratorProducts/src/PartonShowerWeights.cc:
  - Added: 3e4861786d64c142e076e4d6c8b9d20bfd143f9d
  - Modified: 8c2927e4630a4953f2c726750c15f9994e9a10e4, 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, ba5be6c63b9506d23357404c5e532af3ff00ad50
  - Deleted: 21e251a44c9fe184bab891e81b101ce763f92494
- TestWeightInfo/TestAnalyzer/plugins/BuildFile.xml:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- Test/Test/interface/test.h:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- testFiles/ZMiNNLO.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/plugins/LHEWeightsTest.cc:
  - Added: c82792f33130092fba6fa07871218dadcdbcb830
  - Modified: ffd0503039329ada0dc9713ba88ef6b83dfcf8ed, c535b5555a10d4e577de6348a79fe364f4d4a572, 27a923953edc24c3909ee96ffcc59c48150d3625, 7402487d89a5c1d1dd40bda529e4d0089bc5b4e6, b744a77cacdc520c1d7da23ead44966c5ddc6e99
  - Deleted: d307670532843a19d40b326ed6676f918c46c92e
- testFiles/VVV_2017_weight_info.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/plugins/NanoAODOutputModule.cc modified in PR(s): #31531
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): #31531

Nov 19 '20 19:11 cmsbuild

Would someone be able to trigger Nano/NanoGen tests, as a first check?

Nov 23 '20 21:11 kdlong

please test

Nov 23 '20 21:11 kpedro88

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-11-23-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10966/console Started: 2020/11/23 22:34

Nov 23 '20 21:11 cmsbuild

-1

Tested at: 752f300f2211385c77ee51a6f2ef69578a00d5bb

CMSSW: CMSSW_11_2_X_2020-11-23-1100 SCRAM_ARCH: slc7_amd64_gcc820 You can see the results of the tests here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3df97d/10966/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals

Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

RelVals:

When I ran the RelVals I found an error in the following workflows: 1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

1330.0 step5

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15/step5_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15.log

10042.0 step6

runTheMatrix-results/10042.0_ZMM_13+2017+ZMM_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step6_ZMM_13+2017+ZMM_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

10024.0 step6

runTheMatrix-results/10024.0_TTbar_13+2017+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step6_TTbar_13+2017+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

25202.0 step5

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step5_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

10824.0 step6

runTheMatrix-results/10824.0_TTbar_13+2018+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step6_TTbar_13+2018+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

23434.999 step5

runTheMatrix-results/23434.999_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step5_TTbar_13+2017PU+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano.log

10224.0 step5

runTheMatrix-results/10224.0_TTbar_13+2017PU+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano/step5_TTbar_13+2017PU+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano.log

Nov 24 '20 00:11 cmsbuild

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

Nov 24 '20 00:11 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32167/20021

This PR adds an extra 20KB to repository
Found files with invalid states:
- testFiles/W1jet_260_weight_info.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- testFiles/overview.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- TestWeightInfo/TestAnalyzer/test/test_catch2_TestAnalyzer.cc:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- PhysicsTools/NanoAOD/python/lheWeightsTable_cfi.py:
  - Added: a073bf035eb793147ec0dd90075c32b1bdb6c8ef
  - Deleted: 48fcabd86936600d60a9957c591819f952e068af
- testFiles/WJ_NNLOPS_weightinfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- SimDataFormats/GeneratorProducts/src/LHEWeightInfoProduct.cc:
  - Added: 7cfc2feb0447c7f9c6f87ce2a3f402aa1c3ee7e7
  - Modified: 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c, 23bee6651a368d039c37fa89cfa9a231f03b02dd, 0ba28e0e82f8b6ae52dde4a2cc9bdea0f48e033d, 5668f0da242c77aa8e6a38aa25d59e9263d500cd, ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: c535b5555a10d4e577de6348a79fe364f4d4a572
- GeneratorInterface/LHEInterface/interface/TestWeightInfo.h:
  - Added: 444dbc3d3924c325ca58144515c988d9874862c8
  - Modified: 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c, 23bee6651a368d039c37fa89cfa9a231f03b02dd, 0ba28e0e82f8b6ae52dde4a2cc9bdea0f48e033d, 9ba9510ed189b63a00d1e489cb8fa6e147605e18, 8397fca6352d6d36297683c2d6dcc9400a035a60, 8fcc2305c2f0c46e180f9acb8e641640d0b024bb
  - Deleted: 9bd87c7b4ddfb64cb93fc814b580458197132ac9
- testFiles/ZZTo4L_powheg_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/Core/test/testLHEWeightProducer_cfg.py:
  - Added: b6e3285ab650f7c00ea64adcada148c9121de778
  - Modified: ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: 176adbfe905a4c7c7503856b77cb7ba617aabe67
- testFiles/susyweights.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/Core/test/testGenWeights_simpleZanalyzer_cfg.py:
  - Added: d307670532843a19d40b326ed6676f918c46c92e
  - Modified: bbdd4626eed90e045dfdc0a1826da10673187d4a
  - Deleted: 884dc84cf36c5578e59c7300e2f63c11403f07b2
- testFiles/DrellYan_NLO_MGFXFXv242_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- Test/Test/src/classes_def.xml:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- TestWeightInfo/TestAnalyzer/test/test_cfg.py:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Modified: b6e3285ab650f7c00ea64adcada148c9121de778
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- SimDataFormats/GeneratorProducts/interface/LHEWeightInfoProduct.h:
  - Added: 208a4a32607492d78c629c5878a9d8112b014c11
  - Modified: 0a8810ee2870d5109feecef3c19dbd2e4a97c77f, 7cfc2feb0447c7f9c6f87ce2a3f402aa1c3ee7e7, 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c, 23bee6651a368d039c37fa89cfa9a231f03b02dd, 0ba28e0e82f8b6ae52dde4a2cc9bdea0f48e033d, 5668f0da242c77aa8e6a38aa25d59e9263d500cd, ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: c535b5555a10d4e577de6348a79fe364f4d4a572
- GeneratorInterface/Core/interface/LHEWeightGroupReaderHelper.h:
  - Added: 682ac14c6bc1d726141403970a70a4ed97d9fc82
  - Deleted: 037f6f9cd0508d68aa8e262e93ebe496da00137e
- testFiles/DrellYan_NLO_MGFXFXv233_2016_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/interface/LHEWeightGroupReaderHelper.h:
  - Added: 071c069ce03bd33257f30f205694fdd8b39c881a
  - Modified: 6bfea57af6dd3765ccb06147daa8491e40568964, f62468c7e64b1d83c0d30df79754e27332d847f5, 28f0ba2f3ff4d69e3fa10b1d6c3a78925965e666, 71629cd0b87c58911e047368aa45d2bd3393df06, c98a07826f18351a74c30e47c31e1f078e129487, 1c1da7637d6c910ab5b99eca20a2a59e42a030c8, 80cde77e1e419d54a1ec19c5f7bdc91b070a010f, 33e246685138ddac48d2c72588aa2c82662a941f, 9baeee20d3686431d22a290965c55a95fcfbda87, f1a3ae406e49d6c904e27d83efa3050452aeb96b
  - Deleted: 682ac14c6bc1d726141403970a70a4ed97d9fc82
- Test/Test/BuildFile.xml:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- SimDataFormats/GeneratorProducts/interface/LHEWeightProduct.h:
  - Added: 208a4a32607492d78c629c5878a9d8112b014c11
  - Modified: 444dbc3d3924c325ca58144515c988d9874862c8, 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c
  - Deleted: c535b5555a10d4e577de6348a79fe364f4d4a572
- GeneratorInterface/LHEInterface/test/testWeights.py:
  - Added: df8416421345ba3a7e3d920edc30c914ad7d7cf2
  - Modified: 5668f0da242c77aa8e6a38aa25d59e9263d500cd, 8c0c98e491fced903b41919d38e4336fbd963f74, b6e3285ab650f7c00ea64adcada148c9121de778, c535b5555a10d4e577de6348a79fe364f4d4a572, acc3817b6f810b8f2fdd40e0c0c66ed86d989a13, a30dacf9518651c94a251e3ff3c8f4d7a46f4ad3
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- TestWeightInfo/TestAnalyzer/plugins/TestAnalyzer.cc:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Modified: 07eb97abc8336ed0006db49d6a46c6b229ac2d8f, c535b5555a10d4e577de6348a79fe364f4d4a572
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- testFiles/DrellYan_LO_MGMLMv233_2016_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/test/test_Weights_cfg.py:
  - Added: df8416421345ba3a7e3d920edc30c914ad7d7cf2
  - Modified: 59691bc6a647eef22e57ed248fa4d9a0d9520a8a, 33e246685138ddac48d2c72588aa2c82662a941f, 1038e0df4d60d1679b531d77e3c243e0e4253987, f1a3ae406e49d6c904e27d83efa3050452aeb96b, 5668f0da242c77aa8e6a38aa25d59e9263d500cd, b6e3285ab650f7c00ea64adcada148c9121de778, d6c2452601abe4d59950ad790612f187fe2eeb3e
  - Deleted: 8f74a2c0642870ca8f74f1697941b21d160b1e71
- PhysicsTools/NanoAOD/test/nanoGen_test_cfg.py:
  - Added: afe662adbe2679072ca219b6a606c4462962301d
  - Modified: ca22fc5b12d786f48a74678a7fee1a1dd5eb3f10
  - Deleted: 8f74a2c0642870ca8f74f1697941b21d160b1e71
- testFiles/DrellYan_LO_MGMLMv242_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- TestWeightInfo/TestAnalyzer/test/test_catch2_main.cc:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- testFiles/W1jet_260_simplescale_weight_info.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- testFiles/WZVBS_private_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- Test/Test/src/classes.h:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- testFiles/ZJ_MiNNLO_weightinfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- PhysicsTools/NanoAOD/python/genWeightsTable_cfi.py:
  - Added: 45be54a91e93c7aefdfdda3c49dc4135b40e34b2
  - Modified: 8f74a2c0642870ca8f74f1697941b21d160b1e71
  - Deleted: 48fcabd86936600d60a9957c591819f952e068af
- Test/Test/src/test.cc:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- testFiles/WJ_MiNNLO_weightinfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/Core/plugins/GenWeightsTestAnalyzer.cc:
  - Added: d307670532843a19d40b326ed6676f918c46c92e
  - Modified: bbdd4626eed90e045dfdc0a1826da10673187d4a, 8fcc2305c2f0c46e180f9acb8e641640d0b024bb
  - Deleted: 884dc84cf36c5578e59c7300e2f63c11403f07b2
- testFiles/ZZTo4L_powheg_2016_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- SimDataFormats/GeneratorProducts/src/ScaleWeightGroupInfo.h:
  - Added: 9e062713d369cd61c3b0514c98f51515570eb4a1
  - Deleted: f62468c7e64b1d83c0d30df79754e27332d847f5
- TestWeightInfo/TestAnalyzer/test/BuildFile.xml:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- PhysicsTools/NanoAOD/plugins/LHEWeightsTableProducer.cc:
  - Added: 70cdb973eb995bd020db9d8830f0ef53bb3fd043
  - Modified: 205de35015c23df0523b8c1b52c7c857754b3c31, d663d2f5cb2d2b9bf1dbcbe66845b4844a7c34de, 45be54a91e93c7aefdfdda3c49dc4135b40e34b2, 6c5900c5e79cb695aa803c3d6c80ec5efe627601, fb19c05ff6a881b79291269911a376709d20c2c3, ae40865dd6c1a0d3488eba13abf7c6669110867f, e542eaa66bc0cdff977f45bfe3d1aa58647bdb2c, ca22fc5b12d786f48a74678a7fee1a1dd5eb3f10, 8fcc2305c2f0c46e180f9acb8e641640d0b024bb, 3dbdd4c2515791462b43bf4d3f346456a4c366dd, 265e6a0463c2712017d231cafc9db23850c9897c, 6aaef397110c974d83ba52e75c65e5819dd9fc1d, 6ccee5d97cb552ffbad85a773e833fc8e6ef658b, 8c2927e4630a4953f2c726750c15f9994e9a10e4, 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 3180b59bfee7660535dce9e9142ba890c1319b33, 2622c4060c071a2828b44ac284cff3c5eca9aac7, d057424e79f0cd65fe4aa2df693f8abcda5bc521, 0f1a1ac5e9a4226e4c2de24ea7ed5450e8f59fdf, 87330083d1dea5005c284a657eee44c644b61ec0, 20f26343af75c5c1e11df57345c3ffb4c95a938d, a91bdf2d849587546a22f0274b98541fc7e75ecb, 3f41984dbc7fa15c568eb02604c1899534a499ef, a073bf035eb793147ec0dd90075c32b1bdb6c8ef, 8ca625f91f8bfe87dbb6f4313447530596d7df0b, f46cc339bcbe527847695289200daf4b90f0d6cd, 41c79e2f389e640ac0964398bc1440503c9f31b2, 5d2297c253349834740f894dc177a16da3647981, ef90c0377a5a196ebef68aa55467919b5bc9cc13, 34b9c3a91ba6e88ca3c26706963bbc300dff6b13, 5613cf66afec04ccd0f7221251cbb159a2c01a24, 93ecbf8d2d0e6a91bf220e6cd96ffec7ca1be794, 601b0907bf1cc35b17d5506f92a4d2e76281f3f5, 099b683922bf633424d140f0ae15707be4e5ae0e, ae87760c3ce63dd22818b899a604d81691202e97, 882f046b23ac8eaba4737a0b0a2a620bc2d83991, 76b867cb5703d932c5045ce19c2b2143eb588ec0, e1539bafc0216955a0eb013ba844b7e04b45261c, 49b5d2b34fc45cefa325f4915f3799833b8ba119, db98fc424b7930355f4c14c433be2306d962657a
  - Deleted: 48fcabd86936600d60a9957c591819f952e068af
- testFiles/WZVBS_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/test/test_ZPlotting_LHEweights_cfg.py:
  - Added: ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: d307670532843a19d40b326ed6676f918c46c92e
- lhe_test.C:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 8f74a2c0642870ca8f74f1697941b21d160b1e71
- SimDataFormats/GeneratorProducts/src/PartonShowerWeights.cc:
  - Added: 3e4861786d64c142e076e4d6c8b9d20bfd143f9d
  - Modified: 8c2927e4630a4953f2c726750c15f9994e9a10e4, 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, ba5be6c63b9506d23357404c5e532af3ff00ad50
  - Deleted: 21e251a44c9fe184bab891e81b101ce763f92494
- TestWeightInfo/TestAnalyzer/plugins/BuildFile.xml:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- Test/Test/interface/test.h:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- testFiles/ZMiNNLO.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/plugins/LHEWeightsTest.cc:
  - Added: c82792f33130092fba6fa07871218dadcdbcb830
  - Modified: ffd0503039329ada0dc9713ba88ef6b83dfcf8ed, c535b5555a10d4e577de6348a79fe364f4d4a572, 27a923953edc24c3909ee96ffcc59c48150d3625, 7402487d89a5c1d1dd40bda529e4d0089bc5b4e6, b744a77cacdc520c1d7da23ead44966c5ddc6e99
  - Deleted: d307670532843a19d40b326ed6676f918c46c92e
- testFiles/VVV_2017_weight_info.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/plugins/NanoAODOutputModule.cc modified in PR(s): #31531
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): #31531

Nov 24 '20 09:11 cmsbuild

Pull request #32167 was updated. @SiewYan, @gouskos, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @fgolf, @alberto-sanchez, @agrohsje, @mariadalfonso, @santocch can you please check and sign again.

Nov 24 '20 09:11 cmsbuild

please test

Nov 24 '20 14:11 kpedro88

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-11-23-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10987/console Started: 2020/11/24 15:09

Nov 24 '20 14:11 cmsbuild

-1

Tested at: d09e64d32f14a464f53e3591b69e0320f72961ed

CMSSW: CMSSW_11_2_X_2020-11-23-2300 SCRAM_ARCH: slc7_amd64_gcc820 You can see the results of the tests here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3df97d/10987/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals

Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

RelVals:

When I ran the RelVals I found an error in the following workflows: 1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

1330.0 step5

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15/step5_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15.log

10042.0 step6

runTheMatrix-results/10042.0_ZMM_13+2017+ZMM_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step6_ZMM_13+2017+ZMM_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

10024.0 step6

runTheMatrix-results/10024.0_TTbar_13+2017+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step6_TTbar_13+2017+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

25202.0 step5

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step5_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

10824.0 step6

runTheMatrix-results/10824.0_TTbar_13+2018+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step6_TTbar_13+2018+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

10224.0 step5

runTheMatrix-results/10224.0_TTbar_13+2017PU+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano/step5_TTbar_13+2017PU+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano.log

Nov 24 '20 17:11 cmsbuild

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

Nov 24 '20 17:11 cmsbuild

@kdlong Any follow up on the unit test failure?

Dec 15 '20 03:12 qliphy

@qliphy I'm going to look closer in the coming days. I can't figure out how to view which tests failed. If I click on details, I see a "Not found" message. Is the output cleared after so many days?

Dec 23 '20 11:12 kdlong

@kdlong yes, the test output is deleted after some time. We can't start the tests again until the merge conflicts are resolved.

Dec 23 '20 16:12 kpedro88

Thanks @kpedro88. I resolved the conflict, if you run the tests again I'll start looking at the failures.

Dec 23 '20 17:12 kdlong

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32167/20566

This PR adds an extra 1684KB to repository
Found files with invalid states:
- testFiles/W1jet_260_weight_info.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- testFiles/overview.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- TestWeightInfo/TestAnalyzer/test/test_catch2_TestAnalyzer.cc:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- PhysicsTools/NanoAOD/python/lheWeightsTable_cfi.py:
  - Added: a073bf035eb793147ec0dd90075c32b1bdb6c8ef
  - Deleted: 48fcabd86936600d60a9957c591819f952e068af
- testFiles/WJ_NNLOPS_weightinfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- SimDataFormats/GeneratorProducts/src/LHEWeightInfoProduct.cc:
  - Added: 7cfc2feb0447c7f9c6f87ce2a3f402aa1c3ee7e7
  - Modified: 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c, 23bee6651a368d039c37fa89cfa9a231f03b02dd, 0ba28e0e82f8b6ae52dde4a2cc9bdea0f48e033d, 5668f0da242c77aa8e6a38aa25d59e9263d500cd, ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: c535b5555a10d4e577de6348a79fe364f4d4a572
- GeneratorInterface/LHEInterface/interface/TestWeightInfo.h:
  - Added: 444dbc3d3924c325ca58144515c988d9874862c8
  - Modified: 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c, 23bee6651a368d039c37fa89cfa9a231f03b02dd, 0ba28e0e82f8b6ae52dde4a2cc9bdea0f48e033d, 9ba9510ed189b63a00d1e489cb8fa6e147605e18, 8397fca6352d6d36297683c2d6dcc9400a035a60, 8fcc2305c2f0c46e180f9acb8e641640d0b024bb
  - Deleted: 9bd87c7b4ddfb64cb93fc814b580458197132ac9
- testFiles/ZZTo4L_powheg_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/Core/test/testLHEWeightProducer_cfg.py:
  - Added: b6e3285ab650f7c00ea64adcada148c9121de778
  - Modified: ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: 176adbfe905a4c7c7503856b77cb7ba617aabe67
- testFiles/susyweights.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/Core/test/testGenWeights_simpleZanalyzer_cfg.py:
  - Added: d307670532843a19d40b326ed6676f918c46c92e
  - Modified: bbdd4626eed90e045dfdc0a1826da10673187d4a
  - Deleted: 884dc84cf36c5578e59c7300e2f63c11403f07b2
- testFiles/DrellYan_NLO_MGFXFXv242_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- Test/Test/src/classes_def.xml:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- TestWeightInfo/TestAnalyzer/test/test_cfg.py:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Modified: b6e3285ab650f7c00ea64adcada148c9121de778
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- SimDataFormats/GeneratorProducts/interface/LHEWeightInfoProduct.h:
  - Added: 208a4a32607492d78c629c5878a9d8112b014c11
  - Modified: 0a8810ee2870d5109feecef3c19dbd2e4a97c77f, 7cfc2feb0447c7f9c6f87ce2a3f402aa1c3ee7e7, 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c, 23bee6651a368d039c37fa89cfa9a231f03b02dd, 0ba28e0e82f8b6ae52dde4a2cc9bdea0f48e033d, 5668f0da242c77aa8e6a38aa25d59e9263d500cd, ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: c535b5555a10d4e577de6348a79fe364f4d4a572
- GeneratorInterface/Core/interface/LHEWeightGroupReaderHelper.h:
  - Added: 682ac14c6bc1d726141403970a70a4ed97d9fc82
  - Deleted: 037f6f9cd0508d68aa8e262e93ebe496da00137e
- testFiles/DrellYan_NLO_MGFXFXv233_2016_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/interface/LHEWeightGroupReaderHelper.h:
  - Added: 071c069ce03bd33257f30f205694fdd8b39c881a
  - Modified: 6bfea57af6dd3765ccb06147daa8491e40568964, f62468c7e64b1d83c0d30df79754e27332d847f5, 28f0ba2f3ff4d69e3fa10b1d6c3a78925965e666, 71629cd0b87c58911e047368aa45d2bd3393df06, c98a07826f18351a74c30e47c31e1f078e129487, 1c1da7637d6c910ab5b99eca20a2a59e42a030c8, 80cde77e1e419d54a1ec19c5f7bdc91b070a010f, 33e246685138ddac48d2c72588aa2c82662a941f, 9baeee20d3686431d22a290965c55a95fcfbda87, f1a3ae406e49d6c904e27d83efa3050452aeb96b
  - Deleted: 682ac14c6bc1d726141403970a70a4ed97d9fc82
- Test/Test/BuildFile.xml:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- SimDataFormats/GeneratorProducts/interface/LHEWeightProduct.h:
  - Added: 208a4a32607492d78c629c5878a9d8112b014c11
  - Modified: 444dbc3d3924c325ca58144515c988d9874862c8, 49c25ba7a201cac7dc3c516f0dd8be95e4901509, bb431b79b74099c817e8848de2c6c2edb27ca62c
  - Deleted: c535b5555a10d4e577de6348a79fe364f4d4a572
- GeneratorInterface/LHEInterface/test/testWeights.py:
  - Added: df8416421345ba3a7e3d920edc30c914ad7d7cf2
  - Modified: 5668f0da242c77aa8e6a38aa25d59e9263d500cd, 8c0c98e491fced903b41919d38e4336fbd963f74, b6e3285ab650f7c00ea64adcada148c9121de778, c535b5555a10d4e577de6348a79fe364f4d4a572, acc3817b6f810b8f2fdd40e0c0c66ed86d989a13, a30dacf9518651c94a251e3ff3c8f4d7a46f4ad3
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- TestWeightInfo/TestAnalyzer/plugins/TestAnalyzer.cc:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Modified: 07eb97abc8336ed0006db49d6a46c6b229ac2d8f, c535b5555a10d4e577de6348a79fe364f4d4a572
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- testFiles/DrellYan_LO_MGMLMv233_2016_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/test/test_Weights_cfg.py:
  - Added: df8416421345ba3a7e3d920edc30c914ad7d7cf2
  - Modified: 59691bc6a647eef22e57ed248fa4d9a0d9520a8a, 33e246685138ddac48d2c72588aa2c82662a941f, 1038e0df4d60d1679b531d77e3c243e0e4253987, f1a3ae406e49d6c904e27d83efa3050452aeb96b, 5668f0da242c77aa8e6a38aa25d59e9263d500cd, b6e3285ab650f7c00ea64adcada148c9121de778, d6c2452601abe4d59950ad790612f187fe2eeb3e
  - Deleted: 8f74a2c0642870ca8f74f1697941b21d160b1e71
- PhysicsTools/NanoAOD/test/nanoGen_test_cfg.py:
  - Added: afe662adbe2679072ca219b6a606c4462962301d
  - Modified: ca22fc5b12d786f48a74678a7fee1a1dd5eb3f10
  - Deleted: 8f74a2c0642870ca8f74f1697941b21d160b1e71
- testFiles/DrellYan_LO_MGMLMv242_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- TestWeightInfo/TestAnalyzer/test/test_catch2_main.cc:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- testFiles/W1jet_260_simplescale_weight_info.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- testFiles/WZVBS_private_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- Test/Test/src/classes.h:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- testFiles/ZJ_MiNNLO_weightinfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- PhysicsTools/NanoAOD/python/genWeightsTable_cfi.py:
  - Added: 45be54a91e93c7aefdfdda3c49dc4135b40e34b2
  - Modified: 8f74a2c0642870ca8f74f1697941b21d160b1e71
  - Deleted: 48fcabd86936600d60a9957c591819f952e068af
- Test/Test/src/test.cc:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- testFiles/WJ_MiNNLO_weightinfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/Core/plugins/GenWeightsTestAnalyzer.cc:
  - Added: d307670532843a19d40b326ed6676f918c46c92e
  - Modified: bbdd4626eed90e045dfdc0a1826da10673187d4a, 8fcc2305c2f0c46e180f9acb8e641640d0b024bb
  - Deleted: 884dc84cf36c5578e59c7300e2f63c11403f07b2
- testFiles/ZZTo4L_powheg_2016_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- SimDataFormats/GeneratorProducts/src/ScaleWeightGroupInfo.h:
  - Added: 9e062713d369cd61c3b0514c98f51515570eb4a1
  - Deleted: f62468c7e64b1d83c0d30df79754e27332d847f5
- TestWeightInfo/TestAnalyzer/test/BuildFile.xml:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- PhysicsTools/NanoAOD/plugins/LHEWeightsTableProducer.cc:
  - Added: 70cdb973eb995bd020db9d8830f0ef53bb3fd043
  - Modified: 205de35015c23df0523b8c1b52c7c857754b3c31, d663d2f5cb2d2b9bf1dbcbe66845b4844a7c34de, 45be54a91e93c7aefdfdda3c49dc4135b40e34b2, 6c5900c5e79cb695aa803c3d6c80ec5efe627601, fb19c05ff6a881b79291269911a376709d20c2c3, ae40865dd6c1a0d3488eba13abf7c6669110867f, e542eaa66bc0cdff977f45bfe3d1aa58647bdb2c, ca22fc5b12d786f48a74678a7fee1a1dd5eb3f10, 8fcc2305c2f0c46e180f9acb8e641640d0b024bb, 3dbdd4c2515791462b43bf4d3f346456a4c366dd, 265e6a0463c2712017d231cafc9db23850c9897c, 6aaef397110c974d83ba52e75c65e5819dd9fc1d, 6ccee5d97cb552ffbad85a773e833fc8e6ef658b, 8c2927e4630a4953f2c726750c15f9994e9a10e4, 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 3180b59bfee7660535dce9e9142ba890c1319b33, 2622c4060c071a2828b44ac284cff3c5eca9aac7, d057424e79f0cd65fe4aa2df693f8abcda5bc521, 0f1a1ac5e9a4226e4c2de24ea7ed5450e8f59fdf, 87330083d1dea5005c284a657eee44c644b61ec0, 20f26343af75c5c1e11df57345c3ffb4c95a938d, a91bdf2d849587546a22f0274b98541fc7e75ecb, 3f41984dbc7fa15c568eb02604c1899534a499ef, a073bf035eb793147ec0dd90075c32b1bdb6c8ef, 8ca625f91f8bfe87dbb6f4313447530596d7df0b, f46cc339bcbe527847695289200daf4b90f0d6cd, 41c79e2f389e640ac0964398bc1440503c9f31b2, 5d2297c253349834740f894dc177a16da3647981, ef90c0377a5a196ebef68aa55467919b5bc9cc13, 34b9c3a91ba6e88ca3c26706963bbc300dff6b13, 5613cf66afec04ccd0f7221251cbb159a2c01a24, 93ecbf8d2d0e6a91bf220e6cd96ffec7ca1be794, 601b0907bf1cc35b17d5506f92a4d2e76281f3f5, 099b683922bf633424d140f0ae15707be4e5ae0e, ae87760c3ce63dd22818b899a604d81691202e97, 882f046b23ac8eaba4737a0b0a2a620bc2d83991, 76b867cb5703d932c5045ce19c2b2143eb588ec0, e1539bafc0216955a0eb013ba844b7e04b45261c, 49b5d2b34fc45cefa325f4915f3799833b8ba119, db98fc424b7930355f4c14c433be2306d962657a
  - Deleted: 48fcabd86936600d60a9957c591819f952e068af
- testFiles/WZVBS_2017_weightInfo.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/test/test_ZPlotting_LHEweights_cfg.py:
  - Added: ffd0503039329ada0dc9713ba88ef6b83dfcf8ed
  - Deleted: d307670532843a19d40b326ed6676f918c46c92e
- lhe_test.C:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 8f74a2c0642870ca8f74f1697941b21d160b1e71
- SimDataFormats/GeneratorProducts/src/PartonShowerWeights.cc:
  - Added: 3e4861786d64c142e076e4d6c8b9d20bfd143f9d
  - Modified: 8c2927e4630a4953f2c726750c15f9994e9a10e4, 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, ba5be6c63b9506d23357404c5e532af3ff00ad50
  - Deleted: 21e251a44c9fe184bab891e81b101ce763f92494
- TestWeightInfo/TestAnalyzer/plugins/BuildFile.xml:
  - Added: 79efbe6f198d3826f4446afc57e154f37b4146b9
  - Deleted: 2b1b520300ec3465bb7cf26a6467d257ac647bf5
- Test/Test/interface/test.h:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 217176137083746e389f4b2854796be8482f085e
- testFiles/ZMiNNLO.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373
- GeneratorInterface/LHEInterface/plugins/LHEWeightsTest.cc:
  - Added: c82792f33130092fba6fa07871218dadcdbcb830
  - Modified: ffd0503039329ada0dc9713ba88ef6b83dfcf8ed, c535b5555a10d4e577de6348a79fe364f4d4a572, 27a923953edc24c3909ee96ffcc59c48150d3625, 7402487d89a5c1d1dd40bda529e4d0089bc5b4e6, b744a77cacdc520c1d7da23ead44966c5ddc6e99
  - Deleted: d307670532843a19d40b326ed6676f918c46c92e
- testFiles/VVV_2017_weight_info.txt:
  - Added: 0e631518c9b5a8e29f2592b1c425cb3a062d36fa, 6d6b77f837074b3dad976f60ad63bfdad3588858
  - Deleted: 5fffa1da66d7b68a375b45fb2f6d2d9a01a6d373

Dec 23 '20 17:12 cmsbuild

Pull request #32167 was updated. @SiewYan, @gouskos, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @fgolf, @alberto-sanchez, @agrohsje, @mariadalfonso, @santocch can you please check and sign again.

Dec 23 '20 17:12 cmsbuild

please test

Dec 23 '20 17:12 kpedro88