Switch to codecov-action v5 and remove token

[wil93]

(Still WIP)

I'm Trying to debug why coverage updates are not being sent anymore, let's see if updating from v4 to v5 fixes things.

Also in v5 the token should not be required anymore for public repositories, see https://github.com/codecov/codecov-action?tab=readme-ov-file#v5-release

[prandla]

I'm Trying to debug why coverage updates are not being sent anymore

I think it's some weirdness with the branches; codecov's UI says the "last commit on main" is the last commit that was on the old master branch. I still don't know how to fix it though :)

Perhaps we can just delete and recreate the entire codecov project?

(also, it looks like the v5 action tries to download a file named "codecov" and then errors because we already have a directory with that name... guess we should rename our directory then?)

[codecov[bot]]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :warning: Please upload report for BASE (main@4c7f69c). Learn more about missing BASE report. :white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1534   +/-   ##
=======================================
  Coverage        ?   54.62%           
=======================================
  Files           ?      339           
  Lines           ?    27630           
  Branches        ?        0           
=======================================
  Hits            ?    15093           
  Misses          ?    12537           
  Partials        ?        0           

Flag	Coverage Δ
functionaltests	0.00% <ø> (?)
unittests	54.62% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[prandla]

okay, it's now at least uploading coverage for the pull request successfully, so i can only hope that it'll also work on the main branch...

then again, it was also doing that earlier (i.e. failing on main but successful in PRs), so i don't know if this actually fixes anything.