cms
cms copied to clipboard
fix: pin MarkupSafe to 2.0.1 (#33)
Cherry-pick commit e718c6206e1d1a08c34e3703587c14522e86b391 from ioi2022/cms, which should fix tests breaking due to beaking changes in MarkupSafe.
Codecov Report
Merging #1211 (ec8a2ec) into master (0401c53) will decrease coverage by
0.21%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1211 +/- ##
==========================================
- Coverage 63.88% 63.66% -0.22%
==========================================
Files 233 233
Lines 17151 17151
==========================================
- Hits 10957 10920 -37
- Misses 6194 6231 +37
Flag | Coverage Δ | |
---|---|---|
functionaltests | 47.53% <ø> (-0.23%) |
:arrow_down: |
unittests | 43.98% <ø> (-0.06%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
cms/plugin.py | 81.81% <0.00%> (-18.19%) |
:arrow_down: |
cms/service/workerpool.py | 66.11% <0.00%> (-6.12%) |
:arrow_down: |
cms/service/ScoringService.py | 68.18% <0.00%> (-6.07%) |
:arrow_down: |
cms/db/base.py | 88.11% <0.00%> (-2.98%) |
:arrow_down: |
cms/server/admin/handlers/base.py | 68.31% <0.00%> (-2.98%) |
:arrow_down: |
cms/service/EvaluationService.py | 74.62% <0.00%> (-2.49%) |
:arrow_down: |
cms/server/contest/handlers/contest.py | 86.40% <0.00%> (-1.95%) |
:arrow_down: |
cms/io/service.py | 72.78% <0.00%> (-1.27%) |
:arrow_down: |
cms/grading/scoring.py | 79.06% <0.00%> (-1.17%) |
:arrow_down: |
cms/service/ResourceService.py | 59.11% <0.00%> (-0.89%) |
:arrow_down: |
... and 10 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
⬆️
Thanks! I'm taking a look into this issue, a quick feedback in the meantime: I think it would be preferable to avoid adding MarkupSafe as a dependency since it's not actually a dependency for us (it's a dependency of one of our dependencies, Jinja2) so maybe it would be cleaner to solve this by upgrading Jinja2 instead.
Merged like this for now, as it seems that the only other solution would be pinning all dependencies (e.g. using pip-tools or pipenv) and we can do that at a later time. Thanks for the fix!