greeclimate icon indicating copy to clipboard operation
greeclimate copied to clipboard

fix: invalid device state after bind

Open cmroche opened this issue 1 year ago • 2 comments

Immediately call for as state update as soon as the device is bound, add a signal that can be used to check that the device has received it's first state update.

Removed unused, optional, wait_for parameter on update_state and send_device_state

CLOSES #99

cmroche avatar Aug 11 '24 20:08 cmroche

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.79%. Comparing base (7122cdd) to head (fbf9748). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
greeclimate/device.py 90.90% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   95.75%   95.79%   +0.04%     
==========================================
  Files           8        8              
  Lines         730      737       +7     
==========================================
+ Hits          699      706       +7     
  Misses         31       31              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 11 '24 20:08 codecov[bot]

Just bumping this PR to say that it worked for me. I wasn't getting any device state even after a bind() and update_state() but this patch fixes that, thanks. I hope it can get merged.

AnicJov avatar Jul 09 '25 00:07 AnicJov