ros_pybullet_interface icon indicating copy to clipboard operation
ros_pybullet_interface copied to clipboard

bloom release

Open christian-rauch opened this issue 3 years ago • 11 comments

It would be very convenient to have all the packages available in the ROS apt repo (via bloom).

This requires:

  • [ ] install everything properly so the packages can run from the install space (instead of the devel space) https://github.com/cmower/ros_pybullet_interface/issues/111
  • [ ] have all external dependencies available as binary packages in the ROS repo
  • [ ] release all source dependencies (e.g. ik_ros) recursively

Packages requiring a release:

  • [ ] https://github.com/lrse/ros-keyboard.git
  • [ ] https://github.com/cmower/custom_ros_tools.git

christian-rauch avatar Apr 27 '22 09:04 christian-rauch

This would be great if we can get it done. What do you mean by "recursively"?

cmower avatar Apr 27 '22 14:04 cmower

This would be great if we can get it done. What do you mean by "recursively"?

By recursively I mean that if one of your source dependencies (B) depends on another source dependency (C), then you have to binary release them in the reverse order (i.e. first C, then B and finally the ros_pybullet_interface).

christian-rauch avatar Apr 27 '22 14:04 christian-rauch

@cmower Do you have a "dependency graph" of all the packages that you need?

christian-rauch avatar Apr 27 '22 14:04 christian-rauch

@cmower Do you have a "dependency graph" of all the packages that you need?

Not to my knowledge. Is there a way to generate this?

cmower avatar Apr 27 '22 14:04 cmower

Not to my knowledge. Is there a way to generate this?

Maybe. But do you maybe have a list of all the custom packages that are needed for ros_pybullet_interface? When I tried to run some of the demos on my PC, it required a lot of packages that are not available via the apt repo. E.g. I needed https://github.com/cmower/ros-keyboard which is outdated (python2) and is not supported anymore.

christian-rauch avatar Apr 27 '22 14:04 christian-rauch

From the deps.rosinstall I gathered the following dependencies:

  • https://github.com/lrse/ros-keyboard.git
  • https://github.com/cmower/custom_ros_tools.git

But I think there are a couple of packages missing. E.g. the dependencies:

  • https://github.com/cmower/ik_ros.git
  • https://github.com/cmower/dmp.git
  • https://github.com/cmower/teleop.git

are missing. Are they required? Should the be built as part of ros_pybullet_interface?

@cmower Can you extend the list of required packages in the first message?

Since the ros_pybullet_interface repository contains multiple packages (rpbi_utils, rpbi_examples and ros_pybullet_interface) you may also need a "meta-package" like vision_opencv (https://github.com/ros-perception/vision_opencv) that just depends on all it "subpackages".

christian-rauch avatar Apr 27 '22 15:04 christian-rauch

@christian-rauch thanks for this, I will take a look and see if there are any other packages we need to add to the list.

cmower avatar Apr 27 '22 15:04 cmower

What about examples like talos that I just pushed in #121. This depends on talos_description, can we only list that package or do we need to add the full talos_robot?

cmower avatar Apr 27 '22 15:04 cmower

I think you have to publish/bloom all the packages in a repo. It will be difficult anyway to build only a subset of packages in a repo automatically. After checking out https://github.com/ipab-slmc/talos_robot, you have to delete everything but the folder talos_description to skip building the other packages.

christian-rauch avatar Apr 27 '22 15:04 christian-rauch

Can you extend the list of required packages in the first message?

@christian-rauch the following is a list of all the packages I could find that ros_pybullet_interface requires:

  • https://github.com/cmower/operator_node
  • https://bitbucket.org/traclabs/trac_ik.git
  • https://github.com/ipab-slmc/exotica.git
  • https://github.com/Kinovarobotics/ros_kortex
  • https://github.com/ipab-slmc/talos_robot

Notes, the https://github.com/cmower/dmp.git repo is a fork of http://wiki.ros.org/dmp

Re examples that include robots like chonk, I will move these out and put them in an SLMC repo since these examples wont be very useful outside the group.

cmower avatar May 05 '22 15:05 cmower

Removed SLMC examples (349e032d4f507050279da57d8f50cd3da31e6812), new repo: https://github.com/ipab-slmc/rpbi_slmc_examples

cmower avatar May 05 '22 17:05 cmower