Christian Menard

Results 188 comments of Christian Menard

The first example indeed looks like a bug in the C code generator. Have you tried this in the C++ target? The error message from the C++ runtime in the...

Oh, right this is the same problem as in the other example. In the C++ target, `get()` on a port always returns a smart pointer to the value. You can...

I fixed the problem in the C++ runtime in https://github.com/lf-lang/lingua-franca/pull/1361. Now the first program works as expected in C++.

> I think that handling special cases in this way is appropriate and could lead to an overall better user experience. Use of the math library is very common in...

With regard to the math library, why not add `-lm` by default? Is there a case where we really don't want to add the math library? Ok, so if we...

I think this is one side of the coin. However, the initial concern of my comment is another. If we use test configurators to set `threading` and `workers` for every...

Whether the target property `workers: 42` indeed sets the number of workers to 42. It would be mostly testing our code generators. If we always configure `workers` and `threading` in...

A test like Soroush proposes would also be easy to implement in C++. However, given our current test setup, this test will fail since the configurators will invoke lfc with...

Oh, ok. So you removed the configurator that sets the number of workers. Looks like a viable solution to me :)

The proposed solution oversimplifies the problem and only works for C standard libraries (like math). Linking to libraries in C/C++ is complicated and messy, and there is no way around...