s3_file does not honor proxy settings

[atward]

https://github.com/cmlicata/cloudcli-cookbook/blob/master/providers/aws_s3_file.rb#L79

Proxy ENV settings are stripped from environment.

aws-cli honors http_proxy, https_proxy, and no_proxy which are the same used by Chef: https://docs.chef.io/proxies.html

These environment variables should be retained.

[atward]

See https://github.com/awslabs/awscli-cookbook/pull/15 for suitable change to awscli cookbook.

[cmlicata]

@atward, would you still like to see this in 1.2.0?

[atward]

I believe the cookbook should be patched as suggested, but I'll defer release decisions to yourself. I have no immediate need for this as my tooling still uses the deprecated awscli-cookbook.

[cmlicata]

Ok, I will be sure to add this in. Thanks for pointing it out.