Christian Flach

Results 104 comments of Christian Flach
trafficstars

> I'm not an expert in semantic HTML and accessibility, does this violate any existing rule, or is it just more convenient for you to crawl the doc and create...

I am unable to use `createRequire`, because I'd need `import.meta.url` for it: Input: ``` const path = require('path'); module.exports = { entry: './src/index.js', devtool: 'eval-source-map', target: 'node18', externalsPresets: { node:...

The idea here is to introduce a new `meta:` key in the achievement configuration which can contain any kind of information, depending on the use case. You could, for example,...

> Can be implemented via Dependency Injection. To give some more context, the AmqpConnector should be refactored to receive the amqplib instance during construction. This allows a test to supply...

I think we discussed this thoroughly last Thursday. Can this be closed @sebastiankliem?

Hey @JulioJu, good point. Note though, that this repo only uses `php-http/guzzle6-adapter` as a dev dependency for testing, so users of this library should be able to upgrade without me...

Thank you, both are added now.

Thank you, and apologies for the long delay! I just made some minor stylistic changes and fixed the default value in the README.

Thank you! I've removed your second commit, because lunr-languages does not support Farsi. You should specify `ar` as the language in the options instead, or contribute to https://www.npmjs.com/package/lunr-languages to support...