MagicMouse icon indicating copy to clipboard operation
MagicMouse copied to clipboard

Consider a code formatter for the smalltalk part

Open MichaelBuessemeyer opened this issue 3 years ago • 3 comments
trafficstars

Hi @cmfcmf,

I have been working with your awesome project for some weeks now. I can see that some functions are not formatted perfectly (which is a very personal opinion). Thus I used formatter for Squeak by @tom95 to format the code. This would have the benefit of consistent formatted code, could clean up my mess and could lead to lesser merge conflicts :)

Here is the code formatter: https://github.com/hpi-swa-teaching/poppy-print

Do you think it would be a nice addition to this project? If yes, I'd like to open a PR for that. But I don't know how to add a package dependency to the project 🤷 . Could you please me out here in that case?

MichaelBuessemeyer avatar Jan 21 '22 20:01 MichaelBuessemeyer

Hi @MichaelBuessemeyer! poppy-print currently doesn't have support to be integrated as part of a toolchain in the same way e.g. prettier in JS does. If @cmfcmf is fine with this, the current workflow would likely be:

  • create a PR with all code autoformatted
  • update the README/CONTRIBUTING with instructions on how to reformat code before committing using poppy-print

tom95 avatar Jan 22 '22 09:01 tom95

  • create a PR with all code autoformatted
  • update the README/CONTRIBUTING with instructions on how to reformat code before committing using poppy-print

Sounds good to me!

cmfcmf avatar Jan 22 '22 09:01 cmfcmf

Sounds good to me!

Alrighty 👯, here it is: #16

MichaelBuessemeyer avatar Jan 30 '22 10:01 MichaelBuessemeyer