elm-ethereum icon indicating copy to clipboard operation
elm-ethereum copied to clipboard

Significant rewrite of Abi.Encode

Open oguimbal opened this issue 3 years ago • 1 comments

Hi !

I've been toying a bit with web3 & Elm.

It seems to me that the abi encoder is significantly broken when it comes to complex structs, or encoding dynamic lists that themselves contains nested pointer indirections.

I've rewritten the whole encoder, and added some tests.

Tests have either been created from ethers.js AbiEncdoer output, or from calls expected by our smartcontracts (I've deployed an app in prod that uses this encoder... works like a charm)

Given that this is a rewrite, I wont mind at all if you're not willing to merge this, though :) That's up to you !

nb: I've also exposed the struct function from your Abi.Decode, which works well for me, despite your frightening comment !

nb2: I'm new to Elm, so please forgive any weird coding style !

Cheers & thanks for this lib !

oguimbal avatar Mar 03 '22 17:03 oguimbal

Updated with some bugfixes + several unit tests (generated from ethersjs AbiEncoder behaviour)

oguimbal avatar Apr 01 '22 08:04 oguimbal