cmder
cmder copied to clipboard
Development BUG - Fixes launcher overwriting or not backing up terminal emulator settings in development branch.
- Fixes #2940
Added below after comparing to working code in master:
Note: Line numbers are from the PR Code not the original code
297 if (PathFileExists(cfgPath))
298 {
299-338 indent <original code>
339 }
Removed ** code ** below after comparing to working code in master:
Note: Line numbers are from the PR Code not the original code
293 <original code> **wcscmp(cpuCfgPath, L"") == 0 &&** <original code>
338 <original code> **wcscmp(userCfgPath, L"") == 0 &&** <original code>
443 <original code> **wcscmp(cfgPath, L"") == 0 &&** <original code>
Everything else is a comment or a { bracket line change
I have tested this code and it works using the following reproduction steps:
How to validate the fix.
- Download and extract conemu and windows terminal artifacts built by this PR.
- Run
cmder.exefor each artifact is being tested - Validate default tasks/profiles are present.
- Edit/Add a profile/task in Windows Terminal or ConEmu depending which artifact is being tested
- Close Windows Terminal or ConEmu depending which artifact is being tested
- Run
cmder.exefor each artifact is being tested - Profile Edits/Adds are still present.
- Exit ConEmu /Windows Terminal depending which artifact is being tested
- Delete Terminal emulator settings files for conemu(conemu.xml) and windows terminal(settings.json)
- Run
cmder.exefor each artifact is being tested - Validate your edited tasks/profiles are present
This is ready to commit.