Colin Caine

Results 112 comments of Colin Caine

They support MP4, which would probably still be an improvement. On Mon, 18 May 2020, 19:03 cormullion, wrote: > not sure webm is supported on Apple mobile devices... > >...

Probably not, if people are reporting success with 253. My comment about pinning the alpine version is still relevant, tho. An alternative would be testing the dockerfile with CI, but...

Each branch needs to terminate somewhere with a middleware that expects a single argument (like `notfound()` or `respond("something")`). `route` and `method` are both branching middlewares: they expect not to be...

You can stream data with websockets, but not with regular HTTP with Mux. That's because `serve(app)` expects a function that goes `HTTP.Request -> HTTP.Response` and `HTTP.jl` expects the body of...

I think this is an invalid ticket for Mux because, as I said earlier and as you seem to agree, this is an issue for HTTP.jl to decide on. HTTP.jl...

Yes, I think we should at least document how to test without opening sockets. I don't think this is only useful for regression testing. All you need to do is...

I talked about removing mk_response in another PR and might do that. Making App callable is what I was thinking of doing, too, but I haven't thought it all through...

Thanks for looking into this! Could you paste in here an example stack trace with and without this PR?

I think that having Mux work with Revise is worthwhile, but I'm not totally sold on this approach. I don't really like that we're closing and re-opening the socket, either,...

I still get this with HTTP.jl 0.9.2. You're right that this is an upstream issue, though.