Christoph M. Becker

Results 597 comments of Christoph M. Becker

> It's not intuitive at all. If I do a `new class()` I **expect** it to create a **new class** every time I do that. I would not necessarily expect...

@saundefined, `SplFileInfo::_bad_state_ex()` is undocumented so far.

> Even though both `mail.force_extra_parameters` and `mail.log` are [PHP_INI_SYSTEM|PHP_INI_PERDIR](https://www.php.net/manual/en/ini.list.php). There are deliberate additional restrictions, though: https://github.com/php/php-src/blob/a83923044c48982c80804ae1b45e761c271966d3/main/main.c#L644-L647 and https://github.com/php/php-src/blob/a83923044c48982c80804ae1b45e761c271966d3/main/main.c#L630-L635 The [sparse overview of `mail.force_extra_parameters`](https://www.php.net/manual/en/ini.list.php) already hints at that by claiming the...

> To me, this looks more like an implementation issue because `$offset` may depend on external factors such as user's input, and code most often doesn't expect the function's seeking...

Indeed. `max()` has the same problem; and we should probably clarify, that "calling min() with an empty array as argument" refers to the second signature (see https://3v4l.org/Ic2BQ).

> To specify a literal single quote, escape it with a backslash (\). To specify a literal backslash, double it (\\). All other instances of backslash will be treated as...

Yeah, that might be better (although we should change the grammar to avoid personalization). What do others think about this?

Thank you for the PR! I'm not sure if we need to explicitly document this, since it is [already documented](https://www.php.net/manual/en/language.enumerations.expressions.php): > Because cases are represented as constants on the enum...

Thanks all! Okay, so let's document this. I don't think the changelog entries make much sense, though, since enums are generally only available as of PHP 8.1, so there is...

See the example below that note for what it is about (namely variable variables). I agree though, that it might make sense to clarify this. @Girgias, thoughts?