Chiara Marmo comments

Results 178 comments of


                                            Chiara Marmo

FIX behaviour of `check_estimator` with `require_positive` tags of a regressor

Hi @rprkh , you already have one approval. Do you mind synchronizing with upstream? This will update the checks and make the second review easier. Thanks for your work so...

Add a page on the website to provide directions to users on how to reach out

@reshamas, @rriccilopes , I'm ok to merge this one as is (removing duplicates from the FAQ page, can be done later)... But I don't have the rights to approve. Perhaps,...

red/green scatter plots. Colorblindness friendlyness in Documentation

All the examples needing reworking have been modified. Thanks to all the contributors who help to solve this issue! Happy to close! :rocket:

Added colorblind compatibility cluster examples

I am closing this pull request as all the examples have been modified (some of them using suggestions from this PR). Thanks @johannah for working on this.

Flaky test: test_nested_loop_error_in_grandchild_resource_tracker_silent

Also observed in the [amd64 build for debian](https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/joblib.html)

ma.masked_invalid(a, copy=False) does not modify a

Hello everybody, I see this issue is labeled for sprints, may I have a look at it even outside a sprint? If so, may I ask which solution is recommended...

BUG: Make `mask_invalid` consistent with `mask_where` if `copy` is set to `False`

> @cmarmo are you interested in having a look at that, the instructions are in `numpy/doc/release/upcoming_changes/README.txt` (you basically add a file in that folder with a `22046.change.rst` as name). I...

Fix reading of MBFITS tables with variable length array

I have rebased on main because of conflicts and added a test about `TDIM`: is `'(1,1)'` the expected result? Thanks!

Fix reading of MBFITS tables with variable length array

Eventually, I understood your comment ... 😖 That means my test is bad too .... Working on it and adding your change.

Fix reading of MBFITS tables with variable length array

Digging deeper I realized that my solution was wrong: I didn't trust the standards... :) I have reconsidered and I'm more confident now: that's why I have rebased and squashed...