Craig Manley comments

Results 39 comments of


                                            Craig Manley

Smarty v5 built-in json_encode modifier doesn't take Smarty $_CHARSET encoding into account, and can't be overridden using registerPlugin()

Thanks. I sent my custom version of the json_encode modifier to your support@ email address.

Smarty v5 built-in json_encode modifier doesn't take Smarty $_CHARSET encoding into account, and can't be overridden using registerPlugin()

At the top of this page where the envelope is: https://github.com/iwink

Smarty v5 built-in json_encode modifier doesn't take Smarty $_CHARSET encoding into account, and can't be overridden using registerPlugin()

In my opinion no. The use of Smarty isn't necessarily the final stage in a process flow. That means the data being read by Smarty, may also be used after...

Smarty v5 built-in json_encode modifier doesn't take Smarty $_CHARSET encoding into account, and can't be overridden using registerPlugin()

Yes exactly. The output of json_encode must remain UTF-8 because that is in the definition of JSON. That is a known fact that the template user should be aware of....

Smarty v5 built-in json_encode modifier doesn't take Smarty $_CHARSET encoding into account, and can't be overridden using registerPlugin()

I don't mind doing so, but I'd have to dive into the code to figure out where to place the transcoding helper function/method (that I mailed you) and where/how to...

Smarty v5 built-in json_encode modifier doesn't take Smarty $_CHARSET encoding into account, and can't be overridden using registerPlugin()

I've taken a quick look at the Smarty code and I think I know what needs to be done to fix json_encode. Please tell me if I'm on the right...

Smarty v5 built-in json_encode modifier doesn't take Smarty $_CHARSET encoding into account, and can't be overridden using registerPlugin()

I just created the PR: https://github.com/smarty-php/smarty/pull/1016

setCellValueByColumnAndRow deprecated??

It would've been nice if the removal notice was included in the 2.0.0 release notes instead of a subtle reference to a huge commit of deprecated things: https://github.com/PHPOffice/PhpSpreadsheet/commit/816b91d0b4a0c7285a9e3fc88c58f7730d922044 I ran...

setCellValueByColumnAndRow deprecated??

Thanks. I found another deprecation (FORMAT_DATE_YYYYMMDD2) in a later 1.* release too, In case anybody runs into the same issues as me, here are the sed commands I used to...