python-elasticsearch-logger icon indicating copy to clipboard operation
python-elasticsearch-logger copied to clipboard

Logger is not lazy, but CMRESHandler is

Open Aethylred opened this issue 5 years ago • 0 comments

Pylint now warns that "Logger is not lazy" when you use % to do string formatting, meaning you just pass the strings and replacements directly rather than % (list, of, things, being, replaced)

However, CMRESHandler is lazy and just passes these on as arguments so when logger us used to log to file you see:

Completed provisioning 0 of 1077 directories for 0 of 0 users in 0:04:51.466437

But in elastic search you see:

msg:Completed provisioning %s of %s directories for %s of %s users  in %s args:0, 1077, 0, 0, 0:04:51.466437

Aethylred avatar Mar 19 '20 22:03 Aethylred