python-elasticsearch-logger icon indicating copy to clipboard operation
python-elasticsearch-logger copied to clipboard

Timeout parameters passed to Elasticsearch object

Open kusha opened this issue 6 years ago • 6 comments

Create timeout and retry on timeout parameters in the handler constuructor. Parameters passed to Elasticsearch object, and used while performing bulk_send().

kusha avatar Sep 04 '18 07:09 kusha

Codecov Report

Merging #54 into master will increase coverage by 0.43%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage      83%   83.43%   +0.43%     
==========================================
  Files           2        2              
  Lines         153      157       +4     
  Branches       20       20              
==========================================
+ Hits          127      131       +4     
  Misses         22       22              
  Partials        4        4
Impacted Files Coverage Δ
cmreslogging/handlers.py 82.66% <100%> (+0.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e042bb...1c92ac9. Read the comment docs.

codecov-io avatar Sep 04 '18 07:09 codecov-io

@cmanaha I think this is a very useful feature and I would like to have this too. Can I do anything to support merging this?

KonstantinSchubert avatar Mar 20 '19 12:03 KonstantinSchubert

@cmanaha Ping

KonstantinSchubert avatar Apr 17 '19 09:04 KonstantinSchubert

@KonstantinSchubert ; Apologies for about being completely absent. Konstantin, I've added you to the collaborators of the project. I have not managed to allocate and commit time for keeping this project up to date for the last few months, and the project indeed still need some love (this pull request is an example, + eventually upgrade to 6, and others).

I have to disclose also I joined AWS about 4 months ago. I'd like at some point to spend time to get some of the other integrations people have been asking (role, auth certificates, and stuff like that), but I'll not be able to commit the time for the next 3 months.

cmanaha avatar Apr 18 '19 17:04 cmanaha

@kusha Paging.

KonstantinSchubert avatar Apr 19 '19 21:04 KonstantinSchubert

@KonstantinSchubert I've applied your suggestions. Feel free to merge.

kusha avatar Apr 24 '19 20:04 kusha