python-elasticsearch-logger icon indicating copy to clipboard operation
python-elasticsearch-logger copied to clipboard

Nonblocking sending, multi-processing and multi-threading support

Open kusha opened this issue 6 years ago • 2 comments

Hi,

I'm using your logger in my application. I've made some changes (modified inherited CMRESHandler class):

  • the application logs a lot of messages, so I've implemented non-blocking logging (via multiprocessing queue and bulk_send in a separate process);
  • it is a multiprocessing application, where some processes have multiple threads, so there are additional changes.

I can prepare a pull request, and leave it as another class (not everyone needs those features). Are you interested in?

kusha avatar Aug 03 '18 06:08 kusha

As a user, I am very interested in your fork.

ajhodges avatar Aug 22 '18 18:08 ajhodges

Have you added to it testing cases and coverage to it ? Was there any reason in particular to deviate so much from the original implementation ? I guess that just reading the code and checking with the tests you have should give all the evidence on why to change the implementation.

As for merging. I'd suggest keeping it simple. If your tests/coverage and the implementation show's thats a better approach, I'd rather prefer to consolidate into one solution (your solution) that works well in both cases. There is no need for duplication or extra complexity...

cmanaha avatar Sep 24 '18 21:09 cmanaha