python-elasticsearch-logger icon indicating copy to clipboard operation
python-elasticsearch-logger copied to clipboard

Published 20 hours ago • verified publisher icon cmanaha

elasticsearch sniffing support?

Open pingz opened this issue 6 years ago • 3 comments

The elasticsearch-py documents recommend turn on sniffing when application is long-running to make sure client is aware of the changes about the cluster location. I think it is worth trying to support it.

ref: https://elasticsearch-py.readthedocs.io/en/master/#sniffing

pingz avatar Mar 21 '18 11:03 pingz

Makes sense; Setting it as an extra parameter with default to true seems the way to go. One for next iteration or if anyone would like to pick up that PR.

cmanaha avatar Mar 21 '18 22:03 cmanaha

@cmanaha thanks for your reply, I've opened PR #42 , would you be kind enough to review it?

pingz avatar Mar 22 '18 06:03 pingz

Commented on the PR; Hopefully this weekend or the next I'd like to spend some time merging all changes, running tests and checking if there is any additional test we should do (in regards to sniffing). Thanks a lot for your PR's !

cmanaha avatar Mar 23 '18 00:03 cmanaha