python-elasticsearch-logger icon indicating copy to clipboard operation
python-elasticsearch-logger copied to clipboard

Should `msg` also be included in filter fields?

Open pingz opened this issue 6 years ago • 1 comments

msg is not included in logging.Formatter documents, and will be included in the elasticsearch message body, as you're not excluding it here. If you using this handler just for one specific logger statement, it is fine. If you want to apply it to global logger, and there will be various types of msg coexisted, then elasticsearch will drop some messages because of that.

pingz avatar Mar 19 '18 10:03 pingz

Codecov Report

Merging #40 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   82.78%   82.78%           
=======================================
  Files           2        2           
  Lines         151      151           
  Branches       18       18           
=======================================
  Hits          125      125           
  Misses         22       22           
  Partials        4        4
Impacted Files Coverage Δ
cmreslogging/handlers.py 81.94% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6765a24...da2b9d7. Read the comment docs.

codecov-io avatar Mar 19 '18 10:03 codecov-io