Cody Maloney

Results 44 comments of Cody Maloney

gh-143008: fix TextIOWrapper.truncate via re-entrant flush

I agree `CHECK_ATTACHED` is easy to forget and I'd argue this bug is the result of some cases missing it.. It is a relatively small change though and matches the...

gh-143008: fix TextIOWrapper.truncate via re-entrant flush

I'm starting to think a small refactor of `TextIOWrapper` to add and use a helper that _always_ checks `self->ok` + `self->attached` would be better here; wrote up more thoughts in...

`Path.write_text` does not check whether LF is preceded by CR before converting it to CRLF on windows, resulting in CRCRLF

`pathlib.Path` is just forwarding to the standard Python I/O stack and not adding any new behaviors here ([source code](https://github.com/python/cpython/blob/68fcb958eb0c023cb895217fdf384206b09d12e8/Lib/pathlib/__init__.py#L978-L986), I/O Docs: https://docs.python.org/3/library/io.html#io.TextIOWrapper). The newline behavior has been around since the...

`Path.write_text` does not check whether LF is preceded by CR before converting it to CRLF on windows, resulting in CRCRLF

CPython follows a backwards compatibility policy outlined in PEP-387. That also has a section on how to propose and make backwards incompatible changes.