Cristian Maglie

Results 185 comments of Cristian Maglie

@matthijskooijman On #151 we used your rules: * Sketch fails to compile -> emit message as warning, in red * Verbose compilation enabled -> emit message as informational, in white...

> @cmaglie, I haven't looked at arduino-preprocessor yet, but is that also going to handle preprocessing and include detection? If so, are these issue going to be irrelevant? It does...

IMHO the difference between the original java version and this one is in the loop here: ``` go for _, row := range rows { depStat, err := os.Stat(row) if...

Well, to be precise, there is already the condition `if os.IsNotExist(err) {` that should handle the "file not found" error, the problem is that in this case the error is...

> Wouldn't it be better to keep this issue open until it is really properly fixed yes, github auto-closed the issue becuase of my comment on the PR.

@RatGit the semantic of `-U` parameter has been changed from 1.7. You may want to try to replace `--usb-port=true` or `-U true` to just `-U`

@pjalocha @RatGit try also to add `-o 0x2000` to the command line (I suppose you're running a SAMD21 based board), previously the offset to skip the bootloader size was built-in...

Looks like the problem is in the `go.mod` file that has the wrong import path: https://github.com/mattn/go-colorable/blob/8029fb3788e5a4a9c00e415f586a6d033f5d38b3/go.mod#L1 it should be: ``` module gopkg.in/mattn/go-colorable.v0 ``` the same import should be fixed on...

The problem is with `go mod` not gopkg. Here the steps to reproduce: ``` ~/Workspace/test$ go mod init test go: creating new go.mod: module test ~/Workspace/test$ cat > main.go package...

ah, now I see what you mean, I must import: ``` import "github.com/mattn/go-colorable" ``` instead of: ``` import "gopkg.in/mattn/go-colorable.v0" ``` that solved the issue for me. Thanks!