BundleLocalization icon indicating copy to clipboard operation
BundleLocalization copied to clipboard

UIImagePickerController is not localized

Open emadhegab opened this issue 9 years ago • 10 comments

the control buttons in the UIImagePickerController specially in the camera is showing the locale key of the strings .. any idea?

emadhegab avatar Aug 29 '15 12:08 emadhegab

I believe those are a part of the system, so they cannot be localized.

I think you can get them directly from view hierarchy am set their caption, however you may face compatibility issues with newer/older versions.

On 29 aug. 2015, at 15:44, Mohamed Emad Hegab [email protected] wrote:

the control buttons in the UIImagePickerController specially in the camera is showing the locale key of the strings .. any idea?

— Reply to this email directly or view it on GitHub https://github.com/cmaftuleac/BundleLocalization/issues/1.

cmaftuleac avatar Aug 29 '15 12:08 cmaftuleac

that's sad.. it works fine depending on the localization of the device if i remove your code.. the only solution now is to use another third party camera ..

emadhegab avatar Aug 29 '15 12:08 emadhegab

I think you shouldnt bother, there are many more controls that behave like that (camera, mail, contacts, date/time etc)...

On 29 aug. 2015, at 15:58, Mohamed Emad Hegab [email protected] wrote:

that's sad.. it works fine depending on the localization of the device if i remove your code.. the only solution now is to use another third party camera ..

— Reply to this email directly or view it on GitHub https://github.com/cmaftuleac/BundleLocalization/issues/1#issuecomment-135983634 .

cmaftuleac avatar Aug 29 '15 13:08 cmaftuleac

Checkout my fork. I fixed the issue with system frameworks not using localized strings or not using the language set using setLanguage:

jbolter avatar Oct 12 '15 23:10 jbolter

very nice.. it's actually fixed .. good job... I think @cmaftuleac should have a pull request to merge it with the original pod :dart:

emadhegab avatar Oct 13 '15 07:10 emadhegab

Glad to hear it fixed your issue as well. I did file a pull request with @cmaftuleac ... https://github.com/cmaftuleac/BundleLocalization/pull/2

jbolter avatar Oct 13 '15 19:10 jbolter

@jbolter thank you for your contribution! I will merge, but want to do some testing first.

Setting "AppleLanguages" in user default will require application restart. This way I believe this is a partial fix, because if you change the language system frameworks will not change until restart, right?

cmaftuleac avatar Oct 14 '15 13:10 cmaftuleac

I noticed its crashing on iphone 4s with ios 9. Is that common?

emadhegab avatar Oct 14 '15 20:10 emadhegab

@jbolter Thanks! this fixed the problem I am facing

cupnoodle avatar Oct 28 '16 07:10 cupnoodle

@cmaftuleac Sorry for the late reply... never saw your comment previously. Yes that's really the best we can do I think since the system frameworks won't change until the next launch of the app. @cupnoodle glad it helped!

jbolter avatar Oct 28 '16 20:10 jbolter