Colors for hl-line-mode

[dakrone]

Currently the colors for hl-line-mode are a bit stark, in code:

And in some cases (like Magit), they render the text entirely unreadable:

Are these the desired colors?

[cmack]

The first image are the intended colors. Since it's a selection, I felt high contrast was best. Your magit image however appears different than mine -- the text color should be the normal foreground color. The background color does appear correct. Do you have other themes enabled at the same time as planet?

[dakrone]

@cmack no other theme enabled at the time, just hl-line-mode enabled in magit.

As far as the high contrast, the contrast isn't so bad, but it does clobber any foreground colors of the text for the current line, which is unfortunate. I can always manually override it with a different color if that's desired though.

[cmack]

I see, I'm not a user of hl-line-mode so I think it's just inheriting from one of the highlight faces I do have specified. I think I just need to add a custom hl-line-face. I'll leave this ticket open as a feature request. I'm a little busy this week so it might take a little while to get to it. I'm open to pull requests though :)